From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/rust: disable ninja
Date: Sat, 20 Feb 2021 17:03:59 +0100 [thread overview]
Message-ID: <20210220160359.GK2276@scaer> (raw)
In-Reply-To: <20210217232411.290242-1-romain.naour@gmail.com>
Romain, All,
On 2021-02-18 00:24 +0100, Romain Naour spake thusly:
> Ninja has recently be enabled as the default build system to build
> llvm fork for rust compiler [1]. But we can still use Make if
> "ninja = false" is provided in config.toml.
>
> Ninja support can be enabled by a following patch.
>
> [1] https://github.com/rust-lang/rust/commit/30b7dac745b1555cd96f41977f7d24435cbe7fa2
>
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/1019386205
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>
Applied to master, thanks.
If you have time, it would be great to investigate switching the cmake
backend to ninja.
Regards,
Yann E. MORIN.
> ---
> package/rust/rust.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/rust/rust.mk b/package/rust/rust.mk
> index 798450e04e..a38a3d64f5 100644
> --- a/package/rust/rust.mk
> +++ b/package/rust/rust.mk
> @@ -65,6 +65,8 @@ define HOST_RUST_CONFIGURE_CMDS
> echo 'channel = "stable"'; \
> echo '[target.$(RUSTC_TARGET_NAME)]'; \
> echo 'cc = "$(TARGET_CROSS)gcc"'; \
> + echo '[llvm]'; \
> + echo 'ninja = false'; \
> ) > $(@D)/config.toml
> endef
>
> --
> 2.29.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2021-02-20 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 23:24 [Buildroot] [PATCH] package/rust: disable ninja Romain Naour
2021-02-18 19:00 ` Arnout Vandecappelle
2021-02-18 20:32 ` Romain Naour
2021-02-19 8:24 ` Arnout Vandecappelle
2021-02-20 16:03 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210220160359.GK2276@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.