From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FBDAC433DB for ; Sun, 21 Feb 2021 00:49:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE5D764E76 for ; Sun, 21 Feb 2021 00:49:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE5D764E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eN2V+ZfK0yS5lASVg36ZYnBCBHR0IdhrZnJjdWbioXY=; b=xYTRlkFpFUfEpj6o+DWl5B7n1 s7VuPNcnx1U0zjymFLHEPPaWm5Gpac71ARwiPBzSTXIwdzA0o3Ui6B3spVMlTWN1hLdDSO+IGolyE wcrwl+ZYRcE0NrEIehPY5MPZz3pQrjp4LPmP2Ls3opj3LiKFYQppu814SMqV56USBoD2tFMUeIqro a9hYKDBfNIrkzr08LqnKB9xROEiRFDMP8dWyg5yGkbQunWMKyqEHeso2rLK9ST5b6gBobxXg2ORnM clqKeTIIOOBRk3tD+XPMA2QCXcNY7D0UczmR+7CPGKTZ4Kbtg+XpBtkAvGcd6LgrkVTdOm9CNvBWV t6z9B0Bmg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDcuu-0006iV-WC; Sun, 21 Feb 2021 00:48:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDcuo-0006i8-CG for linux-arm-kernel@lists.infradead.org; Sun, 21 Feb 2021 00:48:06 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2750E64EEC; Sun, 21 Feb 2021 00:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613868480; bh=r14iUsjUvnohout+zDvHf58KhX6qgwjdyP6eV/RkbAM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rRAslTVA6aCbhpQFBDCTygRPzLmQKYyE7HbzPXQ5vOCeC3TXG+VnMdSCLPQsgjpF9 oUK5JMvBHrVDLQn03lxB0Rq3Nv1g9l2uL4HQm4a4V+ukvuVDhy7dFHw8DHkHT4yD5Z OnxqJige04464iGGJF60GregC0BEop7cgQ4q4sJLbUUqn29kLNs9mSdxhf0fzNX9/C VDx8hiPLFkitRLKWR1L0JdRRvZisyxe7M3p0bG34eDmEynfy1SePVJf+E2B3qytGor pAyLMj4wLRFcYYX60kLug3PTLNhNcM1enzvrvajydvIn5THwvCKAjMtX72MPEjlVNa N87y2Gp4GYrbw== Date: Sun, 21 Feb 2021 01:47:56 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Andrew Lunn Subject: Re: [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin Message-ID: <20210221014756.7c444c08@kernel.org> In-Reply-To: References: <20210220231144.32325-1-kabel@kernel.org> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210220_194805_608029_B6B655AC X-CRM114-Status: GOOD ( 25.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Rui Salvaterra Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCAyMSBGZWIgMjAyMSAwMToxMDo1NyArMDEwMApBbmRyZXcgTHVubiA8YW5kcmV3QGx1 bm4uY2g+IHdyb3RlOgoKPiBPbiBTdW4sIEZlYiAyMSwgMjAyMSBhdCAxMjoxMTo0NEFNICswMTAw LCBNYXJlayBCZWjDum4gd3JvdGU6Cj4gPiBVc2UgdGhlIGBtYXJ2ZWxsLHJlZy1pbml0YCBEVCBw cm9wZXJ0eSB0byBjb25maWd1cmUgdGhlIExFRFsyXS9JTlRuIHBpbgo+ID4gb2YgdGhlIE1hcnZl bGwgODhFMTUxNCBldGhlcm5ldCBQSFkgb24gVHVycmlzIE9tbmlhIGludG8gaW50ZXJydXB0IG1v ZGUuCj4gPiAKPiA+IFdpdGhvdXQgdGhpcyB0aGUgcGluIGlzIGJ5IGRlZmF1bHQgaW4gTEVEWzJd IG1vZGUsIGFuZCB0aGUgTWFydmVsbCBQSFkKPiA+IGRyaXZlciBjb25maWd1cmVzIExFRFsyXSBp bnRvICJPbiAtIExpbmssIEJsaW5rIC0gQWN0aXZpdHkiIG1vZGUuCj4gPiAKPiA+IFRoaXMgZml4 ZXMgdGhlIGlzc3VlIHdoZXJlIHRoZSBwY2E5NTM4IEdQSU8vaW50ZXJydXB0IGNvbnRyb2xsZXIg KHdoaWNoCj4gPiBjYW4ndCBtYXNrIGludGVycnVwdHMgaW4gSFcpIHJlY2VpdmVkIHRvbyBtYW55 IGludGVycnVwdHMgYW5kIGFmdGVyIGEKPiA+IHRpbWUgc3RhcnRlZCBpZ25vcmluZyB0aGUgaW50 ZXJydXB0IHdpdGggZXJyb3IgbWVzc2FnZToKPiA+ICAgSVJRIDcxOiBub2JvZHkgY2FyZWQgIAo+ IAo+IEhpIE1hcmVrCj4gCj4gVGhlIHBjYTk1MzggYW5kIGFsaWtlIGFyZSBhIHBvb3IgY2hvaWNl IGZvciBpbnRlcnJ1cHRzLiBBcyB5b3Ugc2FpZCwKPiB5b3UgY2Fubm90IG1hc2sgaW50ZXJydXB0 cywgYW5kIGlucHV0IGFyZSBpbnRlcnJ1cHQgc291cmNlcy4KPiAKPiBXaXRoIHRoaXMgY2hhbmdl LCBkb2VzIGl0IGFjdHVhbGx5IHdvcmsgcmVsaWFibHk/IEl0IGxvb2tzIGxpa2UgYWxsCj4gdGhl IGlucHV0cyB5b3UgaGF2ZSBzdXBwb3J0IHBvbGxpbmcuIEFuZCBiZWNhdXNlIHRoaXMgZGV2aWNl cyBpcyBzbwo+IHVucmVsaWFibGUgd2l0aCBpbnRlcnJ1cHRzLCBpbnRlcnJ1cHQgc3VwcG9ydCBp cyBtb3N0bHkgbm90IGJ1aWx0LiBJCj4gd291bGQgbm90IGV4cGVjdCBhIGRpc3RyaWJ1dGlvbiBr ZXJuZWwgdG8gZW5hYmxlIGludGVycnVwdCBzdXBwb3J0IGZvcgo+IHRoaXMgZHJpdmVyLiBEb2Vz IGFsbCB0aGUgY29kZSBjb3JyZWN0bHkgZmFsbCBiYWNrIHRvIHBvbGxpbmcgd2hlbgo+IGludGVy cnVwdHMgYXJlIG5vdCBhdmFpbGFibGU/Cj4gCj4gU28gYWx0aG91Z2ggdGhlIHBhdGNoIGxvb2tz IE8uSywgaSdtIGp1c3Qgd29uZGVyIGlmIGl0IGlzIHdvcnRoIGl0LCBvcgo+IHRoZSBiZXR0ZXIg Zml4IGlzIHRvIHJlbW92ZSB0aGUgaW50ZXJydXB0IGNvbmZpZ3VyYXRpb24gZnJvbSB0aGUKPiBw Y2E5NTM4IG5vZGUuCj4gCj4gCUFuZHJldwoKSGkgQW5kcmV3LAoKLSB3ZSBhbHJlYWR5IGRpc2N1 c3NlZCB0aGlzIGFuZCB5b3UgZXhwbGFpbmVkIHRvIG1lIHRoYXQgcGNhOTUzOCBpcyBwb29yCiAg YXMgYW4gaW50ZXJydXB0IHNvdXJjZS4gVGhhdCBpcyB3aHkgSSBkaWQgbm90IHNlbmQgcGF0Y2gg YWRkaW5nCiAgaW50ZXJydXB0LXNvdXJjZSB0byB0aGUgUEhZIG5vZGUgbGFzdCB0aW1lLiBXZSBh cmUgcG9sbGluZyB0aGUgUEhZCiAgZm9yIGludGVycnVwdHMgZm9yIG5vdwoKLSBJIHdvdWxkIGxp a2UgdG8gdHJ5IHRoaXMgdGhvdWdoLCBhbmQgc2VlIHdoZXRoZXIgaXQgd2lsbCBjYXVzZQogIHBy b2JsZW1zLiBVbmZvcnR1bmF0ZWx5IEkgZm9yZ290IHRvIGRvIHRoaXMgbGFzdCB0aW1lCgotIG5v bmV0aGVsZXNzIHRoZSBwaW4gaXMgY29ubmVjdGVkIGFzIGFuIGludGVycnVwdCBvbiB0aGUgYm9h cmQsIHNvIEkKICB0aGluayB0aGF0IHRoZSBQSFkgZHJpdmVyIHNob3VsZCBjb25maWd1cmUgaXQg dGhhdCB3YXksIGV2ZW4gaWYgdGhlCiAgSU5UIHNpZ25hbCBpcyBub3QgdXNlZAoKLSByZW1vdmlu ZyB0aGUgaW50ZXJydXB0cyBwcm9wZXJ0eSBmcm9tIHRoZSBwY2E5NTM4IGNvbnRyb2xsZXIgbm9k ZQogIHdvdWxkIHNvbHZlIHRoZSBpc3N1ZSBhcyB3ZWxsLiBUaGUgb3RoZXIgcGlucyBvbiB0aGUg Y29udHJvbGxlciBhcmUKICB1c2VkIGZvciBTRlAgY2FnZSBHUElPcyBhbmQgdGhlIHdheSB0aGUg cGNhOTUzeCBkcml2ZXIgaXMgd3JpdHRlbiwKICB0aGUgR1BJT3MgYXJlIHBvbGxlZCBhbnl3YXkg LSB0aGUgaW50ZXJydXB0IGlzIG5vdCB1c2VkIGZvciB0aGVtCgpBbGwgaW4gYWxsIEkgdGhpbmsg Zm9yIG5vdyB0aGlzIHNvbHV0aW9uIGlzIGJlc3QgKHNpbmNlIHRoZSBwaW4gaXMKX21lYW50XyB0 byBiZSB1c2VkIGFzIGFuIGludGVycnVwdCBwaW4gb24gdGhlIGJvYXJkIGFuZCB0aGUgaXNzdWUg aXMKc29sdmVkIGJ5IHRoaXMgcGF0Y2gpLgoKQlRXIGRvIHlvdSBoYXZlIHNvbWUgZXhwZXJpZW5j ZSB3aGVyZSBwY2E5NTM4IG9yIGNvbXBhdGlibGUgY2F1c2UKZXJyb3JzIHdoZW4gdXNlZCBmb3Ig aW50ZXJydXB0cz8gQmVjYXVzZSBJIGFtIHRoaW5raW5nIGFib3V0IHRyeWluZwp0byB1cGRhdGUg dGhlIHBjYTk1M3ggZHJpdmVyIHRvIHN1cHBvcnQgSVJRcyB2aWEgdGhlIGdwaW9fY2hpcCBpdApy ZWdpc3RlcnMsIGluc3RlYWQgb2YgYSBzZXBhcmF0ZSBpcnFfY2hpcC4KCk1hcmVrCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9476EC433E0 for ; Sun, 21 Feb 2021 00:48:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52B1564EF0 for ; Sun, 21 Feb 2021 00:48:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229884AbhBUAsl (ORCPT ); Sat, 20 Feb 2021 19:48:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:39480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbhBUAsl (ORCPT ); Sat, 20 Feb 2021 19:48:41 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2750E64EEC; Sun, 21 Feb 2021 00:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613868480; bh=r14iUsjUvnohout+zDvHf58KhX6qgwjdyP6eV/RkbAM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rRAslTVA6aCbhpQFBDCTygRPzLmQKYyE7HbzPXQ5vOCeC3TXG+VnMdSCLPQsgjpF9 oUK5JMvBHrVDLQn03lxB0Rq3Nv1g9l2uL4HQm4a4V+ukvuVDhy7dFHw8DHkHT4yD5Z OnxqJige04464iGGJF60GregC0BEop7cgQ4q4sJLbUUqn29kLNs9mSdxhf0fzNX9/C VDx8hiPLFkitRLKWR1L0JdRRvZisyxe7M3p0bG34eDmEynfy1SePVJf+E2B3qytGor pAyLMj4wLRFcYYX60kLug3PTLNhNcM1enzvrvajydvIn5THwvCKAjMtX72MPEjlVNa N87y2Gp4GYrbw== Date: Sun, 21 Feb 2021 01:47:56 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Andrew Lunn Cc: Gregory CLEMENT , Rui Salvaterra , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin Message-ID: <20210221014756.7c444c08@kernel.org> In-Reply-To: References: <20210220231144.32325-1-kabel@kernel.org> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, 21 Feb 2021 01:10:57 +0100 Andrew Lunn wrote: > On Sun, Feb 21, 2021 at 12:11:44AM +0100, Marek Beh=C3=BAn wrote: > > Use the `marvell,reg-init` DT property to configure the LED[2]/INTn pin > > of the Marvell 88E1514 ethernet PHY on Turris Omnia into interrupt mode. > >=20 > > Without this the pin is by default in LED[2] mode, and the Marvell PHY > > driver configures LED[2] into "On - Link, Blink - Activity" mode. > >=20 > > This fixes the issue where the pca9538 GPIO/interrupt controller (which > > can't mask interrupts in HW) received too many interrupts and after a > > time started ignoring the interrupt with error message: > > IRQ 71: nobody cared =20 >=20 > Hi Marek >=20 > The pca9538 and alike are a poor choice for interrupts. As you said, > you cannot mask interrupts, and input are interrupt sources. >=20 > With this change, does it actually work reliably? It looks like all > the inputs you have support polling. And because this devices is so > unreliable with interrupts, interrupt support is mostly not built. I > would not expect a distribution kernel to enable interrupt support for > this driver. Does all the code correctly fall back to polling when > interrupts are not available? >=20 > So although the patch looks O.K, i'm just wonder if it is worth it, or > the better fix is to remove the interrupt configuration from the > pca9538 node. >=20 > Andrew Hi Andrew, - we already discussed this and you explained to me that pca9538 is poor as an interrupt source. That is why I did not send patch adding interrupt-source to the PHY node last time. We are polling the PHY for interrupts for now - I would like to try this though, and see whether it will cause problems. Unfortunately I forgot to do this last time - nonetheless the pin is connected as an interrupt on the board, so I think that the PHY driver should configure it that way, even if the INT signal is not used - removing the interrupts property from the pca9538 controller node would solve the issue as well. The other pins on the controller are used for SFP cage GPIOs and the way the pca953x driver is written, the GPIOs are polled anyway - the interrupt is not used for them All in all I think for now this solution is best (since the pin is _meant_ to be used as an interrupt pin on the board and the issue is solved by this patch). BTW do you have some experience where pca9538 or compatible cause errors when used for interrupts? Because I am thinking about trying to update the pca953x driver to support IRQs via the gpio_chip it registers, instead of a separate irq_chip. Marek