From: Jupiter <jupiter.hce@gmail.com>
To: ofono@ofono.org
Subject: [PATCH v3 3/4] Change 3: Check SARA R4 vendor ID, need to make it conditional on the actions being attach and detach
Date: Mon, 22 Feb 2021 20:08:58 +1100 [thread overview]
Message-ID: <20210222090859.2883-4-jupiter.hce@gmail.com> (raw)
In-Reply-To: <20210222090859.2883-1-jupiter.hce@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]
From: jupiter <jupiter.hce@gmail.com>
---
drivers/qmimodem/gprs.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/qmimodem/gprs.c b/drivers/qmimodem/gprs.c
index 896a9e4c..64d90257 100644
--- a/drivers/qmimodem/gprs.c
+++ b/drivers/qmimodem/gprs.c
@@ -26,6 +26,7 @@
#include <ofono/log.h>
#include <ofono/modem.h>
#include <ofono/gprs.h>
+#include <drivers/atmodem/vendor.h>
#include "qmi.h"
#include "nas.h"
@@ -35,6 +36,7 @@
#include "qmimodem.h"
struct gprs_data {
+ unsigned int vendor;
struct qmi_device *dev;
struct qmi_service *nas;
struct qmi_service *wds;
@@ -284,6 +286,18 @@ static void qmi_set_attached(struct ofono_gprs *gprs, int attached,
DBG("attached %d", attached);
+ if (data->vendor == OFONO_VENDOR_UBLOX_SARA_R4) {
+ /* This assumes neither 'attach' nor 'detach' are
+ * necessary... if 'attach' is required, then you'll
+ * need to make this section conditional on the action
+ * being 'detach'
+ */
+ DBG("Debug vendor = OFONO_VENDOR_UBLOX_SARA_R4");
+ CALLBACK_WITH_SUCCESS(cb, cbd->data);
+ g_free(cbd);
+ return;
+ }
+
if (attached)
action = QMI_NAS_ATTACH_ACTION_ATTACH;
else
@@ -406,6 +420,7 @@ static int qmi_gprs_probe(struct ofono_gprs *gprs,
DBG("");
data = g_new0(struct gprs_data, 1);
+ data->vendor = vendor;
ofono_gprs_set_data(gprs, data);
--
2.17.1
next prev parent reply other threads:[~2021-02-22 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 9:08 [PATCH v3 0/4] SARA R4 patches Jupiter
2021-02-22 9:08 ` [PATCH v3 1/4] Change 1: SARA R4 QMI support Jupiter
2021-02-22 9:08 ` [PATCH v3 2/4] Change 2: Add SARA R4 vendor ID Jupiter
2021-02-22 9:08 ` Jupiter [this message]
2021-02-22 9:08 ` [PATCH v3 4/4] Change 4: Add SARA R4 vendor and enable vendor in gprs create Jupiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222090859.2883-4-jupiter.hce@gmail.com \
--to=jupiter.hce@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.