From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:690d:0:0:0:0:0 with SMTP id e13csp1916490lfc; Mon, 22 Feb 2021 09:26:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5LEPqf7Rmemcb7aEN2GXFrfpfNXdls8flVPZA6TUWlv6VZhr2itroD+TG6zje6rUyOCvI X-Received: by 2002:a92:1302:: with SMTP id 2mr16693084ilt.121.1614014768329; Mon, 22 Feb 2021 09:26:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614014768; cv=none; d=google.com; s=arc-20160816; b=xVbuT+XhMPlf/y6+bAHOLcbLg8j5TwDMMG0TivqnuwYydgcSqKW3Zy1utoBUgnM/uf 34DPZKPo+IYFX99ZQwymUgYGqkebmAURChiY3D01Cj/PiTpGXk6mjbkZ45wlp5l8DWbb SxgJsFZrgn0ipNbrCnnhA8ZB6qBStwv8zTFkFYuVOuPN3IZ4CkUgUpUZ2rUkTVbYnx8Q 2H5WAuatJumafI3QORbN/sGMsltpwm58b6DpwCHYXrMWTsdWGceXXyLQZXx1AuCHnpC3 2aG6G+fNamnB6W4D5B/9yYypbFlEEEq9l+C3+GUkNCniyKxXTrS35HcLRwzsQKbUiUpL tRnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature :sender:precedence:errors-to:list-subscribe:list-help:list-post :list-unsubscribe:list-id; bh=H5mrm3DZDcM5fraUv4fndEkj6st2YNZQP0B5Q36J9Uo=; b=wuQQ52aA5e8V7da/ZxL6XmBKPb5AUBEoVypP4Z+xnNNqwOTnZUSC6MrCCgq8a2LqRB va+cz7/YJ+SWKQn6gX9cKxdo5QXc+m/IwYKNNddPpnA7nWVKOhqJBldngwmvvpjUjjAm jftsVmMaEAFoGU1i7FO21kuH400NqKdjZzgjTEz2ogIy4jgm1heIuYyvODF21/hzrwwp s2QZP5CTME89O1xgiuGXWTRgpFEeTH8tyftS44XgO67MnYQF471+kT8QOt3eAmBb6Ler QhuKjzbJLt3JmpsyTHkg2gl5WMs5HD7JfYkJf6PLfXVy6/6VrtW2XyQAgOe0S1CBc5Tf kGBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eA2hPWtN; spf=pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id y12si17046354ilv.132.2021.02.22.09.26.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 09:26:08 -0800 (PST) Received-SPF: pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eA2hPWtN; spf=pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from list by lists.xenproject.org with outflank-mailman.88293.165904 (Exim 4.92) (envelope-from ) id 1lEEwm-00057g-4H; Mon, 22 Feb 2021 17:24:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 88293.165904; Mon, 22 Feb 2021 17:24:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEEwm-00057Z-1B; Mon, 22 Feb 2021 17:24:36 +0000 Received: by outflank-mailman (input) for mailman id 88293; Mon, 22 Feb 2021 17:24:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEEwk-00057U-R9 for xen-devel@lists.xenproject.org; Mon, 22 Feb 2021 17:24:35 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [63.128.21.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id a1baa6dd-cac0-4b3a-a573-358b91181ca3; Mon, 22 Feb 2021 17:24:32 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-1b80s02bMCOR2lkI1fzehA-1; Mon, 22 Feb 2021 12:24:29 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 498CB1936B68; Mon, 22 Feb 2021 17:24:26 +0000 (UTC) Received: from gondolin (ovpn-113-115.ams2.redhat.com [10.36.113.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id F1AD85D9D3; Mon, 22 Feb 2021 17:24:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1baa6dd-cac0-4b3a-a573-358b91181ca3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614014672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H5mrm3DZDcM5fraUv4fndEkj6st2YNZQP0B5Q36J9Uo=; b=eA2hPWtNFSBChFkO1/svU5YW0B/7ijE61JlzagtOiKJapbOMVXecxssihddYHsR2e0XcVo ufgAUMf6r3XFMvfHYKa3zY2CkQSi0rSX7jDp56bXut8qoOGt43K1w4WzGp42MTaXV71poE 6oMYOqYqgZRuPm22tG1Fwa5NrqWF4Es= X-MC-Unique: 1b80s02bMCOR2lkI1fzehA-1 Date: Mon, 22 Feb 2021 18:24:05 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Aurelien Jarno , Peter Maydell , Anthony Perard , qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, Halil Pasic , Huacai Chen , xen-devel@lists.xenproject.org, Marcel Apfelbaum , David Gibson , qemu-arm@nongnu.org, Stefano Stabellini , Paolo Bonzini , kvm@vger.kernel.org, BALATON Zoltan , Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alistair Francis , Paul Durrant , Eduardo Habkost , "Michael S. Tsirkin" , Thomas Huth , Jiaxun Yang , =?UTF-8?B?SGVydsOp?= Poussineau , Greg Kurz , Christian Borntraeger , "Edgar E. Iglesias" , David Hildenbrand , Mark Cave-Ayland , Aleksandar Rikalo , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v2 01/11] accel/kvm: Check MachineClass kvm_type() return value Message-ID: <20210222182405.3e6e9a6f.cohuck@redhat.com> In-Reply-To: <20210219173847.2054123-2-philmd@redhat.com> References: <20210219173847.2054123-1-philmd@redhat.com> <20210219173847.2054123-2-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-TUID: P3dmKIVm2RFa On Fri, 19 Feb 2021 18:38:37 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > MachineClass::kvm_type() can return -1 on failure. > Document it, and add a check in kvm_init(). >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > include/hw/boards.h | 3 ++- > accel/kvm/kvm-all.c | 6 ++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/include/hw/boards.h b/include/hw/boards.h > index a46dfe5d1a6..68d3d10f6b0 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -127,7 +127,8 @@ typedef struct { > * implement and a stub device is required. > * @kvm_type: > * Return the type of KVM corresponding to the kvm-type string option= or > - * computed based on other criteria such as the host kernel capabilit= ies. > + * computed based on other criteria such as the host kernel capabilit= ies > + * (which can't be negative), or -1 on error. > * @numa_mem_supported: > * true if '--numa node.mem' option is supported and false otherwise > * @smp_parse: > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > index 84c943fcdb2..b069938d881 100644 > --- a/accel/kvm/kvm-all.c > +++ b/accel/kvm/kvm-all.c > @@ -2057,6 +2057,12 @@ static int kvm_init(MachineState *ms) > "kvm-type", > &error_abort= ); > type =3D mc->kvm_type(ms, kvm_type); > + if (type < 0) { > + ret =3D -EINVAL; > + fprintf(stderr, "Failed to detect kvm-type for machine '%s'\= n", > + mc->name); > + goto err; > + } > } > =20 > do { No objection to this patch; but I'm wondering why some non-pseries machines implement the kvm_type callback, when I see the kvm-type property only for pseries? Am I holding my git grep wrong? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D1EC433DB for ; Mon, 22 Feb 2021 17:33:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E60A664EEC for ; Mon, 22 Feb 2021 17:33:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E60A664EEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEF55-0005Wi-RH for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 12:33:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEEwn-0005IB-8G for qemu-devel@nongnu.org; Mon, 22 Feb 2021 12:24:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEEwl-0006kG-Pe for qemu-devel@nongnu.org; Mon, 22 Feb 2021 12:24:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614014674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H5mrm3DZDcM5fraUv4fndEkj6st2YNZQP0B5Q36J9Uo=; b=UvhiIsg+yiL6fHdGsdyDyoF/KXJvWZutXFSxGq4YPfPkwZThK7yOrBZIs34mMvUdui21QP AqcKIE+bk0KIjDmZhkz2L3uUg51TnNgRYGiq+SwzSRS2oLUzxU8TP4tbGo5A5ittPwkUrA CB7UVj0nmsPCkwzRqI2xAd2qFsUsaCo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-1b80s02bMCOR2lkI1fzehA-1; Mon, 22 Feb 2021 12:24:29 -0500 X-MC-Unique: 1b80s02bMCOR2lkI1fzehA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 498CB1936B68; Mon, 22 Feb 2021 17:24:26 +0000 (UTC) Received: from gondolin (ovpn-113-115.ams2.redhat.com [10.36.113.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id F1AD85D9D3; Mon, 22 Feb 2021 17:24:07 +0000 (UTC) Date: Mon, 22 Feb 2021 18:24:05 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v2 01/11] accel/kvm: Check MachineClass kvm_type() return value Message-ID: <20210222182405.3e6e9a6f.cohuck@redhat.com> In-Reply-To: <20210219173847.2054123-2-philmd@redhat.com> References: <20210219173847.2054123-1-philmd@redhat.com> <20210219173847.2054123-2-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Received-SPF: pass client-ip=63.128.21.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , kvm@vger.kernel.org, Paul Durrant , David Hildenbrand , qemu-devel@nongnu.org, "Edgar E. Iglesias" , Stefano Stabellini , "Michael S. Tsirkin" , Huacai Chen , Halil Pasic , Christian Borntraeger , =?UTF-8?B?SGVydsOp?= Poussineau , Anthony Perard , xen-devel@lists.xenproject.org, Leif Lindholm , Thomas Huth , Eduardo Habkost , Mark Cave-Ayland , Alistair Francis , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, David Gibson , Radoslaw Biernacki , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 19 Feb 2021 18:38:37 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > MachineClass::kvm_type() can return -1 on failure. > Document it, and add a check in kvm_init(). >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > include/hw/boards.h | 3 ++- > accel/kvm/kvm-all.c | 6 ++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/include/hw/boards.h b/include/hw/boards.h > index a46dfe5d1a6..68d3d10f6b0 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -127,7 +127,8 @@ typedef struct { > * implement and a stub device is required. > * @kvm_type: > * Return the type of KVM corresponding to the kvm-type string option= or > - * computed based on other criteria such as the host kernel capabilit= ies. > + * computed based on other criteria such as the host kernel capabilit= ies > + * (which can't be negative), or -1 on error. > * @numa_mem_supported: > * true if '--numa node.mem' option is supported and false otherwise > * @smp_parse: > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > index 84c943fcdb2..b069938d881 100644 > --- a/accel/kvm/kvm-all.c > +++ b/accel/kvm/kvm-all.c > @@ -2057,6 +2057,12 @@ static int kvm_init(MachineState *ms) > "kvm-type", > &error_abort= ); > type =3D mc->kvm_type(ms, kvm_type); > + if (type < 0) { > + ret =3D -EINVAL; > + fprintf(stderr, "Failed to detect kvm-type for machine '%s'\= n", > + mc->name); > + goto err; > + } > } > =20 > do { No objection to this patch; but I'm wondering why some non-pseries machines implement the kvm_type callback, when I see the kvm-type property only for pseries? Am I holding my git grep wrong?