From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:690d:0:0:0:0:0 with SMTP id e13csp1926304lfc; Mon, 22 Feb 2021 09:39:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxK4ff2sM7PhHd43qKJ1kvmHspRVqA2e86xw5Aucv7WmPM9LMkMv89FULGCKq9gDE9DaEDG X-Received: by 2002:a05:6602:200e:: with SMTP id y14mr10720126iod.94.1614015559482; Mon, 22 Feb 2021 09:39:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614015559; cv=none; d=google.com; s=arc-20160816; b=yKdnU8zhitiK/v0kASpwESfbqW8+xX49zOaLkMAu/4Fnom11FzN2NDmapQ7UL1Si6C M79wK24tv+VrNJUU+cKoB04JWYjXyNw56SdExbJ1SK9Awl2Y+JcHrcUY+U9QxIz93/Qm g+V9JZuxpnAYiOTmOLFcPXZ0JKMsN3SZtm54GiRKYZUAYxNYvEFl72BdB3yggYwuCjrX yRVOmoUvSuDONewwrJsKskDySCtRLrdI4G6mLUNLU/bau7HaxkWGJCd2oq6aL5e3ttsl gENBydaLpYfPh1lsZEJDv0Q0CFudIAJ+deYValVmR2nvrYhSGo5SQR3NlVihkLpdDmVZ BCJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature :sender:precedence:errors-to:list-subscribe:list-help:list-post :list-unsubscribe:list-id; bh=4lA4izgL6BmBHFfoBO0go7fPCtxFMbj7pq95MLNGllc=; b=PL3T4ShBC4iC7eAk6bUM1IAlGjilIf4nMYWoBVP2d2T4l6UnA6ehA0x6VUyz7mbT+D QybxtNeLlE74fQvd2n5xjaILn3J+h4/P/9VNrsa2UxU7Xy8GEzDyvUffG0nkdskIJm6n pJb/hO1L5QeXIhpVHDVDKZQQEyqoxhq88sDcnAKyOe4u5Vl/LZjwKJXHE9KpqoBZ+3Ym LO8IAb2MJ8fbiIz88ET3y2pvb+SyQ75stS/IHVDZDt7eq1Rd7o0w6u9cg3fdF6o48AbN XHDsVZzUq8eOTzAcsQI/hSJjErBeeIYDfs1snrNGs7KH+PZov8ojtwGoTU03bpGj/WeQ +Vew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LnFc6ewX; spf=pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id h5si7129311ilh.109.2021.02.22.09.39.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 09:39:19 -0800 (PST) Received-SPF: pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LnFc6ewX; spf=pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from list by lists.xenproject.org with outflank-mailman.88302.165929 (Exim 4.92) (envelope-from ) id 1lEFA1-0006Mf-NX; Mon, 22 Feb 2021 17:38:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 88302.165929; Mon, 22 Feb 2021 17:38:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEFA1-0006MY-KE; Mon, 22 Feb 2021 17:38:17 +0000 Received: by outflank-mailman (input) for mailman id 88302; Mon, 22 Feb 2021 17:38:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEFA0-0006MT-1g for xen-devel@lists.xenproject.org; Mon, 22 Feb 2021 17:38:16 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id d88c079e-5b5f-4c27-af19-e6b89c5bcf92; Mon, 22 Feb 2021 17:38:15 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-011n0yg1NUOpvcUU3B4QYw-1; Mon, 22 Feb 2021 12:38:10 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 92829195D560; Mon, 22 Feb 2021 17:38:06 +0000 (UTC) Received: from gondolin (ovpn-113-115.ams2.redhat.com [10.36.113.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 11BEF5C1BD; Mon, 22 Feb 2021 17:37:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d88c079e-5b5f-4c27-af19-e6b89c5bcf92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614015495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4lA4izgL6BmBHFfoBO0go7fPCtxFMbj7pq95MLNGllc=; b=LnFc6ewXYM4QD9GMDLV9UCERGgaDu5QETE3r3gLZ4aaK1JFNJqKlYdzUURtKeFq9Hatv+T L4qz7jClJmYYDyfgmlrdqruyINFRGll7k5pkm+pBJGSp47K960S6J9buQHB6dWnnDEUz5q GdW6wRyh4rGPv6MvZX/u6nIcTr9tjM8= X-MC-Unique: 011n0yg1NUOpvcUU3B4QYw-1 Date: Mon, 22 Feb 2021 18:37:51 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Aurelien Jarno , Peter Maydell , Anthony Perard , qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, Halil Pasic , Huacai Chen , xen-devel@lists.xenproject.org, Marcel Apfelbaum , David Gibson , qemu-arm@nongnu.org, Stefano Stabellini , Paolo Bonzini , kvm@vger.kernel.org, BALATON Zoltan , Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alistair Francis , Paul Durrant , Eduardo Habkost , "Michael S. Tsirkin" , Thomas Huth , Jiaxun Yang , =?UTF-8?B?SGVydsOp?= Poussineau , Greg Kurz , Christian Borntraeger , "Edgar E. Iglesias" , David Hildenbrand , Mark Cave-Ayland , Aleksandar Rikalo , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v2 07/11] hw/s390x: Explicit the s390-ccw-virtio machines support TCG and KVM Message-ID: <20210222183751.0a8f2d2d.cohuck@redhat.com> In-Reply-To: <20210219173847.2054123-8-philmd@redhat.com> References: <20210219173847.2054123-1-philmd@redhat.com> <20210219173847.2054123-8-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-TUID: 441nm6FdlO30 On Fri, 19 Feb 2021 18:38:43 +0100 Philippe Mathieu-Daud=C3=A9 wrote: I'd lose the 'Explicit' in $SUBJECT. > All s390-ccw-virtio machines support TCG and KVM. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/s390x/s390-virtio-ccw.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 2972b607f36..1f168485066 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -586,6 +586,10 @@ static ram_addr_t s390_fixup_ram_size(ram_addr_t sz) > return newsz; > } > =20 > +static const char *const valid_accels[] =3D { > + "tcg", "kvm", NULL > +}; > + > static void ccw_machine_class_init(ObjectClass *oc, void *data) > { > MachineClass *mc =3D MACHINE_CLASS(oc); > @@ -612,6 +616,7 @@ static void ccw_machine_class_init(ObjectClass *oc, v= oid *data) > mc->possible_cpu_arch_ids =3D s390_possible_cpu_arch_ids; > /* it is overridden with 'host' cpu *in kvm_arch_init* */ > mc->default_cpu_type =3D S390_CPU_TYPE_NAME("qemu"); > + mc->valid_accelerators =3D valid_accels; > hc->plug =3D s390_machine_device_plug; > hc->unplug_request =3D s390_machine_device_unplug_request; > nc->nmi_monitor_handler =3D s390_nmi; Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E478C433E0 for ; Mon, 22 Feb 2021 17:43:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A65364F02 for ; Mon, 22 Feb 2021 17:43:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A65364F02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEFFL-0003eT-72 for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 12:43:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEF9z-0004eM-4d for qemu-devel@nongnu.org; Mon, 22 Feb 2021 12:38:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEF9x-0000ff-O1 for qemu-devel@nongnu.org; Mon, 22 Feb 2021 12:38:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614015493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4lA4izgL6BmBHFfoBO0go7fPCtxFMbj7pq95MLNGllc=; b=Hp/B/OeUcfKBsEHz+Ngd3FOiTmskPFgbi3sgR2FRHSAy3Fki786gn1HBx9ugYtFXdjWuif brkhz+ekHEzJhSGO+uvBYFK4DOXtXK4lAB+wpUrkPhymlxGHCXAQsN6qu5L79HOn36VRaC mA8Hqp2eN+VG7XDoFOedkVoD2HCouW4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-011n0yg1NUOpvcUU3B4QYw-1; Mon, 22 Feb 2021 12:38:10 -0500 X-MC-Unique: 011n0yg1NUOpvcUU3B4QYw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 92829195D560; Mon, 22 Feb 2021 17:38:06 +0000 (UTC) Received: from gondolin (ovpn-113-115.ams2.redhat.com [10.36.113.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 11BEF5C1BD; Mon, 22 Feb 2021 17:37:53 +0000 (UTC) Date: Mon, 22 Feb 2021 18:37:51 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v2 07/11] hw/s390x: Explicit the s390-ccw-virtio machines support TCG and KVM Message-ID: <20210222183751.0a8f2d2d.cohuck@redhat.com> In-Reply-To: <20210219173847.2054123-8-philmd@redhat.com> References: <20210219173847.2054123-1-philmd@redhat.com> <20210219173847.2054123-8-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , kvm@vger.kernel.org, Paul Durrant , David Hildenbrand , qemu-devel@nongnu.org, "Edgar E. Iglesias" , Stefano Stabellini , "Michael S. Tsirkin" , Huacai Chen , Halil Pasic , Christian Borntraeger , =?UTF-8?B?SGVydsOp?= Poussineau , Anthony Perard , xen-devel@lists.xenproject.org, Leif Lindholm , Thomas Huth , Eduardo Habkost , Mark Cave-Ayland , Alistair Francis , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, David Gibson , Radoslaw Biernacki , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 19 Feb 2021 18:38:43 +0100 Philippe Mathieu-Daud=C3=A9 wrote: I'd lose the 'Explicit' in $SUBJECT. > All s390-ccw-virtio machines support TCG and KVM. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/s390x/s390-virtio-ccw.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 2972b607f36..1f168485066 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -586,6 +586,10 @@ static ram_addr_t s390_fixup_ram_size(ram_addr_t sz) > return newsz; > } > =20 > +static const char *const valid_accels[] =3D { > + "tcg", "kvm", NULL > +}; > + > static void ccw_machine_class_init(ObjectClass *oc, void *data) > { > MachineClass *mc =3D MACHINE_CLASS(oc); > @@ -612,6 +616,7 @@ static void ccw_machine_class_init(ObjectClass *oc, v= oid *data) > mc->possible_cpu_arch_ids =3D s390_possible_cpu_arch_ids; > /* it is overridden with 'host' cpu *in kvm_arch_init* */ > mc->default_cpu_type =3D S390_CPU_TYPE_NAME("qemu"); > + mc->valid_accelerators =3D valid_accels; > hc->plug =3D s390_machine_device_plug; > hc->unplug_request =3D s390_machine_device_unplug_request; > nc->nmi_monitor_handler =3D s390_nmi; Reviewed-by: Cornelia Huck