From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:690d:0:0:0:0:0 with SMTP id e13csp1929976lfc; Mon, 22 Feb 2021 09:44:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJzZW2gEx4Z126/1qw8mDInR8vkjpe/gghDS4vOm3brHlJA2AdKHQoabKNfPBGaIJq3L+gcx X-Received: by 2002:a17:906:1951:: with SMTP id b17mr21030932eje.409.1614015880983; Mon, 22 Feb 2021 09:44:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614015880; cv=none; d=google.com; s=arc-20160816; b=O/NUHYuUR8RgimxFNqXhsgVnC3bS14zXFOkgSd2re/Udo0O2OcIkE67ZG3tj4NzRa7 o2NDpNRv53wp8qo2G4BaU8CPRrtzfQDEGAMqwxa8g1cBxr8/4MtJ4VCK2/KNHiiePnYK LjatM1TUQGmN+KZcSe5ViscIlCeSh3KdHd4rVbSH5FJtTcNbYecG1UiSJzS+D70pQbs6 wEh+OfknVPIVvQdHCdclhRMZvaiHpKkrijQDZ2LDaWVHCc7Q+mwWlWPqDv5mZIuZBfMF KZ0Ka3XMw8acGsAN8jhnr2QQqDYm9/CjUmEXWc6v2m7nCywb6hJMFt7emc03lFqJAg3P U/iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=iZK1AHq84V95gWDJ19gXOB4yY4ebnGHnrWYQW1lx22Y=; b=Yv6IUy8xouQSR/M9yYhswByuX48XFsRNm40jYQpDlB7PmT9SoopveTEMsYXtWqZS81 aSroDizamBUnU8ROjj2G/3b4WBx/R6MvvurpYdtQkiJ3TUeYdLMNF9k4OlwWMFRQtPit hUSH/yvs/MkLLgV2z1qboImHJqhAyiUz6cvgK1aMnVAuU0YNvv6XJn3T4qCRS8oElYFM BenPfuotlznVuO9iPK87tDP83LVu2oc+/mek4z6hw/rihrlWRpDcUxTtskpKyu7/UwSD pl8Z9ZBde5QccdAYuLvnepBSmdRuk5YGCk31WWpQiDWl+dB/K0XgL5OdSn3sQ1xNYn6n +WEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IsXEY80a; spf=pass (google.com: domain of kvm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e18si7419387ejb.77.2021.02.22.09.44.40; Mon, 22 Feb 2021 09:44:40 -0800 (PST) Received-SPF: pass (google.com: domain of kvm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IsXEY80a; spf=pass (google.com: domain of kvm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230338AbhBVRoj (ORCPT + 5 others); Mon, 22 Feb 2021 12:44:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:27320 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230110AbhBVRoe (ORCPT ); Mon, 22 Feb 2021 12:44:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614015787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iZK1AHq84V95gWDJ19gXOB4yY4ebnGHnrWYQW1lx22Y=; b=IsXEY80aIDhHGew0TYz61iIKps7KqoxQiLBRRMu+2Q5c8MiiVTDidhKAjXLUnVzzRTAEd0 JBh1AsAvc/gN17YPjfZt0cqPWMmvhfcidDDDy7+TC9j3vAKO9SSiVablyEyZ2YmuQqzjGi paDCFpbBlQdgt2CTs3dPgk2sJTA2hQw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-0CE6DRn-Pp6-w9VgG4m5yg-1; Mon, 22 Feb 2021 12:43:03 -0500 X-MC-Unique: 0CE6DRn-Pp6-w9VgG4m5yg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F908195D560; Mon, 22 Feb 2021 17:43:00 +0000 (UTC) Received: from gondolin (ovpn-113-115.ams2.redhat.com [10.36.113.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 931011002382; Mon, 22 Feb 2021 17:42:47 +0000 (UTC) Date: Mon, 22 Feb 2021 18:42:45 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Aurelien Jarno , Peter Maydell , Anthony Perard , qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, Halil Pasic , Huacai Chen , xen-devel@lists.xenproject.org, Marcel Apfelbaum , David Gibson , qemu-arm@nongnu.org, Stefano Stabellini , Paolo Bonzini , kvm@vger.kernel.org, BALATON Zoltan , Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alistair Francis , Paul Durrant , Eduardo Habkost , "Michael S. Tsirkin" , Thomas Huth , Jiaxun Yang , =?UTF-8?B?SGVydsOp?= Poussineau , Greg Kurz , Christian Borntraeger , "Edgar E. Iglesias" , David Hildenbrand , Mark Cave-Ayland , Aleksandar Rikalo , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Daniel =?UTF-8?B?QmVycmFuZ8Op?= Subject: Re: [PATCH v2 03/11] hw/core: Restrict 'query-machines' to those supported by current accel Message-ID: <20210222184245.1e0d0315.cohuck@redhat.com> In-Reply-To: <20210219173847.2054123-4-philmd@redhat.com> References: <20210219173847.2054123-1-philmd@redhat.com> <20210219173847.2054123-4-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-TUID: 9TwJgXSW2lRB On Fri, 19 Feb 2021 18:38:39 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > Do not let 'query-machines' return machines not valid with > the current accelerator. >=20 > Suggested-by: Daniel Berrang=C3=A9 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/core/machine-qmp-cmds.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c > index 44e979e503b..c8630bc2ddc 100644 > --- a/hw/core/machine-qmp-cmds.c > +++ b/hw/core/machine-qmp-cmds.c > @@ -204,6 +204,10 @@ MachineInfoList *qmp_query_machines(Error **errp) > MachineClass *mc =3D el->data; > MachineInfo *info; > =20 > + if (!machine_class_valid_for_current_accelerator(mc)) { > + continue; > + } > + > info =3D g_malloc0(sizeof(*info)); > if (mc->is_default) { > info->has_is_default =3D true; Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B342C433DB for ; Mon, 22 Feb 2021 17:49:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD9A964F07 for ; Mon, 22 Feb 2021 17:49:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD9A964F07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEFL9-00023a-Jy for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 12:49:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEFEk-000325-0K for qemu-devel@nongnu.org; Mon, 22 Feb 2021 12:43:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33042) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEFEi-0001D6-Fm for qemu-devel@nongnu.org; Mon, 22 Feb 2021 12:43:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614015787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iZK1AHq84V95gWDJ19gXOB4yY4ebnGHnrWYQW1lx22Y=; b=IsXEY80aIDhHGew0TYz61iIKps7KqoxQiLBRRMu+2Q5c8MiiVTDidhKAjXLUnVzzRTAEd0 JBh1AsAvc/gN17YPjfZt0cqPWMmvhfcidDDDy7+TC9j3vAKO9SSiVablyEyZ2YmuQqzjGi paDCFpbBlQdgt2CTs3dPgk2sJTA2hQw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-0CE6DRn-Pp6-w9VgG4m5yg-1; Mon, 22 Feb 2021 12:43:03 -0500 X-MC-Unique: 0CE6DRn-Pp6-w9VgG4m5yg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F908195D560; Mon, 22 Feb 2021 17:43:00 +0000 (UTC) Received: from gondolin (ovpn-113-115.ams2.redhat.com [10.36.113.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 931011002382; Mon, 22 Feb 2021 17:42:47 +0000 (UTC) Date: Mon, 22 Feb 2021 18:42:45 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v2 03/11] hw/core: Restrict 'query-machines' to those supported by current accel Message-ID: <20210222184245.1e0d0315.cohuck@redhat.com> In-Reply-To: <20210219173847.2054123-4-philmd@redhat.com> References: <20210219173847.2054123-1-philmd@redhat.com> <20210219173847.2054123-4-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Received-SPF: pass client-ip=63.128.21.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , kvm@vger.kernel.org, Paul Durrant , David Hildenbrand , qemu-devel@nongnu.org, "Edgar E. Iglesias" , Stefano Stabellini , "Michael S. Tsirkin" , Huacai Chen , Halil Pasic , Christian Borntraeger , =?UTF-8?B?SGVydsOp?= Poussineau , Anthony Perard , xen-devel@lists.xenproject.org, Leif Lindholm , Thomas Huth , Eduardo Habkost , Mark Cave-Ayland , Alistair Francis , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, David Gibson , Daniel =?UTF-8?B?QmVycmFuZ8Op?= , Radoslaw Biernacki , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 19 Feb 2021 18:38:39 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > Do not let 'query-machines' return machines not valid with > the current accelerator. >=20 > Suggested-by: Daniel Berrang=C3=A9 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/core/machine-qmp-cmds.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c > index 44e979e503b..c8630bc2ddc 100644 > --- a/hw/core/machine-qmp-cmds.c > +++ b/hw/core/machine-qmp-cmds.c > @@ -204,6 +204,10 @@ MachineInfoList *qmp_query_machines(Error **errp) > MachineClass *mc =3D el->data; > MachineInfo *info; > =20 > + if (!machine_class_valid_for_current_accelerator(mc)) { > + continue; > + } > + > info =3D g_malloc0(sizeof(*info)); > if (mc->is_default) { > info->has_is_default =3D true; Reviewed-by: Cornelia Huck