From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:690d:0:0:0:0:0 with SMTP id e13csp1935471lfc; Mon, 22 Feb 2021 09:52:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJwUlx82UXvfy8hlH+LH/oQOkqjxgIFf3FYG4oS/o+uFIo4StKvFOPcrP83tq5QQ1s63RyiT X-Received: by 2002:a02:c77b:: with SMTP id k27mr23312733jao.13.1614016357015; Mon, 22 Feb 2021 09:52:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614016357; cv=none; d=google.com; s=arc-20160816; b=PuMoveJbzSAyxEBN9uk5HlO9DJSejY0rvKotqFKeUhr1ZIR8yQeEG7scsnd1+ey+KH 7+Aci/Xuvmp1RKfEsjgLj8KybhQwwwifAYfK4CbQFXUkHqE6H5MD2qsYvsze5vzDpdLQ xEal6JxwxLbxV3yfjrWQ+zr7njRFhAbRTwASdwrlyASaXntzBlO8N8IY/POhBDq7y626 Sp249IZk/gCD9JALDEROfnIzRh6mL63HH5pLVjfT1spAPfxFBBfKqvPcIelGaxIVFiqr SpGGuYxXOCgoY7DmNwqPQAof4Q3+8P0FWqulMh1M750mrTWVDCAu4bO+5SEbcicOcDSH 5F0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature :sender:precedence:errors-to:list-subscribe:list-help:list-post :list-unsubscribe:list-id; bh=O+4avbp3iRC9wzL9kQsBbVb6oEaX3FYxbdrqhd4FEnE=; b=EGeYbfmBdoEfYELtJ1V0vLfR54C71TBIOUvvOobvANudCbaNEnuRA7eP1WtwTfMz8y vOGHWYCC9MNRJ1LZXx3gojE7es4z7WC0qDjymuGLtL5uSKEzKMbtqbsZNrn6veknf7gv 8iVHUt6YUdz/Va3QfK6nE1jR9RkkmVw5ENgCSq+FDOkhkqHx4F8690i64LeTvmKU+ffz s1CgPihYwf0b82uhxV/Ik4IEAvvuA1tkg4EZMhc+TncDTbo24qbeU8ljgrbHjGlVd3T4 76W6eBQf0WU0u1aZMt/0HF7Lqz/b4u2agiCmo2TmGQNzoWgqssjvSDEoLVXdoC4oHzVP VlqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="U3s/yYlT"; spf=pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id g3si17808187ild.84.2021.02.22.09.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 09:52:37 -0800 (PST) Received-SPF: pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="U3s/yYlT"; spf=pass (google.com: domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from list by lists.xenproject.org with outflank-mailman.88322.165994 (Exim 4.92) (envelope-from ) id 1lEFMU-0000Dn-0A; Mon, 22 Feb 2021 17:51:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 88322.165994; Mon, 22 Feb 2021 17:51:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEFMT-0000Dg-TO; Mon, 22 Feb 2021 17:51:09 +0000 Received: by outflank-mailman (input) for mailman id 88322; Mon, 22 Feb 2021 17:51:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEFMS-0000Db-As for xen-devel@lists.xenproject.org; Mon, 22 Feb 2021 17:51:08 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 694c1d3e-c040-4445-a358-f4141dc3c2f5; Mon, 22 Feb 2021 17:51:07 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-BUheIuS7NaiFmeoxrS7BDQ-1; Mon, 22 Feb 2021 12:51:05 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D0F2801965; Mon, 22 Feb 2021 17:51:01 +0000 (UTC) Received: from gondolin (ovpn-113-115.ams2.redhat.com [10.36.113.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE0141001281; Mon, 22 Feb 2021 17:50:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 694c1d3e-c040-4445-a358-f4141dc3c2f5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614016267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O+4avbp3iRC9wzL9kQsBbVb6oEaX3FYxbdrqhd4FEnE=; b=U3s/yYlTK3/NzWSID/Irp/EeEw6YuWOdsdJTXTLCJ8nsgHSo4pvlixJo4etvdVPHOUqFrL zGEEF+XtvTJJOk9ixReD7FiSM3dA1dmBW35ngo3OaynS3uXB5PTgT/rfvgd0DlhVix8ylT 1AeoFI6ke7YmaHq9oMB66DHMKqKUFB0= X-MC-Unique: BUheIuS7NaiFmeoxrS7BDQ-1 Date: Mon, 22 Feb 2021 18:50:44 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Aurelien Jarno , Peter Maydell , Anthony Perard , qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, Halil Pasic , Huacai Chen , xen-devel@lists.xenproject.org, Marcel Apfelbaum , David Gibson , qemu-arm@nongnu.org, Stefano Stabellini , Paolo Bonzini , kvm@vger.kernel.org, BALATON Zoltan , Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alistair Francis , Paul Durrant , Eduardo Habkost , "Michael S. Tsirkin" , Thomas Huth , Jiaxun Yang , =?UTF-8?B?SGVydsOp?= Poussineau , Greg Kurz , Christian Borntraeger , "Edgar E. Iglesias" , David Hildenbrand , Mark Cave-Ayland , Aleksandar Rikalo , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v2 01/11] accel/kvm: Check MachineClass kvm_type() return value Message-ID: <20210222185044.23fccecc.cohuck@redhat.com> In-Reply-To: References: <20210219173847.2054123-1-philmd@redhat.com> <20210219173847.2054123-2-philmd@redhat.com> <20210222182405.3e6e9a6f.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-TUID: YSoUYQF/29+n On Mon, 22 Feb 2021 18:41:07 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > On 2/22/21 6:24 PM, Cornelia Huck wrote: > > On Fri, 19 Feb 2021 18:38:37 +0100 > > Philippe Mathieu-Daud=C3=A9 wrote: > > =20 > >> MachineClass::kvm_type() can return -1 on failure. > >> Document it, and add a check in kvm_init(). > >> > >> Signed-off-by: Philippe Mathieu-Daud=C3=A9 > >> --- > >> include/hw/boards.h | 3 ++- > >> accel/kvm/kvm-all.c | 6 ++++++ > >> 2 files changed, 8 insertions(+), 1 deletion(-) > >> > >> diff --git a/include/hw/boards.h b/include/hw/boards.h > >> index a46dfe5d1a6..68d3d10f6b0 100644 > >> --- a/include/hw/boards.h > >> +++ b/include/hw/boards.h > >> @@ -127,7 +127,8 @@ typedef struct { > >> * implement and a stub device is required. > >> * @kvm_type: > >> * Return the type of KVM corresponding to the kvm-type string opt= ion or > >> - * computed based on other criteria such as the host kernel capabi= lities. > >> + * computed based on other criteria such as the host kernel capabi= lities > >> + * (which can't be negative), or -1 on error. > >> * @numa_mem_supported: > >> * true if '--numa node.mem' option is supported and false otherwi= se > >> * @smp_parse: > >> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > >> index 84c943fcdb2..b069938d881 100644 > >> --- a/accel/kvm/kvm-all.c > >> +++ b/accel/kvm/kvm-all.c > >> @@ -2057,6 +2057,12 @@ static int kvm_init(MachineState *ms) > >> "kvm-type= ", > >> &error_ab= ort); > >> type =3D mc->kvm_type(ms, kvm_type); > >> + if (type < 0) { > >> + ret =3D -EINVAL; > >> + fprintf(stderr, "Failed to detect kvm-type for machine '%= s'\n", > >> + mc->name); > >> + goto err; > >> + } > >> } > >> =20 > >> do { =20 > >=20 > > No objection to this patch; but I'm wondering why some non-pseries > > machines implement the kvm_type callback, when I see the kvm-type > > property only for pseries? Am I holding my git grep wrong? =20 >=20 > Can it be what David commented here? > https://www.mail-archive.com/qemu-devel@nongnu.org/msg784508.html >=20 Ok, I might be confused about the other ppc machines; but I'm wondering about the kvm_type callback for mips and arm/virt. Maybe I'm just confused by the whole mechanism? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDECC433E0 for ; Mon, 22 Feb 2021 17:54:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4527D601FF for ; Mon, 22 Feb 2021 17:54:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4527D601FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEFQ8-0006WI-9i for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 12:54:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEFMW-0003xc-Fw for qemu-devel@nongnu.org; Mon, 22 Feb 2021 12:51:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEFMU-0002KY-4d for qemu-devel@nongnu.org; Mon, 22 Feb 2021 12:51:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614016269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O+4avbp3iRC9wzL9kQsBbVb6oEaX3FYxbdrqhd4FEnE=; b=Clv4kh7GSvD2HRhUCWeK154FrGJ81/aE6f/NHvOZZzh9abzdmNU+e5P/O4f7w0Nmq9UE8J 9etBYfunuKv8UCErrdW7T5exl1/8BIEfT1eP5zzCpg4VVvqdpgqAdIhvxkji/5a8mmBXMh OB5G1QCz/qNuGPb4Y1BHClKZ5JwS660= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-BUheIuS7NaiFmeoxrS7BDQ-1; Mon, 22 Feb 2021 12:51:05 -0500 X-MC-Unique: BUheIuS7NaiFmeoxrS7BDQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D0F2801965; Mon, 22 Feb 2021 17:51:01 +0000 (UTC) Received: from gondolin (ovpn-113-115.ams2.redhat.com [10.36.113.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE0141001281; Mon, 22 Feb 2021 17:50:46 +0000 (UTC) Date: Mon, 22 Feb 2021 18:50:44 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v2 01/11] accel/kvm: Check MachineClass kvm_type() return value Message-ID: <20210222185044.23fccecc.cohuck@redhat.com> In-Reply-To: References: <20210219173847.2054123-1-philmd@redhat.com> <20210219173847.2054123-2-philmd@redhat.com> <20210222182405.3e6e9a6f.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , kvm@vger.kernel.org, Paul Durrant , David Hildenbrand , qemu-devel@nongnu.org, "Edgar E. Iglesias" , Stefano Stabellini , "Michael S. Tsirkin" , Huacai Chen , Halil Pasic , Christian Borntraeger , =?UTF-8?B?SGVydsOp?= Poussineau , Anthony Perard , xen-devel@lists.xenproject.org, Leif Lindholm , Thomas Huth , Eduardo Habkost , Mark Cave-Ayland , Alistair Francis , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, David Gibson , Radoslaw Biernacki , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 22 Feb 2021 18:41:07 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > On 2/22/21 6:24 PM, Cornelia Huck wrote: > > On Fri, 19 Feb 2021 18:38:37 +0100 > > Philippe Mathieu-Daud=C3=A9 wrote: > > =20 > >> MachineClass::kvm_type() can return -1 on failure. > >> Document it, and add a check in kvm_init(). > >> > >> Signed-off-by: Philippe Mathieu-Daud=C3=A9 > >> --- > >> include/hw/boards.h | 3 ++- > >> accel/kvm/kvm-all.c | 6 ++++++ > >> 2 files changed, 8 insertions(+), 1 deletion(-) > >> > >> diff --git a/include/hw/boards.h b/include/hw/boards.h > >> index a46dfe5d1a6..68d3d10f6b0 100644 > >> --- a/include/hw/boards.h > >> +++ b/include/hw/boards.h > >> @@ -127,7 +127,8 @@ typedef struct { > >> * implement and a stub device is required. > >> * @kvm_type: > >> * Return the type of KVM corresponding to the kvm-type string opt= ion or > >> - * computed based on other criteria such as the host kernel capabi= lities. > >> + * computed based on other criteria such as the host kernel capabi= lities > >> + * (which can't be negative), or -1 on error. > >> * @numa_mem_supported: > >> * true if '--numa node.mem' option is supported and false otherwi= se > >> * @smp_parse: > >> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > >> index 84c943fcdb2..b069938d881 100644 > >> --- a/accel/kvm/kvm-all.c > >> +++ b/accel/kvm/kvm-all.c > >> @@ -2057,6 +2057,12 @@ static int kvm_init(MachineState *ms) > >> "kvm-type= ", > >> &error_ab= ort); > >> type =3D mc->kvm_type(ms, kvm_type); > >> + if (type < 0) { > >> + ret =3D -EINVAL; > >> + fprintf(stderr, "Failed to detect kvm-type for machine '%= s'\n", > >> + mc->name); > >> + goto err; > >> + } > >> } > >> =20 > >> do { =20 > >=20 > > No objection to this patch; but I'm wondering why some non-pseries > > machines implement the kvm_type callback, when I see the kvm-type > > property only for pseries? Am I holding my git grep wrong? =20 >=20 > Can it be what David commented here? > https://www.mail-archive.com/qemu-devel@nongnu.org/msg784508.html >=20 Ok, I might be confused about the other ppc machines; but I'm wondering about the kvm_type callback for mips and arm/virt. Maybe I'm just confused by the whole mechanism?