From: Aili Yao <yaoaili@kingsoft.com>
To: Borislav Petkov <bp@alien8.de>
Cc: <tony.luck@intel.com>, <mingo@redhat.com>, <tglx@linutronix.de>,
<hpa@zytor.com>, <x86@kernel.org>, <linux-edac@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <yangfeng1@kingsoft.com>
Subject: Re: [PATCH v2] x86/mce: fix wrong no-return-ip logic in do_machine_check()
Date: Mon, 22 Feb 2021 19:21:46 +0800 [thread overview]
Message-ID: <20210222192146.76ffec84@alex-virtual-machine> (raw)
In-Reply-To: <20210222102206.GC29063@zn.tnic>
On Mon, 22 Feb 2021 11:22:06 +0100
Borislav Petkov <bp@alien8.de> wrote:
> On Mon, Feb 22, 2021 at 06:08:19PM +0800, Aili Yao wrote:
> > So why would intel provide this MCG_STATUS_RIPV flag, it's better to
> > remove it as it will never be set, and all the related logic for this
> > flag is really needed ?
>
> Why would it never be set - of course it will be. You don't set it. If
> you wanna inject errors, then make sure you inject *valid* errors which
> the hardware *actually* generates, not some random ones.
>
As far as I know, Most of RAS related tests are faked, not real errors, and it's really meaningful.
You should better reproduce the issue I tried to fix, or at least read the code more detailly and you will
know if it's random and invalid
Best Regards!
Aili Yao
next prev parent reply other threads:[~2021-02-22 11:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 3:31 x86/mce: fix wrong no-return-ip logic in do_machine_check() Aili Yao
2021-02-22 3:50 ` [PATCH v2] " Aili Yao
2021-02-22 9:24 ` Borislav Petkov
2021-02-22 9:31 ` Aili Yao
2021-02-22 10:03 ` Borislav Petkov
2021-02-22 10:08 ` Aili Yao
2021-02-22 10:22 ` Borislav Petkov
2021-02-22 11:21 ` Aili Yao [this message]
2021-02-22 12:17 ` Aili Yao
2021-02-22 12:22 ` Borislav Petkov
2021-02-22 12:35 ` Aili Yao
2021-02-22 12:45 ` Borislav Petkov
2021-02-23 2:27 ` Aili Yao
2021-02-23 9:43 ` Borislav Petkov
2021-02-23 9:56 ` Aili Yao
2021-02-23 10:05 ` Borislav Petkov
2021-02-23 11:27 ` Aili Yao
2021-02-23 16:12 ` Luck, Tony
2021-02-24 2:39 ` Aili Yao
2021-03-24 2:59 ` Aili Yao
2021-03-24 2:59 ` Aili Yao
2021-03-24 8:03 ` Aili Yao
2021-03-24 8:03 ` Aili Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222192146.76ffec84@alex-virtual-machine \
--to=yaoaili@kingsoft.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yangfeng1@kingsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.