From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20469C433E0 for ; Tue, 23 Feb 2021 09:05:31 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C786264E02 for ; Tue, 23 Feb 2021 09:05:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C786264E02 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 466121661; Tue, 23 Feb 2021 10:04:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 466121661 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614071128; bh=b0dOE9tWsUgUZqfzic1sbmsquBy90+SWhSVjP1vt+C0=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=m3u9ZpkUyTTRDfa4dUCNtPKFVQBDfy0SlA8f5CaazaGN5y7rZQFIGFB8rjcy28n+z M7yYSWZo3hRtY3ELey2YSwzY1f1pATx568hysscquwjpm3ddlKE0tQK+W+X2heyJaa F5VikpXzf4xWaedDpObU3A8cnEs4RS1G1fHNeYUI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D69E4F801F5; Tue, 23 Feb 2021 10:04:02 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7C8CDF8026C; Tue, 23 Feb 2021 10:04:01 +0100 (CET) Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 47D1CF8016A for ; Tue, 23 Feb 2021 10:03:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 47D1CF8016A Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 166441C0B85; Tue, 23 Feb 2021 10:03:58 +0100 (CET) Date: Tue, 23 Feb 2021 10:03:56 +0100 From: Pavel Machek To: Hans de Goede Subject: Re: [PATCH v3 5/7] HID: lenovo: Set LEDs max_brightness value Message-ID: <20210223090356.GE9750@amd> References: <20210221112005.102116-1-hdegoede@redhat.com> <20210221112005.102116-6-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fWddYNRDgTk9wQGZ" Content-Disposition: inline In-Reply-To: <20210221112005.102116-6-hdegoede@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Marek =?iso-8859-1?Q?Beh=FAn?= , alsa-devel@alsa-project.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-leds@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --fWddYNRDgTk9wQGZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun 2021-02-21 12:20:03, Hans de Goede wrote: > The LEDs can only by turned on/off, so max_brightness should be set to 1. > Without this the max_brightness sysfs-attribute will report 255 which is > wrong. >=20 > Signed-off-by: Hans de Goede Acked-by: Pavel Machek --=20 http://www.livejournal.com/~pavelmachek --fWddYNRDgTk9wQGZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmA0xPwACgkQMOfwapXb+vIxAACfcF/s3KwvdZ56OjVFvgOKfyaq z9kAnA2/Ex7AO7WwInsgtlZEjZlGyxU4 =NTxy -----END PGP SIGNATURE----- --fWddYNRDgTk9wQGZ-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46EECC433DB for ; Tue, 23 Feb 2021 09:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0655964E57 for ; Tue, 23 Feb 2021 09:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231403AbhBWJGT (ORCPT ); Tue, 23 Feb 2021 04:06:19 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:52012 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231414AbhBWJEo (ORCPT ); Tue, 23 Feb 2021 04:04:44 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 166441C0B85; Tue, 23 Feb 2021 10:03:58 +0100 (CET) Date: Tue, 23 Feb 2021 10:03:56 +0100 From: Pavel Machek To: Hans de Goede Cc: Jiri Kosina , Benjamin Tissoires , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-input@vger.kernel.org, linux-leds@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v3 5/7] HID: lenovo: Set LEDs max_brightness value Message-ID: <20210223090356.GE9750@amd> References: <20210221112005.102116-1-hdegoede@redhat.com> <20210221112005.102116-6-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fWddYNRDgTk9wQGZ" Content-Disposition: inline In-Reply-To: <20210221112005.102116-6-hdegoede@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org --fWddYNRDgTk9wQGZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun 2021-02-21 12:20:03, Hans de Goede wrote: > The LEDs can only by turned on/off, so max_brightness should be set to 1. > Without this the max_brightness sysfs-attribute will report 255 which is > wrong. >=20 > Signed-off-by: Hans de Goede Acked-by: Pavel Machek --=20 http://www.livejournal.com/~pavelmachek --fWddYNRDgTk9wQGZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmA0xPwACgkQMOfwapXb+vIxAACfcF/s3KwvdZ56OjVFvgOKfyaq z9kAnA2/Ex7AO7WwInsgtlZEjZlGyxU4 =NTxy -----END PGP SIGNATURE----- --fWddYNRDgTk9wQGZ--