From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 0/2] nvme: fix regression with MD RAID
Date: Tue, 23 Feb 2021 12:59:20 +0100 [thread overview]
Message-ID: <20210223115922.104369-1-hare@suse.de> (raw)
Hi all,
ever since the implementation NVMe-oF does not work together with MD RAID.
MD RAID expects the device to return an I/O error on failure, and to remove
the block device if the underlying hardware is removed.
This is contrary to the implementation of NVMe-oF, which will keep on retrying
I/O while the controller is being reset, and will only remove the block device
once the last _user_ is gone.
These patches fixup this situation by adding a new sysfs attribute
'fail_if_no_path'. When this attribute is set we will return I/O errors
as soon as no paths are available anymore, and will remove the block device
once the last controller holding a path to the namespace is removed (ie after
all reconnect attempts for that controllers are exhausted).
This is a rework of the earlier path by Keith Busch ('nvme-mpath: delete disk
after last connection'). Kudos to him for suggesting this approach.
Hannes Reinecke (2):
nvme: add 'fail_if_no_path' sysfs attribute
nvme: delete disk when last path is gone
drivers/nvme/host/core.c | 6 +++++
drivers/nvme/host/multipath.c | 46 ++++++++++++++++++++++++++++++++---
drivers/nvme/host/nvme.h | 19 +++++++++++++--
3 files changed, 66 insertions(+), 5 deletions(-)
--
2.29.2
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2021-02-23 11:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 11:59 Hannes Reinecke [this message]
2021-02-23 11:59 ` [PATCH 1/2] nvme: add 'fail_if_no_path' sysfs attribute Hannes Reinecke
2021-02-23 12:41 ` Minwoo Im
2021-02-24 22:47 ` Sagi Grimberg
2021-02-25 8:10 ` Hannes Reinecke
2021-02-23 11:59 ` [PATCH 2/2] nvme: delete disk when last path is gone Hannes Reinecke
2021-02-23 12:56 ` Minwoo Im
2021-02-23 14:07 ` Hannes Reinecke
2021-02-24 22:40 ` Sagi Grimberg
2021-02-25 8:37 ` Hannes Reinecke
2021-02-24 16:25 ` [PATCH 0/2] nvme: fix regression with MD RAID Christoph Hellwig
2021-02-24 17:10 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223115922.104369-1-hare@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.