From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4032C433DB for ; Tue, 23 Feb 2021 13:47:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78FE364DBD for ; Tue, 23 Feb 2021 13:47:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78FE364DBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 68E0E1668; Tue, 23 Feb 2021 14:46:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 68E0E1668 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614088025; bh=iUWoW7ZqYFe8F7SwoDPBFKP/j1giKV2m0mOThiAczoA=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JifDYL1pQ+BeS0kOgNlc+v+zr0OBtXaTw2s10c/vWbFwEVoY1bY/UNzByKbsaifG2 G95IEsXgAHov9ee2Jxbr9nmzA4fIX/lPUXvK2uQR/iTNQr/ttq5v5bm9t3kawgh5So /fBmUHiiax+KOdB0SgbEcwRNGKtNXlZ5hlqZNgcY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9F0CFF800B4; Tue, 23 Feb 2021 14:46:14 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BDA24F8016A; Tue, 23 Feb 2021 14:46:13 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 568CBF800B4 for ; Tue, 23 Feb 2021 14:46:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 568CBF800B4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oi1n9wXf" Received: by mail.kernel.org (Postfix) with ESMTPSA id 2FE9364D9A; Tue, 23 Feb 2021 13:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614087968; bh=iUWoW7ZqYFe8F7SwoDPBFKP/j1giKV2m0mOThiAczoA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oi1n9wXfUSBXyQUdXaOarx9J1Adksfh/bBDuunJx3eSfsyWG7PhYIQL1qYBl65HWU RGYXrDsl66HymzPfLoRKesHamHQ5bLJKC6Xy/5sZpql48EnFgwky8tYgVkzU4WB7jj S1AShLolSEE23eOzBMZ5PfleSPmZMOosKN7bMfBFuuvU4si/NLVfWlxAt29S0ScSzD KglMO+XzcwzoFp4IzekEGxcInooNPB0EzZIju+aP2UhdSVIm7oRvWk+BAbP28vgvBN Zne+zkxupMcYIe00zi3ygZ7AtJaD/YGs2f0eLPp1UuebZF2A1eWtykXir3iWaUZi/v saKtjSzXLHaEQ== Date: Tue, 23 Feb 2021 13:45:06 +0000 From: Mark Brown To: Hans de Goede Subject: Re: [RFC 2/2] ASoC: rt5670: Add LED trigger support Message-ID: <20210223134506.GF5116@sirena.org.uk> References: <20210215142419.308651-1-hdegoede@redhat.com> <20210215142419.308651-3-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hwvH6HDNit2nSK4j" Content-Disposition: inline In-Reply-To: <20210215142419.308651-3-hdegoede@redhat.com> X-Cookie: Kilroe hic erat! User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Oder Chiou , alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --hwvH6HDNit2nSK4j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 15, 2021 at 03:24:19PM +0100, Hans de Goede wrote: > Add support for controlling a speaker and/or microphone mute LED through > LED triggers using the new generic LED trigger module. > - SOC_DOUBLE_EXT("DAC1 Playback Switch", SND_SOC_NOPM, 0, 1, 1, 0, > + SOC_DOUBLE_EXT_ACCESS("DAC1 Playback Switch", SND_SOC_NOPM, 0, 1, 1, 0, > + SNDRV_CTL_ELEM_ACCESS_SPK_LED, > rt5670_dac1_playback_switch_get, rt5670_dac1_playback_switch_put), > - SOC_DOUBLE("ADC Capture Switch", RT5670_STO1_ADC_DIG_VOL, > - RT5670_L_MUTE_SFT, RT5670_R_MUTE_SFT, 1, 1), > + SOC_DOUBLE_ACCESS("ADC Capture Switch", RT5670_STO1_ADC_DIG_VOL, > + RT5670_L_MUTE_SFT, RT5670_R_MUTE_SFT, 1, 1, > + SNDRV_CTL_ELEM_ACCESS_MIC_LED), Why just these particular controls - what if a system has separate mutes for speakers or something? --hwvH6HDNit2nSK4j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmA1BuEACgkQJNaLcl1U h9AZ1Af+K5c94P6GgqTME3GcrB8BgmawUxVSXz9vzz2K902WKLquVFLh2x436cvc pOdgw63EhM3TRkWH82enavVjpfleZk5ojdj5i43Fj+U87joHYwNeA1exCxEcT7Cj wcdLjL3GZ5iDuOBiVFSZgZp8ZIrs3r3XPY5owFic81Kj/YnLZncSqHAa5vTdV56E 0/c4nJ1OT5gqKOmWza6jqU+SCWR71O2i8p8nHSp8mLcyfjfT6ceA3i6wGSH5/H3k 0QUNiHKK11SDanOvtfVrMF65KbQVE2osiqT+jU5Bj22qJFMFsFLKxAbZNSDHurkf LKu9ePGh+4TvoUNXk0AxTHdclllQPA== =9RnW -----END PGP SIGNATURE----- --hwvH6HDNit2nSK4j--