From: Tyler Hicks <tyhicks@linux.microsoft.com>
To: Paul Moore <paul@paul-moore.com>,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Ondrej Mosnacek <omosnace@redhat.com>
Cc: selinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] Race between policy reload sidtab conversion and live conversion
Date: Tue, 23 Feb 2021 16:36:52 -0600 [thread overview]
Message-ID: <20210223223652.GD6000@sequoia> (raw)
In-Reply-To: <20210223215054.GC6000@sequoia>
On 2021-02-23 15:50:56, Tyler Hicks wrote:
> On 2021-02-23 15:43:48, Tyler Hicks wrote:
> > I'm seeing a race during policy load while the "regular" sidtab
> > conversion is happening and a live conversion starts to take place in
> > sidtab_context_to_sid().
> >
> > We have an initial policy that's loaded by systemd ~0.6s into boot and
> > then another policy gets loaded ~2-3s into boot. That second policy load
> > is what hits the race condition situation because the sidtab is only
> > partially populated and there's a decent amount of filesystem operations
> > happening, at the same time, which are triggering live conversions.
Hmm, perhaps this is the same problem that's fixed by Ondrej's proposed
change here:
https://lore.kernel.org/selinux/20210212185930.130477-3-omosnace@redhat.com/
I'll put these changes through a validation run (the only place that I
can seem to reproduce this crash) and see how it looks.
Tyler
next prev parent reply other threads:[~2021-02-23 22:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 21:43 [BUG] Race between policy reload sidtab conversion and live conversion Tyler Hicks
2021-02-23 21:50 ` Tyler Hicks
2021-02-23 22:36 ` Tyler Hicks [this message]
2021-02-24 0:02 ` Paul Moore
2021-02-24 9:33 ` Ondrej Mosnacek
2021-02-24 14:36 ` Tyler Hicks
2021-02-25 16:38 ` Ondrej Mosnacek
2021-02-25 16:45 ` Tyler Hicks
2021-02-25 23:27 ` Paul Moore
2021-02-26 1:06 ` Paul Moore
2021-02-26 11:11 ` Ondrej Mosnacek
2021-02-28 19:21 ` Paul Moore
2021-03-01 10:35 ` Ondrej Mosnacek
2021-03-01 14:46 ` Paul Moore
[not found] ` <20210226040542.1137-1-hdanton@sina.com>
2021-02-26 11:19 ` Ondrej Mosnacek
[not found] ` <20210227023524.15844-1-hdanton@sina.com>
2021-03-01 14:35 ` Ondrej Mosnacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223223652.GD6000@sequoia \
--to=tyhicks@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.