From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC5CC433E0 for ; Wed, 24 Feb 2021 07:27:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 197C764ED3 for ; Wed, 24 Feb 2021 07:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232471AbhBXH1H (ORCPT ); Wed, 24 Feb 2021 02:27:07 -0500 Received: from verein.lst.de ([213.95.11.211]:36446 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232823AbhBXH0q (ORCPT ); Wed, 24 Feb 2021 02:26:46 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 6539B68D0A; Wed, 24 Feb 2021 08:26:03 +0100 (CET) Date: Wed, 24 Feb 2021 08:26:03 +0100 From: Christoph Hellwig To: Minwoo Im Cc: Christoph Hellwig , axboe@kernel.dk, linux-block@vger.kernel.org, Tom Seewald Subject: Re: [PATCH] block: reopen the device in blkdev_reread_part Message-ID: <20210224072603.GA32368@lst.de> References: <20210223151822.399791-1-hch@lst.de> <20210224015202.GA2166@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210224015202.GA2166@localhost.localdomain> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Feb 24, 2021 at 10:52:02AM +0900, Minwoo Im wrote: > On 21-02-23 16:18:22, Christoph Hellwig wrote: > > Historically the BLKRRPART ioctls called into the now defunct ->revalidate > > method, which caused the sd driver to check if any media is present. > > When the ->revalidate method was removed this revalidation was lost, > > leading to lots of I/O errors when using the eject command. Fix this by > > reopening the device to rescan the partitions, and thus calling the > > revalidation logic in the sd driver. > > It looks like a related issue that I've reported in [1]. And this looks > much better! I don't think it fixes the block size issue, does it?