From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Christoph Hellwig" <hch@lst.de>, "Jessica Yu" <jeyu@kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Miroslav Benes" <mbenes@suse.cz>,
"Emil Velikov" <emil.l.velikov@gmail.com>
Subject: Re: [GIT PULL] Modules updates for v5.12
Date: Wed, 24 Feb 2021 08:52:20 +0100 [thread overview]
Message-ID: <20210224075220.GA546@lst.de> (raw)
In-Reply-To: <CAHk-=whudLzx0zmn+xLDmC1su6DF4oMQT6uEgjDEq0RsHRsDwA@mail.gmail.com>
On Tue, Feb 23, 2021 at 12:07:39PM -0800, Linus Torvalds wrote:
> On Tue, Feb 23, 2021 at 12:03 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > This is unacceptably slow. If that symbol trimming takes 30% of the
> > whole kernel build time, it needs to be fixed or removed.
>
> I think I'm going to mark TRIM_UNUSED_KSYMS as "depends on BROKEN".
> There's no way I can accept that horrible overhead, and the rationale
> for that config option is questionable at best,
I think it is pretty useful for embedded setups.
BROKEN seems pretty strong for something that absolutely works as
intendended. I guess to make you (and possibly others) not grumpy
we just need to ensure it doesn't get pulled in by allmodconfig.
So maybe just invert the symbol, default the KEEP_UNUSED_SYMBOL, and
add a message to the helptext explaining the slowdown?
next prev parent reply other threads:[~2021-02-24 7:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 15:42 [GIT PULL] Modules updates for v5.12 Jessica Yu
2021-02-23 18:26 ` Linus Torvalds
2021-02-23 18:42 ` Linus Torvalds
2021-02-23 19:55 ` Linus Torvalds
2021-02-23 20:01 ` Christoph Hellwig
2021-02-23 20:03 ` Linus Torvalds
2021-02-23 20:07 ` Linus Torvalds
2021-02-24 7:52 ` Christoph Hellwig [this message]
2021-02-24 14:13 ` Jessica Yu
2021-02-24 14:46 ` Masahiro Yamada
2021-02-24 15:30 ` Masahiro Yamada
2021-02-24 16:56 ` Linus Torvalds
2021-02-24 8:33 ` Jessica Yu
2021-02-24 14:40 ` Masahiro Yamada
2021-02-24 19:36 ` Rasmus Villemoes
2021-02-25 15:49 ` Masahiro Yamada
2021-02-25 16:17 ` Masahiro Yamada
2021-02-25 16:19 ` Rasmus Villemoes
2021-02-25 18:37 ` Masahiro Yamada
2021-02-23 20:01 ` Linus Torvalds
2021-02-23 20:32 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224075220.GA546@lst.de \
--to=hch@lst.de \
--cc=emil.l.velikov@gmail.com \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.