Re: [RFC PATCH v2 net-next 16/17] net: bridge: switchdev: let drivers inform which bridge ports are offloaded

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3581 bytes --]

Hi Vladimir,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Vladimir-Oltean/RX-filtering-in-DSA/20210224-195147
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d310ec03a34e92a77302edb804f7d68ee4f01ba0
config: openrisc-randconfig-p002-20210223 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/292ea1a7fc1b03aebab5571439861ac396d15687
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vladimir-Oltean/RX-filtering-in-DSA/20210224-195147
        git checkout 292ea1a7fc1b03aebab5571439861ac396d15687
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   net/bridge/br.c: In function 'br_switchdev_event':
>> net/bridge/br.c:197:4: error: 'struct net_bridge_port' has no member named 'ppid'
     197 |   p->ppid = brport_info->ppid;
         |    ^~
>> net/bridge/br.c:198:4: error: 'struct net_bridge_port' has no member named 'offloaded'
     198 |   p->offloaded = true;
         |    ^~


vim +197 net/bridge/br.c

   148	
   149	/* called with RTNL or RCU */
   150	static int br_switchdev_event(struct notifier_block *unused,
   151				      unsigned long event, void *ptr)
   152	{
   153		struct net_device *dev = switchdev_notifier_info_to_dev(ptr);
   154		struct switchdev_notifier_brport_info *brport_info;
   155		struct switchdev_notifier_fdb_info *fdb_info;
   156		struct net_bridge_port *p;
   157		struct net_bridge *br;
   158		int err = NOTIFY_DONE;
   159	
   160		p = br_port_get_rtnl_rcu(dev);
   161		if (!p)
   162			goto out;
   163	
   164		br = p->br;
   165	
   166		switch (event) {
   167		case SWITCHDEV_FDB_ADD_TO_BRIDGE:
   168			fdb_info = ptr;
   169			err = br_fdb_external_learn_add(br, p, fdb_info->addr,
   170							fdb_info->vid, false);
   171			if (err) {
   172				err = notifier_from_errno(err);
   173				break;
   174			}
   175			br_fdb_offloaded_set(br, p, fdb_info->addr,
   176					     fdb_info->vid, true);
   177			break;
   178		case SWITCHDEV_FDB_DEL_TO_BRIDGE:
   179			fdb_info = ptr;
   180			err = br_fdb_external_learn_del(br, p, fdb_info->addr,
   181							fdb_info->vid, false);
   182			if (err)
   183				err = notifier_from_errno(err);
   184			break;
   185		case SWITCHDEV_FDB_OFFLOADED:
   186			fdb_info = ptr;
   187			br_fdb_offloaded_set(br, p, fdb_info->addr,
   188					     fdb_info->vid, fdb_info->offloaded);
   189			break;
   190		case SWITCHDEV_FDB_FLUSH_TO_BRIDGE:
   191			fdb_info = ptr;
   192			/* Don't delete static entries */
   193			br_fdb_delete_by_port(br, p, fdb_info->vid, 0);
   194			break;
   195		case SWITCHDEV_BRPORT_OFFLOADED:
   196			brport_info = ptr;
 > 197			p->ppid = brport_info->ppid;
 > 198			p->offloaded = true;
   199			break;
   200		}
   201	
   202	out:
   203		return err;
   204	}
   205	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 22478 bytes --]