From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Michael Walle <michael@walle.cc>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandru Marginean <alexandru.marginean@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode
Date: Thu, 25 Feb 2021 11:29:42 +0000 [thread overview]
Message-ID: <20210225112942.GT1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210225112357.3785911-7-olteanv@gmail.com>
On Thu, Feb 25, 2021 at 01:23:57PM +0200, Vladimir Oltean wrote:
> static void enetc_pl_mac_link_up(struct phylink_config *config,
> struct phy_device *phy, unsigned int mode,
> phy_interface_t interface, int speed,
> @@ -945,6 +981,10 @@ static void enetc_pl_mac_link_up(struct phylink_config *config,
> enetc_sched_speed_set(priv, speed);
>
> enetc_mac_enable(&pf->si->hw, true);
> +
> + if (!phylink_autoneg_inband(mode) &&
> + phy_interface_mode_is_rgmii(interface))
> + enetc_force_rgmii_mac(&pf->si->hw, speed, duplex);
Does it matter that you're forcing the RGMII setup after having enabled
the MAC?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-02-25 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 11:23 [PATCH net 0/6] Fixes for NXP ENETC driver Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 1/6] net: enetc: don't overwrite the RSS indirection table when initializing Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 2/6] net: enetc: initialize RFS/RSS memories for unused ports too Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 3/6] net: enetc: take the MDIO lock only once per NAPI poll cycle Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 4/6] net: enetc: fix incorrect TPID when receiving 802.1ad tagged packets Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode Vladimir Oltean
2021-02-25 11:29 ` Russell King - ARM Linux admin [this message]
2021-02-25 12:13 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225112942.GT1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandru.marginean@nxp.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.