From: Mike Rapoport <rppt@linux.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "David Hildenbrand" <david@redhat.com>,
"Mike Rapoport" <rppt@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Baoquan He" <bhe@redhat.com>, "Borislav Petkov" <bp@alien8.de>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"H. Peter Anvin" <hpa@zytor.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Łukasz Majczak" <lma@semihalf.com>,
"Mel Gorman" <mgorman@suse.de>,
"Michal Hocko" <mhocko@kernel.org>, "Qian Cai" <cai@lca.pw>,
"Sarvela, Tomi P" <tomi.p.sarvela@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>, stable <stable@vger.kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>
Subject: Re: [PATCH v7 1/1] mm/page_alloc.c: refactor initialization of struct page for holes in memory layout
Date: Thu, 25 Feb 2021 20:09:35 +0200 [thread overview]
Message-ID: <20210225180935.GI1854360@linux.ibm.com> (raw)
In-Reply-To: <CAHk-=wj-0TeNTNhn+r8c9n76uy8ZiYw03AnXz3hyDZ_rQu35Uw@mail.gmail.com>
On Thu, Feb 25, 2021 at 09:54:34AM -0800, Linus Torvalds wrote:
> On Thu, Feb 25, 2021 at 9:07 AM Mike Rapoport <rppt@linux.ibm.com> wrote:
> >
> > >
> > > We might still double-initialize PFNs when two zones overlap within a
> > > section, correct?
> >
> > You mean that a section crosses zones boundary?
> > I don't think it's that important.
>
> What if there was a memory allocation in between that could allocate
> the once-initialized page?
Can't happen because this code runs before any allocation is possible and
it is single threaded.
> Maybe it can't happen, or is not an issue for some other reason, but
> this code has been fragile and had a ton of subtle issues, so maybe
> worth documenting (or explaining here why it's just not relevant)
Ok, I'll do another pass on the comments in the code.
> Linus
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-02-25 18:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 15:39 [PATCH v7 0/1] mm: fix initialization of struct page for holes in memory layout Mike Rapoport
2021-02-24 15:39 ` [PATCH v7 1/1] mm/page_alloc.c: refactor " Mike Rapoport
2021-02-25 15:59 ` David Hildenbrand
2021-02-25 17:06 ` Mike Rapoport
2021-02-25 17:54 ` David Hildenbrand
2021-02-25 17:54 ` Linus Torvalds
2021-02-25 18:09 ` Mike Rapoport [this message]
2021-02-25 17:51 ` Vlastimil Babka
2021-02-25 18:05 ` Mike Rapoport
2021-02-25 18:38 ` Vlastimil Babka
2021-02-26 10:59 ` Mike Rapoport
2021-02-26 11:08 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225180935.GI1854360@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=cai@lca.pw \
--cc=chris@chris-wilson.co.uk \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lma@semihalf.com \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tomi.p.sarvela@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.