Re: [PATCH v2 net-next] virtio-net: support XDP_TX when not more queues

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3571 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <1614241349-77324-1-git-send-email-xuanzhuo@linux.alibaba.com>
References: <1614241349-77324-1-git-send-email-xuanzhuo@linux.alibaba.com>
TO: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
TO: netdev(a)vger.kernel.org
CC: "Michael S. Tsirkin" <mst@redhat.com>
CC: Jason Wang <jasowang@redhat.com>
CC: Jakub Kicinski <kuba@kernel.org>
CC: Alexei Starovoitov <ast@kernel.org>
CC: Daniel Borkmann <daniel@iogearbox.net>
CC: Jesper Dangaard Brouer <hawk@kernel.org>
CC: John Fastabend <john.fastabend@gmail.com>
CC: virtualization(a)lists.linux-foundation.org
CC: bpf(a)vger.kernel.org

Hi Xuan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-net-support-XDP_TX-when-not-more-queues/20210225-162459
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d310ec03a34e92a77302edb804f7d68ee4f01ba0
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
config: i386-randconfig-s001-20210225 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-229-g60c1f270-dirty
        # https://github.com/0day-ci/linux/commit/a9dbec18799a2aedf34da67f39f02fb2d72e7192
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xuan-Zhuo/virtio-net-support-XDP_TX-when-not-more-queues/20210225-162459
        git checkout a9dbec18799a2aedf34da67f39f02fb2d72e7192
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> drivers/net/virtio_net.c:500:9: sparse: sparse: context imbalance in 'virtnet_get_xdp_sq' - different lock contexts for basic block
   drivers/net/virtio_net.c:509:17: sparse: sparse: context imbalance in 'virtnet_put_xdp_sq' - unexpected unlock

vim +/virtnet_get_xdp_sq +500 drivers/net/virtio_net.c

56434a01b12e99 John Fastabend  2016-12-15  486  
a9dbec18799a2a Xuan Zhuo       2021-02-25  487  static struct send_queue *virtnet_get_xdp_sq(struct virtnet_info *vi)
2a43565c064653 Toshiaki Makita 2018-07-23  488  {
a9dbec18799a2a Xuan Zhuo       2021-02-25  489  	struct netdev_queue *txq;
2a43565c064653 Toshiaki Makita 2018-07-23  490  	unsigned int qp;
2a43565c064653 Toshiaki Makita 2018-07-23  491  
a9dbec18799a2a Xuan Zhuo       2021-02-25  492  	if (vi->curr_queue_pairs > nr_cpu_ids) {
2a43565c064653 Toshiaki Makita 2018-07-23  493  		qp = vi->curr_queue_pairs - vi->xdp_queue_pairs + smp_processor_id();
a9dbec18799a2a Xuan Zhuo       2021-02-25  494  	} else {
a9dbec18799a2a Xuan Zhuo       2021-02-25  495  		qp = smp_processor_id() % vi->curr_queue_pairs;
a9dbec18799a2a Xuan Zhuo       2021-02-25  496  		txq = netdev_get_tx_queue(vi->dev, qp);
a9dbec18799a2a Xuan Zhuo       2021-02-25  497  		__netif_tx_lock(txq, raw_smp_processor_id());
a9dbec18799a2a Xuan Zhuo       2021-02-25  498  	}
a9dbec18799a2a Xuan Zhuo       2021-02-25  499  
2a43565c064653 Toshiaki Makita 2018-07-23 @500  	return &vi->sq[qp];
2a43565c064653 Toshiaki Makita 2018-07-23  501  }
2a43565c064653 Toshiaki Makita 2018-07-23  502  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35604 bytes --]