All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuo A Liu <shuo.a.liu@intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Zhi Wang <zhi.a.wang@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virt: acrn: add hotplug_cpu dependency
Date: Fri, 26 Feb 2021 09:38:07 +0800	[thread overview]
Message-ID: <20210226013807.GA9695@shuo-intel.sh.intel.com> (raw)
In-Reply-To: <20210225133838.2196965-1-arnd@kernel.org>

Hi Arnd,

There is already a patchset for this build issue. Please refer to
https://lore.kernel.org/lkml/20210221134339.57851-1-shuo.a.liu@intel.com/.

Hi Greg, 
Would you like accept that patchset in you tree?

Thanks
shuo

On Thu 25.Feb'21 at 14:38:30 +0100, Arnd Bergmann wrote:
>From: Arnd Bergmann <arnd@arndb.de>
>
>Without CPU hotplug, acrn fails to build:
>
>drivers/virt/acrn/hsm.c:389:3: error: implicit declaration of function 'remove_cpu' [-Werror,-Wimplicit-function-declaration]
>                remove_cpu(cpu);
>                ^
>drivers/virt/acrn/hsm.c:402:2: error: implicit declaration of function 'add_cpu' [-Werror,-Wimplicit-function-declaration]
>        add_cpu(cpu);
>        ^
>
>Enforce the dependency through Kconfig to avoid the build failure.
>
>Fixes: 666834c47d3b ("virt: acrn: Introduce ACRN HSM basic driver")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
> drivers/virt/acrn/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/virt/acrn/Kconfig b/drivers/virt/acrn/Kconfig
>index 3e1a61c9d8d8..fbb0e3234aaf 100644
>--- a/drivers/virt/acrn/Kconfig
>+++ b/drivers/virt/acrn/Kconfig
>@@ -2,6 +2,7 @@
> config ACRN_HSM
> 	tristate "ACRN Hypervisor Service Module"
> 	depends on ACRN_GUEST
>+	depends on HOTPLUG_CPU
> 	select EVENTFD
> 	help
> 	  ACRN Hypervisor Service Module (HSM) is a kernel module which
>-- 
>2.29.2
>

  reply	other threads:[~2021-02-26  1:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 13:38 [PATCH] virt: acrn: add hotplug_cpu dependency Arnd Bergmann
2021-02-26  1:38 ` Shuo A Liu [this message]
2021-02-26  6:25   ` Greg Kroah-Hartman
2021-02-26  6:30     ` Shuo A Liu
2021-03-04  8:25       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210226013807.GA9695@shuo-intel.sh.intel.com \
    --to=shuo.a.liu@intel.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=zhi.a.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.