From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: "Björn Töpel" <bjorn.topel@intel.com>,
"Björn Töpel" <bjorn.topel@gmail.com>,
ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
bpf@vger.kernel.org, maciej.fijalkowski@intel.com,
hawk@kernel.org, magnus.karlsson@intel.com,
john.fastabend@gmail.com, kuba@kernel.org, davem@davemloft.net
Subject: Re: [PATCH bpf-next v4 1/2] bpf, xdp: make bpf_redirect_map() a map operation
Date: Fri, 26 Feb 2021 15:28:27 +0100 [thread overview]
Message-ID: <20210226152827.6458324b@carbon> (raw)
In-Reply-To: <87h7lzypzl.fsf@toke.dk>
On Fri, 26 Feb 2021 13:26:22 +0100
Toke Høiland-Jørgensen <toke@redhat.com> wrote:
> Björn Töpel <bjorn.topel@intel.com> writes:
>
> > On 2021-02-26 12:40, Björn Töpel wrote:
> >> On 2021-02-26 12:37, Toke Høiland-Jørgensen wrote:
> >
> > [...]
> >
> >>>
> >>> (That last paragraph above is why I asked if you updated the performance
> >>> numbers in the cover letter; removing an additional function call should
> >>> affect those, right?)
> >>>
> >>
> >> Yeah, it should. Let me spend some more time benchmarking on the DEVMAP
> >> scenario.
> >>
> >
> > I did a re-measure using samples/xdp_redirect_map.
> >
> > The setup is 64B packets blasted to an i40e. As a baseline,
> >
> > # xdp_rxq_info --dev ens801f1 --action XDP_DROP
> >
> > gives 24.8 Mpps.
> >
> >
> > Now, xdp_redirect_map. Same NIC, two ports, receive from port A,
> > redirect to port B:
> >
> > baseline: 14.3 Mpps
> > this series: 15.4 Mpps
> >
> > which is almost 8%!
>
> Or 5 ns difference:
>
> 10**9/(14.3*10**6) - 10**9/(15.4*10**6)
> 4.995004995005004
>
> Nice :)
Yes, this is a very significant improvement at this zoom-in
benchmarking level :-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2021-02-26 14:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 11:23 [PATCH bpf-next v4 0/2] Optimize bpf_redirect_map()/xdp_do_redirect() Björn Töpel
2021-02-26 11:23 ` [PATCH bpf-next v4 1/2] bpf, xdp: make bpf_redirect_map() a map operation Björn Töpel
2021-02-26 11:37 ` Toke Høiland-Jørgensen
2021-02-26 11:40 ` Björn Töpel
2021-02-26 12:04 ` Björn Töpel
2021-02-26 12:26 ` Toke Høiland-Jørgensen
2021-02-26 14:28 ` Jesper Dangaard Brouer [this message]
2021-02-26 14:27 ` Jesper Dangaard Brouer
2021-02-26 14:29 ` Jesper Dangaard Brouer
2021-02-26 15:23 ` kernel test robot
2021-02-26 15:23 ` kernel test robot
2021-02-26 21:48 ` Daniel Borkmann
2021-02-27 9:04 ` Björn Töpel
2021-02-27 10:22 ` Daniel Borkmann
2021-02-26 11:23 ` [PATCH bpf-next v4 2/2] bpf, xdp: restructure redirect actions Björn Töpel
2021-02-26 11:35 ` [PATCH bpf-next v4 0/2] Optimize bpf_redirect_map()/xdp_do_redirect() Toke Høiland-Jørgensen
2021-02-26 11:38 ` Björn Töpel
2021-02-26 11:43 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226152827.6458324b@carbon \
--to=jbrouer@redhat.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.