From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH i2c-tools] Revert "tools: i2ctransfer: add check for returned length from driver"
Date: Fri, 26 Feb 2021 17:43:37 +0100 [thread overview]
Message-ID: <20210226174337.63a9c2a6@endymion> (raw)
In-Reply-To: <20210209110556.18814-1-wsa+renesas@sang-engineering.com>
Hi Wolfram,
On Tue, 9 Feb 2021 12:05:56 +0100, Wolfram Sang wrote:
> This reverts commit 34806fc4e7090b34e32fa1110d546ab5ce01a6a0. It was
> developed against an experimental kernel. The regular kernel does not
> update the new message length to userspace, so the check is always false
> positive. We can't change the kernel behaviour because it would break
> the ABI. So revert this commit.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Very embarrasing :( I am sorry for this. Jean, maybe this is worth a
> 4.2.1. release?
Sorry for not catching this, I must say I did not remember exactly what
the API was supposed to be, and I did not have any device to test the
change.
We don't usually do minor version updates for bug fixes. Instead, what
I do is maintain a list of such "must have" fixes, that package
maintainers can refer to. Look for "Recommended patches" at:
https://i2c.wiki.kernel.org/index.php/I2C_Tools
There's no section for version 4.2 yet, but we can add one as soon as
the commit hits the public repository.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2021-02-26 16:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 11:05 [PATCH i2c-tools] Revert "tools: i2ctransfer: add check for returned length from driver" Wolfram Sang
2021-02-26 16:43 ` Jean Delvare [this message]
2021-03-10 20:46 ` Wolfram Sang
2021-04-10 8:14 ` Peter Korsgaard
2021-04-13 12:54 ` Wolfram Sang
2021-04-21 20:01 ` Peter Korsgaard
2021-05-21 11:21 ` Jean Delvare
2021-05-25 20:36 ` Wolfram Sang
2021-06-02 9:03 ` Jean Delvare
2021-06-02 16:25 ` Wolfram Sang
2021-06-04 13:57 ` Jean Delvare
2021-06-04 19:21 ` Wolfram Sang
2021-06-08 12:22 ` Jean Delvare
2021-06-08 12:26 ` Wolfram Sang
2021-05-21 11:16 ` Jean Delvare
2021-03-07 5:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226174337.63a9c2a6@endymion \
--to=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.