From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [intel-linux-intel-lts:5.4/yocto 5/10] drivers/net/ethernet/intel/igc/igc_ethtool.c:1994:18: error: positional initialization of field in 'struct' declared with 'designated_init' attribute
Date: Fri, 26 Feb 2021 21:25:14 +0800 [thread overview]
Message-ID: <202102262108.Rpu0M014-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 7643 bytes --]
tree: https://github.com/intel/linux-intel-lts.git 5.4/yocto
head: c36197cedf3d07bcc8007612c0afe3a9b61bcd4e
commit: eab3a2cb258924f16019ba8f90b45392cbd55829 [5/10] igc: Add support for tuning frame preemption via ethtool
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel/linux-intel-lts/commit/eab3a2cb258924f16019ba8f90b45392cbd55829
git remote add intel-linux-intel-lts https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-linux-intel-lts 5.4/yocto
git checkout eab3a2cb258924f16019ba8f90b45392cbd55829
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Note: the intel-linux-intel-lts/5.4/yocto HEAD c36197cedf3d07bcc8007612c0afe3a9b61bcd4e builds fine.
It only hurts bisectibility.
All error/warnings (new ones prefixed by >>):
drivers/net/ethernet/intel/igc/igc_ethtool.c:1652:15: warning: 'struct ethtool_fp' declared inside parameter list will not be visible outside of this definition or declaration
1652 | struct ethtool_fp *fpcmd)
| ^~~~~~~~~~
drivers/net/ethernet/intel/igc/igc_ethtool.c: In function 'igc_ethtool_get_preempt':
drivers/net/ethernet/intel/igc/igc_ethtool.c:1656:7: error: dereferencing pointer to incomplete type 'struct ethtool_fp'
1656 | fpcmd->enabled = adapter->frame_preemption_active;
| ^~
drivers/net/ethernet/intel/igc/igc_ethtool.c: At top level:
drivers/net/ethernet/intel/igc/igc_ethtool.c:1663:15: warning: 'struct ethtool_fp' declared inside parameter list will not be visible outside of this definition or declaration
1663 | struct ethtool_fp *fpcmd,
| ^~~~~~~~~~
drivers/net/ethernet/intel/igc/igc_ethtool.c: In function 'igc_ethtool_set_preempt':
drivers/net/ethernet/intel/igc/igc_ethtool.c:1669:11: error: dereferencing pointer to incomplete type 'struct ethtool_fp'
1669 | if (fpcmd->add_frag_size < 68 || fpcmd->add_frag_size > 260) {
| ^~
drivers/net/ethernet/intel/igc/igc_ethtool.c: At top level:
drivers/net/ethernet/intel/igc/igc_ethtool.c:1994:3: error: 'const struct ethtool_ops' has no member named 'get_preempt'
1994 | .get_preempt = igc_ethtool_get_preempt,
| ^~~~~~~~~~~
>> drivers/net/ethernet/intel/igc/igc_ethtool.c:1994:18: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
1994 | .get_preempt = igc_ethtool_get_preempt,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/igc/igc_ethtool.c:1994:18: note: (near initialization for 'igc_ethtool_ops')
drivers/net/ethernet/intel/igc/igc_ethtool.c:1994:18: error: initialization of 'void (*)(struct net_device *, struct ethtool_channels *)' from incompatible pointer type 'int (*)(struct net_device *, struct ethtool_fp *)' [-Werror=incompatible-pointer-types]
drivers/net/ethernet/intel/igc/igc_ethtool.c:1994:18: note: (near initialization for 'igc_ethtool_ops.get_channels')
>> drivers/net/ethernet/intel/igc/igc_ethtool.c:1994:18: warning: initialized field overwritten [-Woverride-init]
drivers/net/ethernet/intel/igc/igc_ethtool.c:1994:18: note: (near initialization for 'igc_ethtool_ops.get_channels')
drivers/net/ethernet/intel/igc/igc_ethtool.c:1995:3: error: 'const struct ethtool_ops' has no member named 'set_preempt'
1995 | .set_preempt = igc_ethtool_set_preempt,
| ^~~~~~~~~~~
drivers/net/ethernet/intel/igc/igc_ethtool.c:1995:18: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
1995 | .set_preempt = igc_ethtool_set_preempt,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/igc/igc_ethtool.c:1995:18: note: (near initialization for 'igc_ethtool_ops')
>> drivers/net/ethernet/intel/igc/igc_ethtool.c:1995:18: error: initialization of 'int (*)(struct net_device *, u32)' {aka 'int (*)(struct net_device *, unsigned int)'} from incompatible pointer type 'int (*)(struct net_device *, struct ethtool_fp *, struct netlink_ext_ack *)' [-Werror=incompatible-pointer-types]
drivers/net/ethernet/intel/igc/igc_ethtool.c:1995:18: note: (near initialization for 'igc_ethtool_ops.set_priv_flags')
drivers/net/ethernet/intel/igc/igc_ethtool.c:1997:21: warning: initialized field overwritten [-Woverride-init]
1997 | .set_priv_flags = igc_ethtool_set_priv_flags,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/igc/igc_ethtool.c:1997:21: note: (near initialization for 'igc_ethtool_ops.set_priv_flags')
cc1: some warnings being treated as errors
vim +1994 drivers/net/ethernet/intel/igc/igc_ethtool.c
1961
1962 static const struct ethtool_ops igc_ethtool_ops = {
1963 /* Resolve conflict with patch - net: igc: let core reject the unsupported coalescing parameters
1964 .supported_coalesce_params = ETHTOOL_COALESCE_USECS, */
1965 .get_drvinfo = igc_ethtool_get_drvinfo,
1966 .get_regs_len = igc_ethtool_get_regs_len,
1967 .get_regs = igc_ethtool_get_regs,
1968 .get_wol = igc_ethtool_get_wol,
1969 .set_wol = igc_ethtool_set_wol,
1970 .get_msglevel = igc_ethtool_get_msglevel,
1971 .set_msglevel = igc_ethtool_set_msglevel,
1972 .nway_reset = igc_ethtool_nway_reset,
1973 .get_link = igc_ethtool_get_link,
1974 .get_eeprom_len = igc_ethtool_get_eeprom_len,
1975 .get_eeprom = igc_ethtool_get_eeprom,
1976 .set_eeprom = igc_ethtool_set_eeprom,
1977 .get_ringparam = igc_ethtool_get_ringparam,
1978 .set_ringparam = igc_ethtool_set_ringparam,
1979 .get_pauseparam = igc_ethtool_get_pauseparam,
1980 .set_pauseparam = igc_ethtool_set_pauseparam,
1981 .get_strings = igc_ethtool_get_strings,
1982 .get_sset_count = igc_ethtool_get_sset_count,
1983 .get_ethtool_stats = igc_ethtool_get_stats,
1984 .get_coalesce = igc_ethtool_get_coalesce,
1985 .set_coalesce = igc_ethtool_set_coalesce,
1986 .get_rxnfc = igc_ethtool_get_rxnfc,
1987 .set_rxnfc = igc_ethtool_set_rxnfc,
1988 .get_rxfh_indir_size = igc_ethtool_get_rxfh_indir_size,
1989 .get_rxfh = igc_ethtool_get_rxfh,
1990 .set_rxfh = igc_ethtool_set_rxfh,
1991 .get_ts_info = igc_ethtool_get_ts_info,
1992 .get_channels = igc_ethtool_get_channels,
1993 .set_channels = igc_ethtool_set_channels,
> 1994 .get_preempt = igc_ethtool_get_preempt,
> 1995 .set_preempt = igc_ethtool_set_preempt,
1996 .get_priv_flags = igc_ethtool_get_priv_flags,
1997 .set_priv_flags = igc_ethtool_set_priv_flags,
1998 .get_eee = igc_ethtool_get_eee,
1999 .set_eee = igc_ethtool_set_eee,
2000 .begin = igc_ethtool_begin,
2001 .complete = igc_ethtool_complete,
2002 .get_link_ksettings = igc_ethtool_get_link_ksettings,
2003 .set_link_ksettings = igc_ethtool_set_link_ksettings,
2004 .self_test = igc_ethtool_diag_test,
2005 };
2006
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 63951 bytes --]
reply other threads:[~2021-02-26 13:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102262108.Rpu0M014-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.