From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE4B2C433E9 for ; Sun, 28 Feb 2021 08:30:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DAEE64E51 for ; Sun, 28 Feb 2021 08:30:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbhB1IaA (ORCPT ); Sun, 28 Feb 2021 03:30:00 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:55882 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230419AbhB1I37 (ORCPT ); Sun, 28 Feb 2021 03:29:59 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 749D61C0B77; Sun, 28 Feb 2021 09:29:14 +0100 (CET) Date: Sun, 28 Feb 2021 09:29:13 +0100 From: Pavel Machek To: kernel test robot , linux-leds@vger.kernel.org Cc: Amireddy Mallikarjuna reddy , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip' Message-ID: <20210228082913.GA27151@amd> References: <202102280329.hv7RoHLA-lkp@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <202102280329.hv7RoHLA-lkp@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >> drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration o= f function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration] > gpiod_set_value(led->gpiod, val); > ^ > drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean > 'gpio_set_value'? It looks like missing #include? While at it, can you do something with Kconfig help text? Move existing one into comment in the driver, add something useful for end-users. Thank you, Pavel --=20 http://www.livejournal.com/~pavelmachek --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmA7VFkACgkQMOfwapXb+vJIuACaAvjcK75ZHLtHKWccdkr+sTui BpgAn29Exf+50mxBYN/Et3japQPws1vE =Bxif -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8715221089403227875==" MIME-Version: 1.0 From: Pavel Machek To: kbuild-all@lists.01.org Subject: Re: drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip' Date: Sun, 28 Feb 2021 09:29:13 +0100 Message-ID: <20210228082913.GA27151@amd> In-Reply-To: <202102280329.hv7RoHLA-lkp@intel.com> List-Id: --===============8715221089403227875== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi! > >> drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration o= f function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration] > gpiod_set_value(led->gpiod, val); > ^ > drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean > 'gpio_set_value'? It looks like missing #include? While at it, can you do something with Kconfig help text? Move existing one into comment in the driver, add something useful for end-users. Thank you, Pavel -- = http://www.livejournal.com/~pavelmachek --===============8715221089403227875== Content-Type: application/pgp-signature MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEKCmlFWUVBUkVD QUFZRkFtQTdWRmtBQ2drUU1PZndhcFhiK3ZKSXVBQ2FBdmpjSzc1WkhMdEhLV2NjZGtyK3NUdWkK QnBnQW4yOUV4Zis1MG14QllOL0V0M2phcFFQd3MxdkUKPUJ4aWYKLS0tLS1FTkQgUEdQIFNJR05B VFVSRS0tLS0tCg== --===============8715221089403227875==--