All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [jirislaby:devel 76/100] drivers/usb/class/cdc-acm.c:1057:10: error: expected '; ' before 'acm'
Date: Mon, 01 Mar 2021 21:34:50 +0800	[thread overview]
Message-ID: <202103012145.E07YfiSu-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3221 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
head:   61fbd3f9b3f46a50216cc58557ed831d7a686734
commit: 8eba9d0ff9f60cd0f7e1ee447e6894250972c7c2 [76/100] make use of tty_get_byte_size
config: nios2-randconfig-r001-20210301 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commit/?id=8eba9d0ff9f60cd0f7e1ee447e6894250972c7c2
        git remote add jirislaby https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git
        git fetch --no-tags jirislaby devel
        git checkout 8eba9d0ff9f60cd0f7e1ee447e6894250972c7c2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/usb/class/cdc-acm.c: In function 'acm_tty_set_termios':
>> drivers/usb/class/cdc-acm.c:1057:10: error: expected ';' before 'acm'
    1057 |    false)
         |          ^
         |          ;
   ......
    1060 |  acm->clocal = ((termios->c_cflag & CLOCAL) != 0);
         |  ~~~      


vim +1057 drivers/usb/class/cdc-acm.c

  1042	
  1043	static void acm_tty_set_termios(struct tty_struct *tty,
  1044							struct ktermios *termios_old)
  1045	{
  1046		struct acm *acm = tty->driver_data;
  1047		struct ktermios *termios = &tty->termios;
  1048		struct usb_cdc_line_coding newline;
  1049		int newctrl = acm->ctrlout;
  1050	
  1051		newline.dwDTERate = cpu_to_le32(tty_get_baud_rate(tty));
  1052		newline.bCharFormat = termios->c_cflag & CSTOPB ? 2 : 0;
  1053		newline.bParityType = termios->c_cflag & PARENB ?
  1054					(termios->c_cflag & PARODD ? 1 : 2) +
  1055					(termios->c_cflag & CMSPAR ? 2 : 0) : 0;
  1056		newline.bDataBits = tty_get_byte_size(termios->c_cflag, false, false,
> 1057				false)
  1058	
  1059		/* FIXME: Needs to clear unsupported bits in the termios */
  1060		acm->clocal = ((termios->c_cflag & CLOCAL) != 0);
  1061	
  1062		if (C_BAUD(tty) == B0) {
  1063			newline.dwDTERate = acm->line.dwDTERate;
  1064			newctrl &= ~ACM_CTRL_DTR;
  1065		} else if (termios_old && (termios_old->c_cflag & CBAUD) == B0) {
  1066			newctrl |=  ACM_CTRL_DTR;
  1067		}
  1068	
  1069		if (newctrl != acm->ctrlout)
  1070			acm_set_control(acm, acm->ctrlout = newctrl);
  1071	
  1072		if (memcmp(&acm->line, &newline, sizeof newline)) {
  1073			memcpy(&acm->line, &newline, sizeof newline);
  1074			dev_dbg(&acm->control->dev, "%s - set line: %d %d %d %d\n",
  1075				__func__,
  1076				le32_to_cpu(newline.dwDTERate),
  1077				newline.bCharFormat, newline.bParityType,
  1078				newline.bDataBits);
  1079			acm_set_line(acm, &acm->line);
  1080		}
  1081	}
  1082	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28119 bytes --]

                 reply	other threads:[~2021-03-01 13:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202103012145.E07YfiSu-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.