From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Brauner <christian.brauner@ubuntu.com>,
fstests@vger.kernel.org
Subject: Re: [PATCH] generic/624: add fstests for idmapped mounts
Date: Mon, 1 Mar 2021 17:43:33 -0800 [thread overview]
Message-ID: <20210302014333.GF7269@magnolia> (raw)
In-Reply-To: <20210301173251.GA5375@lst.de>
On Mon, Mar 01, 2021 at 06:32:51PM +0100, Christoph Hellwig wrote:
> > +# Modify as appropriate.
> > +_supported_fs ext4 xfs
>
> I think this should be
>
> _supported_fs generic
>
> now that we do the probing for the actual support, and any file system
> not supporting it will just do a _notrun from _require_idmapped_mounts.
>
> Also the comment above this line should be dropped.
The rest of this series still hasn't shown up in my inbox...
...but I did wonder, have you all tested file creation with idmapped
mounts and quotas enabled? I noticed after the fact (sorry...) that
the dqalloc call just prior to creating the inode still uses
current_fs[ug]id() and not the fs[ug]id_into_mnt() call that the
conversion series uses.
(The fact that xfs access the ids once for quota and again when actually
creating the inode is screaming for a cleanup, by the way...)
--D
next prev parent reply other threads:[~2021-03-02 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210301151712.1994033-1-christian.brauner@ubuntu.com>
2021-03-01 17:32 ` [PATCH] generic/624: add fstests for idmapped mounts Christoph Hellwig
2021-03-02 1:43 ` Darrick J. Wong [this message]
2021-03-02 8:04 ` Christian Brauner
2021-03-02 8:05 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302014333.GF7269@magnolia \
--to=djwong@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.