From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49ABDC433E0 for ; Tue, 2 Mar 2021 13:32:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBCBF64F33 for ; Tue, 2 Mar 2021 13:32:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1446189AbhCBN1q (ORCPT ); Tue, 2 Mar 2021 08:27:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:39616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244070AbhCBMAe (ORCPT ); Tue, 2 Mar 2021 07:00:34 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 505DD64F21; Tue, 2 Mar 2021 11:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614686159; bh=ttBSAstuxahvrv6pryYeHwkR2zP2IIvHIkOm3LxkB/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hDr/PYJHzZTt7ieblGQo/YFcyeKJL2hzxeLCRCMia2uk/rLDIcID7TBuhzv2hJ0Be TYuoCTnqayTRu0Ml3WizNoOD6b/FeqB+ttfTJUUwOddTFl0LbqxkEB4emLEizKJ8aL TCHYGjgsYPJSevPvxY4q898I+xn4Oagvo3ce1gle48x/6qbMeGqXFmVrNLSqqBrVPT im4JPRbA4vJuovT0uogU6oKL676MdIZN1ZnJEifMjwgfeiqfMNZfwB/0d6OYz9ScQp 7aegolC8LS2qYeQ/KPK3slgKLKC4EFj4avTA9WntwZUuzsmjpBSNl71IPgivFyEnE3 IIpZU6Rli5zLg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alain Volmat , Mark Brown , Sasha Levin , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.11 18/52] spi: stm32: make spurious and overrun interrupts visible Date: Tue, 2 Mar 2021 06:54:59 -0500 Message-Id: <20210302115534.61800-18-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210302115534.61800-1-sashal@kernel.org> References: <20210302115534.61800-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org From: Alain Volmat [ Upstream commit c64e7efe46b7de21937ef4b3594d9b1fc74f07df ] We do not expect to receive spurious interrupts so rise a warning if it happens. RX overrun is an error condition that signals a corrupted RX stream both in dma and in irq modes. Report the error and abort the transfer in either cases. Signed-off-by: Alain Volmat Link: https://lore.kernel.org/r/1612551572-495-9-git-send-email-alain.volmat@foss.st.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-stm32.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 6017209c6d2f..4bcdad084801 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -928,8 +928,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) mask |= STM32H7_SPI_SR_RXP; if (!(sr & mask)) { - dev_dbg(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n", - sr, ier); + dev_warn(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n", + sr, ier); spin_unlock_irqrestore(&spi->lock, flags); return IRQ_NONE; } @@ -956,15 +956,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) } if (sr & STM32H7_SPI_SR_OVR) { - dev_warn(spi->dev, "Overrun: received value discarded\n"); - if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0))) - stm32h7_spi_read_rxfifo(spi, false); - /* - * If overrun is detected while using DMA, it means that - * something went wrong, so stop the current transfer - */ - if (spi->cur_usedma) - end = true; + dev_err(spi->dev, "Overrun: RX data lost\n"); + end = true; } if (sr & STM32H7_SPI_SR_EOT) { -- 2.30.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AAE1C433DB for ; Wed, 3 Mar 2021 19:56:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7268664ED0 for ; Wed, 3 Mar 2021 19:56:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7268664ED0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4io4sMWoIc6oN2TqbOFodjDima4wB+/6BdZYjj1yZO0=; b=ItAEChMXehirY9X7xG2qGjRHF Q6ALyojbkHW2Cz/UHmMNDFHOZlU/pwgzcEhH9b0HW3nYob4Hlz2TTWUM6obuZTQSjE08Vw6p/3yfG P/xy37stbsngzbMrmtyMl1iDfwzn2hBbyuny/HGDd8m6X/llc6z7uAn8n0CO+PR4O8cUi3s3UAjv+ eMZbtvzpfX/ExfIYqSO5L9tx668lVv/H4UeCNC6ueeXdyYXdkYRb+MRzHmlzyOjh7kMX2DkG83Dvu Jx0Idrt0c3rMHYvQG+HiBKr9v0HKxevHkWK9gvOH32NkoQel0hkd8NxlqfaZvlHLC/FCYhEPzkucz TmYftmbFw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHXYt-006J31-DX; Wed, 03 Mar 2021 19:53:36 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHT4T-005IP5-PW for linux-arm-kernel@desiato.infradead.org; Wed, 03 Mar 2021 15:05:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=2PNFKuioXg+dsTbFSmfNgC7L3q5vE+OZRH16KDNi1I4=; b=RMetjehbORoXwiWLdVlGUL+uaz viPKmhr/Y5lm7ksWkYXW8KstNkKxgJgQw2t1ixphkWhvEGik6SRpu5sCAp7d2lKkvUhnH0z+t6dXV Gq7dVh/mUxuahoRJKTt7fiU2g/rQAn05c9NhKef1/Wwayja+LNnHInDv9tIP3nmlds3Exb7bjkVHF 7/A3htfjfIgBgdg3TsSweBvdXkpxNJ8TE7yZQcvoIRCXBrpcEim5tMuq9tS+4GYq784KveIcbJ5aj Ew3SC84j1nEa8xHujiKiPE3WyHbA6yR3FqyuZoteRoVbUqInlQoe4HQdO45i0I5+gjK9kTFbtnltB NyTyW3HA==; Received: from mail.kernel.org ([198.145.29.99]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lH3dD-00H36e-KH for linux-arm-kernel@lists.infradead.org; Tue, 02 Mar 2021 11:56:08 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 505DD64F21; Tue, 2 Mar 2021 11:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614686159; bh=ttBSAstuxahvrv6pryYeHwkR2zP2IIvHIkOm3LxkB/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hDr/PYJHzZTt7ieblGQo/YFcyeKJL2hzxeLCRCMia2uk/rLDIcID7TBuhzv2hJ0Be TYuoCTnqayTRu0Ml3WizNoOD6b/FeqB+ttfTJUUwOddTFl0LbqxkEB4emLEizKJ8aL TCHYGjgsYPJSevPvxY4q898I+xn4Oagvo3ce1gle48x/6qbMeGqXFmVrNLSqqBrVPT im4JPRbA4vJuovT0uogU6oKL676MdIZN1ZnJEifMjwgfeiqfMNZfwB/0d6OYz9ScQp 7aegolC8LS2qYeQ/KPK3slgKLKC4EFj4avTA9WntwZUuzsmjpBSNl71IPgivFyEnE3 IIpZU6Rli5zLg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alain Volmat , Mark Brown , Sasha Levin , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.11 18/52] spi: stm32: make spurious and overrun interrupts visible Date: Tue, 2 Mar 2021 06:54:59 -0500 Message-Id: <20210302115534.61800-18-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210302115534.61800-1-sashal@kernel.org> References: <20210302115534.61800-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210302_115608_242919_D00ADBCF X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Alain Volmat [ Upstream commit c64e7efe46b7de21937ef4b3594d9b1fc74f07df ] We do not expect to receive spurious interrupts so rise a warning if it happens. RX overrun is an error condition that signals a corrupted RX stream both in dma and in irq modes. Report the error and abort the transfer in either cases. Signed-off-by: Alain Volmat Link: https://lore.kernel.org/r/1612551572-495-9-git-send-email-alain.volmat@foss.st.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-stm32.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 6017209c6d2f..4bcdad084801 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -928,8 +928,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) mask |= STM32H7_SPI_SR_RXP; if (!(sr & mask)) { - dev_dbg(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n", - sr, ier); + dev_warn(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n", + sr, ier); spin_unlock_irqrestore(&spi->lock, flags); return IRQ_NONE; } @@ -956,15 +956,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) } if (sr & STM32H7_SPI_SR_OVR) { - dev_warn(spi->dev, "Overrun: received value discarded\n"); - if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0))) - stm32h7_spi_read_rxfifo(spi, false); - /* - * If overrun is detected while using DMA, it means that - * something went wrong, so stop the current transfer - */ - if (spi->cur_usedma) - end = true; + dev_err(spi->dev, "Overrun: RX data lost\n"); + end = true; } if (sr & STM32H7_SPI_SR_EOT) { -- 2.30.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel