From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2364222555456502538==" MIME-Version: 1.0 From: Dan Carpenter Subject: Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'. Date: Tue, 02 Mar 2021 19:28:05 +0300 Message-ID: <20210302162805.GV2222@kadam> In-Reply-To: List-Id: To: kbuild@lists.01.org --===============2364222555456502538== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Mar 02, 2021 at 04:47:01PM +0100, Linus Walleij wrote: > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter wrote: > = > > New smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: un= initialized symbol 'strength'. > > > > Old smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: un= initialized symbol 'pullup'. > = > I don't think these are real problems, but maybe there is some way to exp= licitly > express that so that smatch knows as well? They will call syzbot warning at runtime as well. Syzbot complains about the read, and not that the value is important for flow analysis. regards, dan carpenter --===============2364222555456502538==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6979049341363646499==" MIME-Version: 1.0 From: Dan Carpenter To: kbuild-all@lists.01.org Subject: Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'. Date: Tue, 02 Mar 2021 19:28:05 +0300 Message-ID: <20210302162805.GV2222@kadam> In-Reply-To: List-Id: --===============6979049341363646499== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Mar 02, 2021 at 04:47:01PM +0100, Linus Walleij wrote: > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter wrote: > = > > New smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: un= initialized symbol 'strength'. > > > > Old smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: un= initialized symbol 'pullup'. > = > I don't think these are real problems, but maybe there is some way to exp= licitly > express that so that smatch knows as well? They will call syzbot warning at runtime as well. Syzbot complains about the read, and not that the value is important for flow analysis. regards, dan carpenter --===============6979049341363646499==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BB29C4332B for ; Tue, 2 Mar 2021 19:56:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F99A64F25 for ; Tue, 2 Mar 2021 19:56:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1576578AbhCBTQB (ORCPT ); Tue, 2 Mar 2021 14:16:01 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:35746 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238765AbhCBQ3N (ORCPT ); Tue, 2 Mar 2021 11:29:13 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 122GP8lr028821; Tue, 2 Mar 2021 16:28:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=mIMowcrbj4TgmNWttx2aM+yXkbCVccyVmHGqavTctpY=; b=pOdQQ0Mp3n5dC55GVf7pCLe0iOnzBQysIf1EQXn2CdiSLVqJOBBWu5WAr14FQP6n1tbe 7kuEmbovtYA0Wwco6KHoS2ygDw9aR1DFD2mRZdP2ksgz0D6LQovtJGf6hSsJkR3YLcqL inpkCVxns9NZqraa9sMV9HByrbaAMUh6VXTZB3zPj2g1cN307xLc/eLwZoHBNwLQEumD OmBST9g+tGO/xeRAVjXZ+a0mxDfScbufXu23Rupb3hzXBeClEJdGwtQ9zhwWseLcqBqT n/JFylhR1V8PS8b7lbS9Et53vCOBrN4exsRs935vb2vewenQXb4tmrUC71Pa5r8IcR2j EQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 36yeqn07fe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 02 Mar 2021 16:28:19 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 122GOxL3018297; Tue, 2 Mar 2021 16:28:16 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 37000x7q6q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 02 Mar 2021 16:28:16 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 122GSErF019697; Tue, 2 Mar 2021 16:28:14 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 02 Mar 2021 16:28:13 +0000 Date: Tue, 2 Mar 2021 19:28:05 +0300 From: Dan Carpenter To: Linus Walleij Cc: Srinivas Kandagatla , kbuild@lists.01.org, kbuild test robot , kbuild-all@lists.01.org, "linux-kernel@vger.kernel.org" , Bjorn Andersson Subject: Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'. Message-ID: <20210302162805.GV2222@kadam> References: <20210227092152.GC2087@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9911 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103020129 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9911 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=999 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103020129 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 02, 2021 at 04:47:01PM +0100, Linus Walleij wrote: > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter wrote: > > > New smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'. > > > > Old smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: uninitialized symbol 'pullup'. > > I don't think these are real problems, but maybe there is some way to explicitly > express that so that smatch knows as well? They will call syzbot warning at runtime as well. Syzbot complains about the read, and not that the value is important for flow analysis. regards, dan carpenter