From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8987244416514614423==" MIME-Version: 1.0 From: Dan Carpenter Subject: Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'. Date: Tue, 02 Mar 2021 20:01:49 +0300 Message-ID: <20210302170149.GX2222@kadam> In-Reply-To: List-Id: To: kbuild@lists.01.org --===============8987244416514614423== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Mar 02, 2021 at 04:47:01PM +0100, Linus Walleij wrote: > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter wrote: > = > > New smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: un= initialized symbol 'strength'. > > > > Old smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: un= initialized symbol 'pullup'. > = > I don't think these are real problems, but maybe there is some way to exp= licitly > express that so that smatch knows as well? > = We chould just initialize it to zero. Eventually, (or maybe already???), zero initializing stack variables will be the default for kernels built with modern compilers. So initializing it to zero in that case won't change runtime at all. regards, dan carpenter --===============8987244416514614423==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7381625635461966832==" MIME-Version: 1.0 From: Dan Carpenter To: kbuild-all@lists.01.org Subject: Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'. Date: Tue, 02 Mar 2021 20:01:49 +0300 Message-ID: <20210302170149.GX2222@kadam> In-Reply-To: List-Id: --===============7381625635461966832== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Mar 02, 2021 at 04:47:01PM +0100, Linus Walleij wrote: > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter wrote: > = > > New smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: un= initialized symbol 'strength'. > > > > Old smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: un= initialized symbol 'pullup'. > = > I don't think these are real problems, but maybe there is some way to exp= licitly > express that so that smatch knows as well? > = We chould just initialize it to zero. Eventually, (or maybe already???), zero initializing stack variables will be the default for kernels built with modern compilers. So initializing it to zero in that case won't change runtime at all. regards, dan carpenter --===============7381625635461966832==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9F2AC43381 for ; Tue, 2 Mar 2021 21:12:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C084764F27 for ; Tue, 2 Mar 2021 21:12:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381492AbhCBVKU (ORCPT ); Tue, 2 Mar 2021 16:10:20 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:40730 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352079AbhCBSK5 (ORCPT ); Tue, 2 Mar 2021 13:10:57 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 122GjDhd068314; Tue, 2 Mar 2021 17:02:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=JfHN7bR7XJbye+/fOE8L0CdgtTYsUUluVDX1OIk1+9w=; b=Cl4ZToh7Svl6FMTp0Q1NBZX5PrsoawG24bKigjtCSPUiK2EIFrUs7kxJLGgIYhmu0dnP L9ITCmaDHdDm3ITVSOverds0OzhXpRczfdo1PVG3CC8uuYpUZC9gsf/HchDPR+DxMoaK tv6mWEntMuceuZhL48S7ahJ0x8KYFRrr3fSZ4oKeW0lCZDC06NNdmN7w13DgDFm72czU muTPUthV3AvZ6ylL+JrbFW85oripH2FQjTPp/fUrWA0ozcL9kE0B19xSPt7SYBpfVEEJ zR/fRlw6tLCeZ6DO16bXeg6QUwlGv96AvgG2HDTMAnA6g/CzincVpmAcUYkWLMa5/YFS lA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 36yeqn0bg5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 02 Mar 2021 17:02:01 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 122H0xR7036909; Tue, 2 Mar 2021 17:01:59 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 37000x9at5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 02 Mar 2021 17:01:59 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 122H1voH001162; Tue, 2 Mar 2021 17:01:57 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 02 Mar 2021 09:01:57 -0800 Date: Tue, 2 Mar 2021 20:01:49 +0300 From: Dan Carpenter To: Linus Walleij Cc: Srinivas Kandagatla , kbuild@lists.01.org, kbuild test robot , kbuild-all@lists.01.org, "linux-kernel@vger.kernel.org" , Bjorn Andersson Subject: Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'. Message-ID: <20210302170149.GX2222@kadam> References: <20210227092152.GC2087@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9911 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103020131 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9911 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=999 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103020130 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 02, 2021 at 04:47:01PM +0100, Linus Walleij wrote: > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter wrote: > > > New smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'. > > > > Old smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: uninitialized symbol 'pullup'. > > I don't think these are real problems, but maybe there is some way to explicitly > express that so that smatch knows as well? > We chould just initialize it to zero. Eventually, (or maybe already???), zero initializing stack variables will be the default for kernels built with modern compilers. So initializing it to zero in that case won't change runtime at all. regards, dan carpenter