From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>
Subject: Re: [PATCHv2 0/2] nvme: fixup MD RAID usage
Date: Wed, 3 Mar 2021 10:01:35 +0900 [thread overview]
Message-ID: <20210303010135.GA5730@localhost.localdomain> (raw)
In-Reply-To: <20210225110534.75710-1-hare@suse.de>
On 21-02-25 12:05:32, Hannes Reinecke wrote:
> Hi all,
>
> ever since the implementation NVMe-oF does not work together with MD RAID.
> MD RAID expects the device to return an I/O error on failure, and to remove
> the block device if the underlying hardware is removed.
> This is contrary to the implementation of NVMe-oF, which will keep on retrying
> I/O while the controller is being reset, and will only remove the block device
> once the last _user_ is gone.
>
> While we already have a 'fast_io_fail_tmo' setting which would ensure
> that I/O errors are returned after the timeout expired, this attribute
> has to be set during the initial 'connect' call.
> So the first patch adds a 'fasi_io_fail_tmo' controller sysfs
> attribute which allows the admin to modify it during runtime.
> To fixup the second issue a new attribute 'no_path_detach' is
> implemented, which will cause the disk to be removed as once the
> last controller holding a path to the namespace is removed (ie after
> all reconnect attempts for that controllers are exhausted).
>
> This is a rework of the earlier path by Keith Busch ('nvme-mpath: delete disk
> after last connection'). Kudos to him for suggesting this approach.
>
> Changes to v1:
> - Integrated reviews from Sagi
> - Use fast_io_fail_tmo instead of a new sysfs attribute
> - Rename attribute to 'no_path_detach'
>
> Hannes Reinecke (2):
> nvme: add 'fast_io_fail_tmo' controller sysfs attribute
> nvme: delete disk when last path is gone
>
> drivers/nvme/host/core.c | 41 ++++++++++++++++++++++++++++++++++-
> drivers/nvme/host/multipath.c | 31 +++++++++++++++++++++++++-
> drivers/nvme/host/nvme.h | 21 +++++++++++++++---
> 3 files changed, 88 insertions(+), 5 deletions(-)
Looks good to me.
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2021-03-03 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 11:05 [PATCHv2 0/2] nvme: fixup MD RAID usage Hannes Reinecke
2021-02-25 11:05 ` [PATCH 1/2] nvme: add 'fast_io_fail_tmo' controller sysfs attribute Hannes Reinecke
2021-03-05 21:10 ` Sagi Grimberg
2021-02-25 11:05 ` [PATCH 2/2] nvme: delete disk when last path is gone Hannes Reinecke
2021-02-25 16:59 ` Keith Busch
2021-02-25 17:37 ` Hannes Reinecke
2021-03-05 21:12 ` Sagi Grimberg
2021-03-03 1:01 ` Minwoo Im [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303010135.GA5730@localhost.localdomain \
--to=minwoo.im.dev@gmail.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.