From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2FBEC433DB for ; Wed, 3 Mar 2021 13:47:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 624E564EF4 for ; Wed, 3 Mar 2021 13:47:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 624E564EF4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E46848D0169; Wed, 3 Mar 2021 08:46:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1D668D0157; Wed, 3 Mar 2021 08:46:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC0348D0169; Wed, 3 Mar 2021 08:46:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id AFD218D0157 for ; Wed, 3 Mar 2021 08:46:59 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 69BC581C6 for ; Wed, 3 Mar 2021 13:46:59 +0000 (UTC) X-FDA: 77878688958.08.0CEB354 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf25.hostedemail.com (Postfix) with ESMTP id 6B6F26000106 for ; Wed, 3 Mar 2021 13:46:57 +0000 (UTC) IronPort-SDR: 3YWq5cGiQMf99THDPdnc83o7RnFwNrY1AZKMjNqfJHFaiFe4IoTQY3hos+ZFFdP25voaF5dzAf uDoLCLPu14vA== X-IronPort-AV: E=McAfee;i="6000,8403,9911"; a="187313288" X-IronPort-AV: E=Sophos;i="5.81,220,1610438400"; d="scan'208";a="187313288" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2021 05:46:50 -0800 IronPort-SDR: DQzN5Uw4VmMcA5u3ynfKDPQDTbOf6GWMs3uEdI/3uIe+6nX54cNLSG/3lO5LmhxOeChBUok4Fe AYVcx7EHeiJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,220,1610438400"; d="scan'208";a="399721837" Received: from shbuild999.sh.intel.com (HELO localhost) ([10.239.146.165]) by fmsmga008.fm.intel.com with ESMTP; 03 Mar 2021 05:46:45 -0800 Date: Wed, 3 Mar 2021 21:46:44 +0800 From: Feng Tang To: Michal Hocko Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Andrea Arcangeli , David Rientjes , Mel Gorman , Mike Kravetz , Randy Dunlap , Vlastimil Babka , "Hansen, Dave" , "Widawsky, Ben" , Andi leen , "Williams, Dan J" Subject: Re: [PATCH v3 RFC 14/14] mm: speedup page alloc for MPOL_PREFERRED_MANY by adding a NO_SLOWPATH gfp bit Message-ID: <20210303134644.GC78458@shbuild999.sh.intel.com> References: <1614766858-90344-1-git-send-email-feng.tang@intel.com> <1614766858-90344-15-git-send-email-feng.tang@intel.com> <20210303120717.GA16736@shbuild999.sh.intel.com> <20210303121833.GB16736@shbuild999.sh.intel.com> <20210303131832.GB78458@shbuild999.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210303131832.GB78458@shbuild999.sh.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Stat-Signature: khx1e31uj8yidf4ufrx5pxqz9uyara97 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6B6F26000106 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=mga09.intel.com; client-ip=134.134.136.24 X-HE-DKIM-Result: none/none X-HE-Tag: 1614779217-908725 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 03, 2021 at 09:18:32PM +0800, Tang, Feng wrote: > On Wed, Mar 03, 2021 at 01:32:11PM +0100, Michal Hocko wrote: > > On Wed 03-03-21 20:18:33, Feng Tang wrote: > > > On Wed, Mar 03, 2021 at 08:07:17PM +0800, Tang, Feng wrote: > > > > Hi Michal, > > > > > > > > On Wed, Mar 03, 2021 at 12:39:57PM +0100, Michal Hocko wrote: > > > > > On Wed 03-03-21 18:20:58, Feng Tang wrote: > > > > > > When doing broader test, we noticed allocation slowness in one test > > > > > > case that malloc memory with size which is slightly bigger than free > > > > > > memory of targeted nodes, but much less then the total free memory > > > > > > of system. > > > > > > > > > > > > The reason is the code enters the slowpath of __alloc_pages_nodemask(), > > > > > > which takes quite some time. As alloc_pages_policy() will give it a 2nd > > > > > > try with NULL nodemask, so there is no need to enter the slowpath for > > > > > > the first try. Add a new gfp bit to skip the slowpath, so that user cases > > > > > > like this can leverage. > > > > > > > > > > > > With it, the malloc in such case is much accelerated as it never enters > > > > > > the slowpath. > > > > > > > > > > > > Adding a new gfp_mask bit is generally not liked, and another idea is to > > > > > > add another nodemask to struct 'alloc_context', so it has 2: 'preferred-nmask' > > > > > > and 'fallback-nmask', and they will be tried in turn if not NULL, with > > > > > > it we can call __alloc_pages_nodemask() only once. > > > > > > > > > > Yes, it is very much disliked. Is there any reason why you cannot use > > > > > GFP_NOWAIT for that purpose? > > > > > > > > I did try that at the first place, but it didn't obviously change the slowness. > > > > I assumed the direct claim was still involved as GFP_NOWAIT only impact kswapd > > > > reclaim. > > > > I assume you haven't really created gfp mask correctly. What was the > > exact gfp mask you have used? > > The testcase is a malloc with multi-preferred-node policy, IIRC, the gfp > mask is HIGHUSER_MOVABLE originally, and code here ORs (__GFP_RETRY_MAYFAIL | __GFP_NOWARN). > > As GFP_WAIT == __GFP_KSWAPD_RECLAIM, in this test case, the bit is already set. > > > > > > > One thing I tried which can fix the slowness is: > > > > > > + gfp_mask &= ~(__GFP_DIRECT_RECLAIM | __GFP_KSWAPD_RECLAIM); > > > > > > which explicitly clears the 2 kinds of reclaim. And I thought it's too > > > hacky and didn't mention it in the commit log. > > > > Clearing __GFP_DIRECT_RECLAIM would be the right way to achieve > > GFP_NOWAIT semantic. Why would you want to exclude kswapd as well? > > When I tried gfp_mask &= ~__GFP_DIRECT_RECLAIM, the slowness couldn't > be fixed. I just double checked by rerun the test, 'gfp_mask &= ~__GFP_DIRECT_RECLAIM' can also accelerate the allocation much! though is still a little slower than this patch. Seems I've messed some of the tries, and sorry for the confusion! Could this be used as the solution? or the adding another fallback_nodemask way? but the latter will change the current API quite a bit. Thanks, Feng