From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A219C433E0 for ; Wed, 3 Mar 2021 19:05:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C343064EF6 for ; Wed, 3 Mar 2021 19:05:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C343064EF6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 563756E0B9; Wed, 3 Mar 2021 19:05:02 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id C47206E9C3; Wed, 3 Mar 2021 19:05:00 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B68F64EF3; Wed, 3 Mar 2021 19:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614798300; bh=85Krc/tdNXUI3941UDLi7ozDpdfAZuOSRnkZa35g1kM=; h=Date:From:To:Cc:Subject:From; b=Czbt8bsGw83pm7DsyPtBp60PbC2vRLv45EW9WesL6mrzf8U0cCF4V3GC4Wum9lCR/ gun0VvIN9ouEhwN9lxQ/uCMa54OJuLxyYSCnxn3eris/JPNlxSG5ggGpj6hVxXQIcB bs8WgZ0/LlKV18H26C/rnVr4c4LyYQTIngNrdSc7c68tNRITvLKBMVTXWrlsm0edIT aKbOEFWpGWYr/ChbRSmupaAb8nD0WUMW6JzafXAFf+o7PoDeWPXILAR/r3xO1UTx0D W48Ioah28TJAwNsKVPXe+k8UjkFyzdVSo8o1u3Ph/ZlBYaj+kg+VuDQrsHwrlHFBmd D2QVmjSdymwaA== Date: Wed, 3 Mar 2021 13:04:58 -0600 From: "Gustavo A. R. Silva" To: Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter Subject: [PATCH][next] drm/radeon/si_dpm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE Message-ID: <20210303190458.GA16321@embeddedor> MIME-Version: 1.0 Content-Disposition: inline X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" VGhlcmUgaXMgYSByZWd1bGFyIG5lZWQgaW4gdGhlIGtlcm5lbCB0byBwcm92aWRlIGEgd2F5IHRv IGRlY2xhcmUgaGF2aW5nCmEgZHluYW1pY2FsbHkgc2l6ZWQgc2V0IG9mIHRyYWlsaW5nIGVsZW1l bnRzIGluIGEgc3RydWN0dXJlLiBLZXJuZWwgY29kZQpzaG91bGQgYWx3YXlzIHVzZSDigJxmbGV4 aWJsZSBhcnJheSBtZW1iZXJz4oCdWzFdIGZvciB0aGVzZSBjYXNlcy4gVGhlIG9sZGVyCnN0eWxl IG9mIG9uZS1lbGVtZW50IG9yIHplcm8tbGVuZ3RoIGFycmF5cyBzaG91bGQgbm8gbG9uZ2VyIGJl IHVzZWRbMl0uCgpSZWZhY3RvciB0aGUgY29kZSBhY2NvcmRpbmcgdG8gdGhlIHVzZSBvZiBhIGZs ZXhpYmxlLWFycmF5IG1lbWJlciBpbgpzdHJ1Y3QgU0lTTEFORFNfU01DX1NXU1RBVEUsIGluc3Rl YWQgb2YgYSBvbmUtZWxlbWVudCBhcnJheSwgYW5kIHVzZQp0aGUgc3RydWN0X3NpemUoKSBoZWxw ZXIgdG8gY2FsY3VsYXRlIHRoZSBzaXplIGZvciB0aGUgYWxsb2NhdGlvbi4KCkFsc28sIHRoaXMg aGVscHMgd2l0aCB0aGUgb25nb2luZyBlZmZvcnRzIHRvIGVuYWJsZSAtV2FycmF5LWJvdW5kcyBi eQpmaXhpbmcgdGhlIGZvbGxvd2luZyB3YXJuaW5nczoKCmRyaXZlcnMvZ3B1L2RybS9yYWRlb24v c2lfZHBtLmM6IEluIGZ1bmN0aW9uIOKAmHNpX2NvbnZlcnRfcG93ZXJfc3RhdGVfdG9fc21j4oCZ Ogpkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3NpX2RwbS5jOjIzNTA6MjA6IHdhcm5pbmc6IGFycmF5 IHN1YnNjcmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhTSVNMQU5EU19TTUNfSFdf UEVSRk9STUFOQ0VfTEVWRUxbMV3igJkge2FrYSDigJhzdHJ1Y3QgU0lTTEFORFNfU01DX0hXX1BF UkZPUk1BTkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCiAyMzUwIHwgICBzbWNfc3Rh dGUtPmxldmVsc1tpXS5kcG0yLk1heFBTID0gKHU4KSgoU0lTTEFORFNfRFBNMl9NQVhfUFVMU0Vf U0tJUCAqIChtYXhfc2NsayAtIG1pbl9zY2xrKSkgLyBtYXhfc2Nsayk7CiAgICAgIHwgICB+fn5+ fn5+fn5+fn5+fn5+fl5+fgpkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3NpX2RwbS5jOjIzNTE6MjA6 IHdhcm5pbmc6IGFycmF5IHN1YnNjcmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhT SVNMQU5EU19TTUNfSFdfUEVSRk9STUFOQ0VfTEVWRUxbMV3igJkge2FrYSDigJhzdHJ1Y3QgU0lT TEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCiAy MzUxIHwgICBzbWNfc3RhdGUtPmxldmVsc1tpXS5kcG0yLk5lYXJURFBEZWMgPSBTSVNMQU5EU19E UE0yX05FQVJfVERQX0RFQzsKICAgICAgfCAgIH5+fn5+fn5+fn5+fn5+fn5+Xn5+CmRyaXZlcnMv Z3B1L2RybS9yYWRlb24vc2lfZHBtLmM6MjM1MjoyMDogd2FybmluZzogYXJyYXkgc3Vic2NyaXB0 IDEgaXMgYWJvdmUgYXJyYXkgYm91bmRzIG9mIOKAmFNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5D RV9MRVZFTFsxXeKAmSB7YWthIOKAmHN0cnVjdCBTSVNMQU5EU19TTUNfSFdfUEVSRk9STUFOQ0Vf TEVWRUxbMV3igJl9IFstV2FycmF5LWJvdW5kc10KIDIzNTIgfCAgIHNtY19zdGF0ZS0+bGV2ZWxz W2ldLmRwbTIuQWJvdmVTYWZlSW5jID0gU0lTTEFORFNfRFBNMl9BQk9WRV9TQUZFX0lOQzsKICAg ICAgfCAgIH5+fn5+fn5+fn5+fn5+fn5+Xn5+CmRyaXZlcnMvZ3B1L2RybS9yYWRlb24vc2lfZHBt LmM6MjM1MzoyMDogd2FybmluZzogYXJyYXkgc3Vic2NyaXB0IDEgaXMgYWJvdmUgYXJyYXkgYm91 bmRzIG9mIOKAmFNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTFsxXeKAmSB7YWthIOKA mHN0cnVjdCBTSVNMQU5EU19TTUNfSFdfUEVSRk9STUFOQ0VfTEVWRUxbMV3igJl9IFstV2FycmF5 LWJvdW5kc10KIDIzNTMgfCAgIHNtY19zdGF0ZS0+bGV2ZWxzW2ldLmRwbTIuQmVsb3dTYWZlSW5j ID0gU0lTTEFORFNfRFBNMl9CRUxPV19TQUZFX0lOQzsKICAgICAgfCAgIH5+fn5+fn5+fn5+fn5+ fn5+Xn5+CmRyaXZlcnMvZ3B1L2RybS9yYWRlb24vc2lfZHBtLmM6MjM1NDoyMDogd2FybmluZzog YXJyYXkgc3Vic2NyaXB0IDEgaXMgYWJvdmUgYXJyYXkgYm91bmRzIG9mIOKAmFNJU0xBTkRTX1NN Q19IV19QRVJGT1JNQU5DRV9MRVZFTFsxXeKAmSB7YWthIOKAmHN0cnVjdCBTSVNMQU5EU19TTUNf SFdfUEVSRk9STUFOQ0VfTEVWRUxbMV3igJl9IFstV2FycmF5LWJvdW5kc10KIDIzNTQgfCAgIHNt Y19zdGF0ZS0+bGV2ZWxzW2ldLmRwbTIuUHdyRWZmaWNpZW5jeVJhdGlvID0gY3B1X3RvX2JlMTYo cHdyX2VmZmljaWVuY3lfcmF0aW8pOwogICAgICB8ICAgfn5+fn5+fn5+fn5+fn5+fn5efn4KZHJp dmVycy9ncHUvZHJtL3JhZGVvbi9zaV9kcG0uYzo1MTA1OjIwOiB3YXJuaW5nOiBhcnJheSBzdWJz Y3JpcHQgMSBpcyBhYm92ZSBhcnJheSBib3VuZHMgb2Yg4oCYU0lTTEFORFNfU01DX0hXX1BFUkZP Uk1BTkNFX0xFVkVMWzFd4oCZIHtha2Eg4oCYc3RydWN0IFNJU0xBTkRTX1NNQ19IV19QRVJGT1JN QU5DRV9MRVZFTFsxXeKAmX0gWy1XYXJyYXktYm91bmRzXQogNTEwNSB8ICAgc21jX3N0YXRlLT5s ZXZlbHNbaSArIDFdLmFUID0gY3B1X3RvX2JlMzIoYV90KTsKICAgICAgfCAgIH5+fn5+fn5+fn5+ fn5+fn5+Xn5+fn5+fgoKWzFdIGh0dHBzOi8vZW4ud2lraXBlZGlhLm9yZy93aWtpL0ZsZXhpYmxl X2FycmF5X21lbWJlcgpbMl0gaHR0cHM6Ly93d3cua2VybmVsLm9yZy9kb2MvaHRtbC92NS45L3By b2Nlc3MvZGVwcmVjYXRlZC5odG1sI3plcm8tbGVuZ3RoLWFuZC1vbmUtZWxlbWVudC1hcnJheXMK Ckxpbms6IGh0dHBzOi8vZ2l0aHViLmNvbS9LU1BQL2xpbnV4L2lzc3Vlcy83OQpMaW5rOiBodHRw czovL2dpdGh1Yi5jb20vS1NQUC9saW51eC9pc3N1ZXMvMTA5CkJ1aWxkLXRlc3RlZC1ieToga2Vy bmVsIHRlc3Qgcm9ib3QgPGxrcEBpbnRlbC5jb20+Ckxpbms6IGh0dHBzOi8vbG9yZS5rZXJuZWwu b3JnL2xrbWwvNjAzZjlhOGYuYURMcnBNRnp6U0FwelZZUSUyNWxrcEBpbnRlbC5jb20vClNpZ25l ZC1vZmYtYnk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEgPGd1c3Rhdm9hcnNAa2VybmVsLm9yZz4KLS0t CiBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3NpX2RwbS5jICAgICAgIHwgIDUgKystLS0KIGRyaXZl cnMvZ3B1L2RybS9yYWRlb24vc2lzbGFuZHNfc21jLmggfCAxMCArKysrKy0tLS0tCiAyIGZpbGVz IGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vcmFkZW9uL3NpX2RwbS5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9z aV9kcG0uYwppbmRleCA5MWJmYzQ3NjI3NjcuLjkxODYwOTU1MTgwNCAxMDA2NDQKLS0tIGEvZHJp dmVycy9ncHUvZHJtL3JhZGVvbi9zaV9kcG0uYworKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9u L3NpX2RwbS5jCkBAIC01MjUwLDEwICs1MjUwLDkgQEAgc3RhdGljIGludCBzaV91cGxvYWRfc3df c3RhdGUoc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYsCiAJaW50IHJldDsKIAl1MzIgYWRkcmVz cyA9IHNpX3BpLT5zdGF0ZV90YWJsZV9zdGFydCArCiAJCW9mZnNldG9mKFNJU0xBTkRTX1NNQ19T VEFURVRBQkxFLCBkcml2ZXJTdGF0ZSk7Ci0JdTMyIHN0YXRlX3NpemUgPSBzaXplb2YoU0lTTEFO RFNfU01DX1NXU1RBVEUpICsKLQkJKChuZXdfc3RhdGUtPnBlcmZvcm1hbmNlX2xldmVsX2NvdW50 IC0gMSkgKgotCQkgc2l6ZW9mKFNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTCkpOwog CVNJU0xBTkRTX1NNQ19TV1NUQVRFICpzbWNfc3RhdGUgPSAmc2lfcGktPnNtY19zdGF0ZXRhYmxl LmRyaXZlclN0YXRlOworCXNpemVfdCBzdGF0ZV9zaXplID0gc3RydWN0X3NpemUoc21jX3N0YXRl LCBsZXZlbHMsCisJCQkJCW5ld19zdGF0ZS0+cGVyZm9ybWFuY2VfbGV2ZWxfY291bnQpOwogCiAJ bWVtc2V0KHNtY19zdGF0ZSwgMCwgc3RhdGVfc2l6ZSk7CiAKZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9yYWRlb24vc2lzbGFuZHNfc21jLmggYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3Np c2xhbmRzX3NtYy5oCmluZGV4IDk2NmUzYTU1NjAxMS4uZmJkNjU4OWJkYWI5IDEwMDY0NAotLS0g YS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3Npc2xhbmRzX3NtYy5oCisrKyBiL2RyaXZlcnMvZ3B1 L2RybS9yYWRlb24vc2lzbGFuZHNfc21jLmgKQEAgLTE4MiwxMSArMTgyLDExIEBAIHR5cGVkZWYg c3RydWN0IFNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTCBTSVNMQU5EU19TTUNfSFdf UEVSRk9STUFOQ0VfTEVWCiAKIHN0cnVjdCBTSVNMQU5EU19TTUNfU1dTVEFURQogewotICAgIHVp bnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsYWdzOwotICAgIHVpbnQ4X3QgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGxldmVsQ291bnQ7Ci0gICAgdWludDhfdCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcGFkZGluZzI7Ci0gICAgdWludDhfdCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcGFkZGluZzM7Ci0gICAgU0lTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNF X0xFVkVMICAgbGV2ZWxzWzFdOworCXVpbnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGZsYWdzOworCXVpbnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxldmVsQ291bnQ7 CisJdWludDhfdCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFkZGluZzI7CisJdWludDhf dCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFkZGluZzM7CisJU0lTTEFORFNfU01DX0hX X1BFUkZPUk1BTkNFX0xFVkVMICAgbGV2ZWxzW107CiB9OwogCiB0eXBlZGVmIHN0cnVjdCBTSVNM QU5EU19TTUNfU1dTVEFURSBTSVNMQU5EU19TTUNfU1dTVEFURTsKLS0gCjIuMjcuMAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5n IGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B7B9C433E9 for ; Thu, 4 Mar 2021 00:51:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6669F64F3A for ; Thu, 4 Mar 2021 00:51:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234166AbhCDAvZ (ORCPT ); Wed, 3 Mar 2021 19:51:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:57520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350348AbhCCTFl (ORCPT ); Wed, 3 Mar 2021 14:05:41 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B68F64EF3; Wed, 3 Mar 2021 19:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614798300; bh=85Krc/tdNXUI3941UDLi7ozDpdfAZuOSRnkZa35g1kM=; h=Date:From:To:Cc:Subject:From; b=Czbt8bsGw83pm7DsyPtBp60PbC2vRLv45EW9WesL6mrzf8U0cCF4V3GC4Wum9lCR/ gun0VvIN9ouEhwN9lxQ/uCMa54OJuLxyYSCnxn3eris/JPNlxSG5ggGpj6hVxXQIcB bs8WgZ0/LlKV18H26C/rnVr4c4LyYQTIngNrdSc7c68tNRITvLKBMVTXWrlsm0edIT aKbOEFWpGWYr/ChbRSmupaAb8nD0WUMW6JzafXAFf+o7PoDeWPXILAR/r3xO1UTx0D W48Ioah28TJAwNsKVPXe+k8UjkFyzdVSo8o1u3Ph/ZlBYaj+kg+VuDQrsHwrlHFBmd D2QVmjSdymwaA== Date: Wed, 3 Mar 2021 13:04:58 -0600 From: "Gustavo A. R. Silva" To: Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH][next] drm/radeon/si_dpm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE Message-ID: <20210303190458.GA16321@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Refactor the code according to the use of a flexible-array member in struct SISLANDS_SMC_SWSTATE, instead of a one-element array, and use the struct_size() helper to calculate the size for the allocation. Also, this helps with the ongoing efforts to enable -Warray-bounds by fixing the following warnings: drivers/gpu/drm/radeon/si_dpm.c: In function ‘si_convert_power_state_to_smc’: drivers/gpu/drm/radeon/si_dpm.c:2350:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2350 | smc_state->levels[i].dpm2.MaxPS = (u8)((SISLANDS_DPM2_MAX_PULSE_SKIP * (max_sclk - min_sclk)) / max_sclk); | ~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/radeon/si_dpm.c:2351:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2351 | smc_state->levels[i].dpm2.NearTDPDec = SISLANDS_DPM2_NEAR_TDP_DEC; | ~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/radeon/si_dpm.c:2352:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2352 | smc_state->levels[i].dpm2.AboveSafeInc = SISLANDS_DPM2_ABOVE_SAFE_INC; | ~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/radeon/si_dpm.c:2353:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2353 | smc_state->levels[i].dpm2.BelowSafeInc = SISLANDS_DPM2_BELOW_SAFE_INC; | ~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/radeon/si_dpm.c:2354:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2354 | smc_state->levels[i].dpm2.PwrEfficiencyRatio = cpu_to_be16(pwr_efficiency_ratio); | ~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/radeon/si_dpm.c:5105:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 5105 | smc_state->levels[i + 1].aT = cpu_to_be32(a_t); | ~~~~~~~~~~~~~~~~~^~~~~~~ [1] https://en.wikipedia.org/wiki/Flexible_array_member [2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays Link: https://github.com/KSPP/linux/issues/79 Link: https://github.com/KSPP/linux/issues/109 Build-tested-by: kernel test robot Link: https://lore.kernel.org/lkml/603f9a8f.aDLrpMFzzSApzVYQ%25lkp@intel.com/ Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/radeon/si_dpm.c | 5 ++--- drivers/gpu/drm/radeon/sislands_smc.h | 10 +++++----- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c index 91bfc4762767..918609551804 100644 --- a/drivers/gpu/drm/radeon/si_dpm.c +++ b/drivers/gpu/drm/radeon/si_dpm.c @@ -5250,10 +5250,9 @@ static int si_upload_sw_state(struct radeon_device *rdev, int ret; u32 address = si_pi->state_table_start + offsetof(SISLANDS_SMC_STATETABLE, driverState); - u32 state_size = sizeof(SISLANDS_SMC_SWSTATE) + - ((new_state->performance_level_count - 1) * - sizeof(SISLANDS_SMC_HW_PERFORMANCE_LEVEL)); SISLANDS_SMC_SWSTATE *smc_state = &si_pi->smc_statetable.driverState; + size_t state_size = struct_size(smc_state, levels, + new_state->performance_level_count); memset(smc_state, 0, state_size); diff --git a/drivers/gpu/drm/radeon/sislands_smc.h b/drivers/gpu/drm/radeon/sislands_smc.h index 966e3a556011..fbd6589bdab9 100644 --- a/drivers/gpu/drm/radeon/sislands_smc.h +++ b/drivers/gpu/drm/radeon/sislands_smc.h @@ -182,11 +182,11 @@ typedef struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL SISLANDS_SMC_HW_PERFORMANCE_LEV struct SISLANDS_SMC_SWSTATE { - uint8_t flags; - uint8_t levelCount; - uint8_t padding2; - uint8_t padding3; - SISLANDS_SMC_HW_PERFORMANCE_LEVEL levels[1]; + uint8_t flags; + uint8_t levelCount; + uint8_t padding2; + uint8_t padding3; + SISLANDS_SMC_HW_PERFORMANCE_LEVEL levels[]; }; typedef struct SISLANDS_SMC_SWSTATE SISLANDS_SMC_SWSTATE; -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F08C433E6 for ; Wed, 3 Mar 2021 19:05:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B408F64EEF for ; Wed, 3 Mar 2021 19:05:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B408F64EEF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 666F46E118; Wed, 3 Mar 2021 19:05:02 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id C47206E9C3; Wed, 3 Mar 2021 19:05:00 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B68F64EF3; Wed, 3 Mar 2021 19:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614798300; bh=85Krc/tdNXUI3941UDLi7ozDpdfAZuOSRnkZa35g1kM=; h=Date:From:To:Cc:Subject:From; b=Czbt8bsGw83pm7DsyPtBp60PbC2vRLv45EW9WesL6mrzf8U0cCF4V3GC4Wum9lCR/ gun0VvIN9ouEhwN9lxQ/uCMa54OJuLxyYSCnxn3eris/JPNlxSG5ggGpj6hVxXQIcB bs8WgZ0/LlKV18H26C/rnVr4c4LyYQTIngNrdSc7c68tNRITvLKBMVTXWrlsm0edIT aKbOEFWpGWYr/ChbRSmupaAb8nD0WUMW6JzafXAFf+o7PoDeWPXILAR/r3xO1UTx0D W48Ioah28TJAwNsKVPXe+k8UjkFyzdVSo8o1u3Ph/ZlBYaj+kg+VuDQrsHwrlHFBmd D2QVmjSdymwaA== Date: Wed, 3 Mar 2021 13:04:58 -0600 From: "Gustavo A. R. Silva" To: Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter Subject: [PATCH][next] drm/radeon/si_dpm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE Message-ID: <20210303190458.GA16321@embeddedor> MIME-Version: 1.0 Content-Disposition: inline X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" VGhlcmUgaXMgYSByZWd1bGFyIG5lZWQgaW4gdGhlIGtlcm5lbCB0byBwcm92aWRlIGEgd2F5IHRv IGRlY2xhcmUgaGF2aW5nCmEgZHluYW1pY2FsbHkgc2l6ZWQgc2V0IG9mIHRyYWlsaW5nIGVsZW1l bnRzIGluIGEgc3RydWN0dXJlLiBLZXJuZWwgY29kZQpzaG91bGQgYWx3YXlzIHVzZSDigJxmbGV4 aWJsZSBhcnJheSBtZW1iZXJz4oCdWzFdIGZvciB0aGVzZSBjYXNlcy4gVGhlIG9sZGVyCnN0eWxl IG9mIG9uZS1lbGVtZW50IG9yIHplcm8tbGVuZ3RoIGFycmF5cyBzaG91bGQgbm8gbG9uZ2VyIGJl IHVzZWRbMl0uCgpSZWZhY3RvciB0aGUgY29kZSBhY2NvcmRpbmcgdG8gdGhlIHVzZSBvZiBhIGZs ZXhpYmxlLWFycmF5IG1lbWJlciBpbgpzdHJ1Y3QgU0lTTEFORFNfU01DX1NXU1RBVEUsIGluc3Rl YWQgb2YgYSBvbmUtZWxlbWVudCBhcnJheSwgYW5kIHVzZQp0aGUgc3RydWN0X3NpemUoKSBoZWxw ZXIgdG8gY2FsY3VsYXRlIHRoZSBzaXplIGZvciB0aGUgYWxsb2NhdGlvbi4KCkFsc28sIHRoaXMg aGVscHMgd2l0aCB0aGUgb25nb2luZyBlZmZvcnRzIHRvIGVuYWJsZSAtV2FycmF5LWJvdW5kcyBi eQpmaXhpbmcgdGhlIGZvbGxvd2luZyB3YXJuaW5nczoKCmRyaXZlcnMvZ3B1L2RybS9yYWRlb24v c2lfZHBtLmM6IEluIGZ1bmN0aW9uIOKAmHNpX2NvbnZlcnRfcG93ZXJfc3RhdGVfdG9fc21j4oCZ Ogpkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3NpX2RwbS5jOjIzNTA6MjA6IHdhcm5pbmc6IGFycmF5 IHN1YnNjcmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhTSVNMQU5EU19TTUNfSFdf UEVSRk9STUFOQ0VfTEVWRUxbMV3igJkge2FrYSDigJhzdHJ1Y3QgU0lTTEFORFNfU01DX0hXX1BF UkZPUk1BTkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCiAyMzUwIHwgICBzbWNfc3Rh dGUtPmxldmVsc1tpXS5kcG0yLk1heFBTID0gKHU4KSgoU0lTTEFORFNfRFBNMl9NQVhfUFVMU0Vf U0tJUCAqIChtYXhfc2NsayAtIG1pbl9zY2xrKSkgLyBtYXhfc2Nsayk7CiAgICAgIHwgICB+fn5+ fn5+fn5+fn5+fn5+fl5+fgpkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3NpX2RwbS5jOjIzNTE6MjA6 IHdhcm5pbmc6IGFycmF5IHN1YnNjcmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhT SVNMQU5EU19TTUNfSFdfUEVSRk9STUFOQ0VfTEVWRUxbMV3igJkge2FrYSDigJhzdHJ1Y3QgU0lT TEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCiAy MzUxIHwgICBzbWNfc3RhdGUtPmxldmVsc1tpXS5kcG0yLk5lYXJURFBEZWMgPSBTSVNMQU5EU19E UE0yX05FQVJfVERQX0RFQzsKICAgICAgfCAgIH5+fn5+fn5+fn5+fn5+fn5+Xn5+CmRyaXZlcnMv Z3B1L2RybS9yYWRlb24vc2lfZHBtLmM6MjM1MjoyMDogd2FybmluZzogYXJyYXkgc3Vic2NyaXB0 IDEgaXMgYWJvdmUgYXJyYXkgYm91bmRzIG9mIOKAmFNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5D RV9MRVZFTFsxXeKAmSB7YWthIOKAmHN0cnVjdCBTSVNMQU5EU19TTUNfSFdfUEVSRk9STUFOQ0Vf TEVWRUxbMV3igJl9IFstV2FycmF5LWJvdW5kc10KIDIzNTIgfCAgIHNtY19zdGF0ZS0+bGV2ZWxz W2ldLmRwbTIuQWJvdmVTYWZlSW5jID0gU0lTTEFORFNfRFBNMl9BQk9WRV9TQUZFX0lOQzsKICAg ICAgfCAgIH5+fn5+fn5+fn5+fn5+fn5+Xn5+CmRyaXZlcnMvZ3B1L2RybS9yYWRlb24vc2lfZHBt LmM6MjM1MzoyMDogd2FybmluZzogYXJyYXkgc3Vic2NyaXB0IDEgaXMgYWJvdmUgYXJyYXkgYm91 bmRzIG9mIOKAmFNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTFsxXeKAmSB7YWthIOKA mHN0cnVjdCBTSVNMQU5EU19TTUNfSFdfUEVSRk9STUFOQ0VfTEVWRUxbMV3igJl9IFstV2FycmF5 LWJvdW5kc10KIDIzNTMgfCAgIHNtY19zdGF0ZS0+bGV2ZWxzW2ldLmRwbTIuQmVsb3dTYWZlSW5j ID0gU0lTTEFORFNfRFBNMl9CRUxPV19TQUZFX0lOQzsKICAgICAgfCAgIH5+fn5+fn5+fn5+fn5+ fn5+Xn5+CmRyaXZlcnMvZ3B1L2RybS9yYWRlb24vc2lfZHBtLmM6MjM1NDoyMDogd2FybmluZzog YXJyYXkgc3Vic2NyaXB0IDEgaXMgYWJvdmUgYXJyYXkgYm91bmRzIG9mIOKAmFNJU0xBTkRTX1NN Q19IV19QRVJGT1JNQU5DRV9MRVZFTFsxXeKAmSB7YWthIOKAmHN0cnVjdCBTSVNMQU5EU19TTUNf SFdfUEVSRk9STUFOQ0VfTEVWRUxbMV3igJl9IFstV2FycmF5LWJvdW5kc10KIDIzNTQgfCAgIHNt Y19zdGF0ZS0+bGV2ZWxzW2ldLmRwbTIuUHdyRWZmaWNpZW5jeVJhdGlvID0gY3B1X3RvX2JlMTYo cHdyX2VmZmljaWVuY3lfcmF0aW8pOwogICAgICB8ICAgfn5+fn5+fn5+fn5+fn5+fn5efn4KZHJp dmVycy9ncHUvZHJtL3JhZGVvbi9zaV9kcG0uYzo1MTA1OjIwOiB3YXJuaW5nOiBhcnJheSBzdWJz Y3JpcHQgMSBpcyBhYm92ZSBhcnJheSBib3VuZHMgb2Yg4oCYU0lTTEFORFNfU01DX0hXX1BFUkZP Uk1BTkNFX0xFVkVMWzFd4oCZIHtha2Eg4oCYc3RydWN0IFNJU0xBTkRTX1NNQ19IV19QRVJGT1JN QU5DRV9MRVZFTFsxXeKAmX0gWy1XYXJyYXktYm91bmRzXQogNTEwNSB8ICAgc21jX3N0YXRlLT5s ZXZlbHNbaSArIDFdLmFUID0gY3B1X3RvX2JlMzIoYV90KTsKICAgICAgfCAgIH5+fn5+fn5+fn5+ fn5+fn5+Xn5+fn5+fgoKWzFdIGh0dHBzOi8vZW4ud2lraXBlZGlhLm9yZy93aWtpL0ZsZXhpYmxl X2FycmF5X21lbWJlcgpbMl0gaHR0cHM6Ly93d3cua2VybmVsLm9yZy9kb2MvaHRtbC92NS45L3By b2Nlc3MvZGVwcmVjYXRlZC5odG1sI3plcm8tbGVuZ3RoLWFuZC1vbmUtZWxlbWVudC1hcnJheXMK Ckxpbms6IGh0dHBzOi8vZ2l0aHViLmNvbS9LU1BQL2xpbnV4L2lzc3Vlcy83OQpMaW5rOiBodHRw czovL2dpdGh1Yi5jb20vS1NQUC9saW51eC9pc3N1ZXMvMTA5CkJ1aWxkLXRlc3RlZC1ieToga2Vy bmVsIHRlc3Qgcm9ib3QgPGxrcEBpbnRlbC5jb20+Ckxpbms6IGh0dHBzOi8vbG9yZS5rZXJuZWwu b3JnL2xrbWwvNjAzZjlhOGYuYURMcnBNRnp6U0FwelZZUSUyNWxrcEBpbnRlbC5jb20vClNpZ25l ZC1vZmYtYnk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEgPGd1c3Rhdm9hcnNAa2VybmVsLm9yZz4KLS0t CiBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3NpX2RwbS5jICAgICAgIHwgIDUgKystLS0KIGRyaXZl cnMvZ3B1L2RybS9yYWRlb24vc2lzbGFuZHNfc21jLmggfCAxMCArKysrKy0tLS0tCiAyIGZpbGVz IGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vcmFkZW9uL3NpX2RwbS5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9z aV9kcG0uYwppbmRleCA5MWJmYzQ3NjI3NjcuLjkxODYwOTU1MTgwNCAxMDA2NDQKLS0tIGEvZHJp dmVycy9ncHUvZHJtL3JhZGVvbi9zaV9kcG0uYworKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9u L3NpX2RwbS5jCkBAIC01MjUwLDEwICs1MjUwLDkgQEAgc3RhdGljIGludCBzaV91cGxvYWRfc3df c3RhdGUoc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYsCiAJaW50IHJldDsKIAl1MzIgYWRkcmVz cyA9IHNpX3BpLT5zdGF0ZV90YWJsZV9zdGFydCArCiAJCW9mZnNldG9mKFNJU0xBTkRTX1NNQ19T VEFURVRBQkxFLCBkcml2ZXJTdGF0ZSk7Ci0JdTMyIHN0YXRlX3NpemUgPSBzaXplb2YoU0lTTEFO RFNfU01DX1NXU1RBVEUpICsKLQkJKChuZXdfc3RhdGUtPnBlcmZvcm1hbmNlX2xldmVsX2NvdW50 IC0gMSkgKgotCQkgc2l6ZW9mKFNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTCkpOwog CVNJU0xBTkRTX1NNQ19TV1NUQVRFICpzbWNfc3RhdGUgPSAmc2lfcGktPnNtY19zdGF0ZXRhYmxl LmRyaXZlclN0YXRlOworCXNpemVfdCBzdGF0ZV9zaXplID0gc3RydWN0X3NpemUoc21jX3N0YXRl LCBsZXZlbHMsCisJCQkJCW5ld19zdGF0ZS0+cGVyZm9ybWFuY2VfbGV2ZWxfY291bnQpOwogCiAJ bWVtc2V0KHNtY19zdGF0ZSwgMCwgc3RhdGVfc2l6ZSk7CiAKZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9yYWRlb24vc2lzbGFuZHNfc21jLmggYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3Np c2xhbmRzX3NtYy5oCmluZGV4IDk2NmUzYTU1NjAxMS4uZmJkNjU4OWJkYWI5IDEwMDY0NAotLS0g YS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3Npc2xhbmRzX3NtYy5oCisrKyBiL2RyaXZlcnMvZ3B1 L2RybS9yYWRlb24vc2lzbGFuZHNfc21jLmgKQEAgLTE4MiwxMSArMTgyLDExIEBAIHR5cGVkZWYg c3RydWN0IFNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTCBTSVNMQU5EU19TTUNfSFdf UEVSRk9STUFOQ0VfTEVWCiAKIHN0cnVjdCBTSVNMQU5EU19TTUNfU1dTVEFURQogewotICAgIHVp bnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsYWdzOwotICAgIHVpbnQ4X3QgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGxldmVsQ291bnQ7Ci0gICAgdWludDhfdCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcGFkZGluZzI7Ci0gICAgdWludDhfdCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcGFkZGluZzM7Ci0gICAgU0lTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNF X0xFVkVMICAgbGV2ZWxzWzFdOworCXVpbnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGZsYWdzOworCXVpbnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxldmVsQ291bnQ7 CisJdWludDhfdCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFkZGluZzI7CisJdWludDhf dCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFkZGluZzM7CisJU0lTTEFORFNfU01DX0hX X1BFUkZPUk1BTkNFX0xFVkVMICAgbGV2ZWxzW107CiB9OwogCiB0eXBlZGVmIHN0cnVjdCBTSVNM QU5EU19TTUNfU1dTVEFURSBTSVNMQU5EU19TTUNfU1dTVEFURTsKLS0gCjIuMjcuMAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==