Re: [PATCH 2/2] of/fdt: Append bootloader arguments when CMDLINE_EXTEND=y

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3437 bytes --]

Hi Will,

I love your patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on linus/master v5.12-rc1 next-20210303]
[cannot apply to robh/for-next linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Will-Deacon/Fix-CMDLINE_EXTEND-handling-for-FDT-bootargs/20210225-210308
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: h8300-randconfig-r001-20210303 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4a51ebf041dde84115b1c49a9fbca337791a66fc
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Will-Deacon/Fix-CMDLINE_EXTEND-handling-for-FDT-bootargs/20210225-210308
        git checkout 4a51ebf041dde84115b1c49a9fbca337791a66fc
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/of/fdt.c: In function 'early_init_dt_retrieve_cmdline':
>> drivers/of/fdt.c:1052:29: error: 'CONFIG_CMDLINE' undeclared (first use in this function); did you mean 'CONFIG_FB_CMDLINE'?
    1052 |   size_t idx = strlcpy(dst, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
         |                             ^~~~~~~~~~~~~~
         |                             CONFIG_FB_CMDLINE
   drivers/of/fdt.c:1052:29: note: each undeclared identifier is reported only once for each function it appears in


vim +1052 drivers/of/fdt.c

  1046	
  1047	/* dst is a zero-initialised buffer of COMMAND_LINE_SIZE bytes */
  1048	static void __init early_init_dt_retrieve_cmdline(unsigned long node, char *dst)
  1049	{
  1050		if (IS_ENABLED(CONFIG_CMDLINE_EXTEND)) {
  1051			/* Copy CONFIG_CMDLINE to the start of destination buffer */
> 1052			size_t idx = strlcpy(dst, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
  1053	
  1054			/* Check that we have enough space to concatenate */
  1055			if (idx + 1 >= COMMAND_LINE_SIZE)
  1056				return;
  1057	
  1058			/* Append the bootloader arguments */
  1059			dst[idx++] = ' ';
  1060			cmdline_from_bootargs(node, &dst[idx], COMMAND_LINE_SIZE - idx);
  1061		} else if (IS_ENABLED(CONFIG_CMDLINE_FORCE)) {
  1062			/* Just use CONFIG_CMDLINE */
  1063			strlcpy(dst, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
  1064		} else if (IS_ENABLED(CONFIG_CMDLINE_FROM_BOOTLOADER)) {
  1065			/* Use CONFIG_CMDLINE if no arguments from bootloader. */
  1066			if (cmdline_from_bootargs(node, dst, COMMAND_LINE_SIZE) <= 0)
  1067				strlcpy(dst, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
  1068		} else {
  1069			/* Just use bootloader arguments */
  1070			cmdline_from_bootargs(node, dst, COMMAND_LINE_SIZE);
  1071		}
  1072	}
  1073	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 21495 bytes --]