Re: [Intel-gfx] [PATCH] i915/query: Correlate engine and cpu timestamps with better accuracy

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4294 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210303212800.43787-1-umesh.nerlige.ramappa@intel.com>
References: <20210303212800.43787-1-umesh.nerlige.ramappa@intel.com>
TO: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
TO: intel-gfx(a)lists.freedesktop.org
TO: Chris Wilson <chris.p.wilson@intel.com>
TO: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
TO: Lionel G Landwerlin <lionel.g.landwerlin@intel.com>

Hi Umesh,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on drm-intel/for-linux-next v5.12-rc1 next-20210303]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Umesh-Nerlige-Ramappa/i915-query-Correlate-engine-and-cpu-timestamps-with-better-accuracy/20210304-053002
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: i386-randconfig-m021-20210304 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/i915/i915_query.c:172 __query_cs_cycles() error: uninitialized symbol 'ret'.

vim +/ret +172 drivers/gpu/drm/i915/i915_query.c

ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  141  
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  142  static int
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  143  __query_cs_cycles(struct intel_engine_cs *engine,
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  144  		  u64 *cs_ts, u64 *cpu_ts,
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  145  		  __ktime_func_t cpu_clock)
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  146  {
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  147  	struct intel_uncore *uncore = engine->uncore;
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  148  	enum forcewake_domains fw_domains;
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  149  	u32 base = engine->mmio_base;
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  150  	intel_wakeref_t wakeref;
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  151  	int ret;
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  152  
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  153  	fw_domains = intel_uncore_forcewake_for_reg(uncore,
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  154  						    RING_TIMESTAMP(base),
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  155  						    FW_REG_READ);
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  156  
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  157  	with_intel_runtime_pm(uncore->rpm, wakeref) {
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  158  		spin_lock_irq(&uncore->lock);
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  159  		intel_uncore_forcewake_get__locked(uncore, fw_domains);
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  160  
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  161  		ret = __read_timestamps(uncore,
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  162  					RING_TIMESTAMP(base),
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  163  					RING_TIMESTAMP_UDW(base),
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  164  					cs_ts,
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  165  					cpu_ts,
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  166  					cpu_clock);
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  167  
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  168  		intel_uncore_forcewake_put__locked(uncore, fw_domains);
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  169  		spin_unlock_irq(&uncore->lock);
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  170  	}
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  171  
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03 @172  	return ret;
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  173  }
ef81d31bf15aff Umesh Nerlige Ramappa 2021-03-03  174  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32979 bytes --]