All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Kurz <akurz@blala.de>
Cc: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH] ARM: i.MX8M: bbu: fix variable name to used semantic
Date: Thu, 4 Mar 2021 12:14:16 +0100	[thread overview]
Message-ID: <20210304111416.GC12944@pengutronix.de> (raw)
In-Reply-To: <20210304063258.16080-1-user@vserver64>

On Thu, Mar 04, 2021 at 06:32:58AM +0000, Alexander Kurz wrote:
> From: Alexander Kurz <akurz@blala.de>
> 
> Both flags handle BBU behavior and should be bbu_flags.
> 
> Signed-off-by: Alexander Kurz <akurz@blala.de>
> ---
>  arch/arm/boards/nxp-imx8mm-evk/board.c | 6 +++---
>  arch/arm/boards/nxp-imx8mp-evk/board.c | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/boards/nxp-imx8mm-evk/board.c b/arch/arm/boards/nxp-imx8mm-evk/board.c
> index 2603a2ab0..6e4df6006 100644
> --- a/arch/arm/boards/nxp-imx8mm-evk/board.c
> +++ b/arch/arm/boards/nxp-imx8mm-evk/board.c
> @@ -33,7 +33,7 @@ static int ar8031_phy_fixup(struct phy_device *phydev)
>  static int nxp_imx8mm_evk_init(void)
>  {
>  	int emmc_bbu_flag = 0;
> -	int emmc_sd_flag = 0;
> +	int sd_bbu_flag = 0;
>  
>  	if (!of_machine_is_compatible("fsl,imx8mm-evk"))
>  		return 0;
> @@ -46,14 +46,14 @@ static int nxp_imx8mm_evk_init(void)
>  			emmc_bbu_flag = BBU_HANDLER_FLAG_DEFAULT;
>  		} else {
>  			of_device_enable_path("/chosen/environment-sd");
> -			emmc_sd_flag = BBU_HANDLER_FLAG_DEFAULT;
> +			sd_bbu_flag = BBU_HANDLER_FLAG_DEFAULT;
>  		}
>  	} else {
>  		of_device_enable_path("/chosen/environment-emmc");
>  		emmc_bbu_flag = BBU_HANDLER_FLAG_DEFAULT;
>  	}
>  
> -	imx8m_bbu_internal_mmc_register_handler("SD", "/dev/mmc1.barebox", emmc_sd_flag);
> +	imx8m_bbu_internal_mmc_register_handler("SD", "/dev/mmc1.barebox", sd_bbu_flag);
>  	imx8m_bbu_internal_mmcboot_register_handler("eMMC", "/dev/mmc2", emmc_bbu_flag);
>  
>  	phy_register_fixup_for_uid(PHY_ID_AR8031, AR_PHY_ID_MASK,
> diff --git a/arch/arm/boards/nxp-imx8mp-evk/board.c b/arch/arm/boards/nxp-imx8mp-evk/board.c
> index f64f46681..a3ff59810 100644
> --- a/arch/arm/boards/nxp-imx8mp-evk/board.c
> +++ b/arch/arm/boards/nxp-imx8mp-evk/board.c
> @@ -17,7 +17,7 @@
>  static int nxp_imx8mp_evk_init(void)
>  {
>  	int emmc_bbu_flag = 0;
> -	int emmc_sd_flag = 0;
> +	int sd_bbu_flag = 0;
>  	u32 val;
>  
>  	if (!of_machine_is_compatible("fsl,imx8mp-evk"))
> @@ -29,14 +29,14 @@ static int nxp_imx8mp_evk_init(void)
>  			emmc_bbu_flag = BBU_HANDLER_FLAG_DEFAULT;
>  		} else {
>  			of_device_enable_path("/chosen/environment-sd");
> -			emmc_sd_flag = BBU_HANDLER_FLAG_DEFAULT;
> +			sd_bbu_flag = BBU_HANDLER_FLAG_DEFAULT;
>  		}
>  	} else {
>  		of_device_enable_path("/chosen/environment-emmc");
>  		emmc_bbu_flag = BBU_HANDLER_FLAG_DEFAULT;
>  	}
>  
> -	imx8m_bbu_internal_mmc_register_handler("SD", "/dev/mmc1.barebox", emmc_sd_flag);
> +	imx8m_bbu_internal_mmc_register_handler("SD", "/dev/mmc1.barebox", sd_bbu_flag);
>  	imx8m_bbu_internal_mmc_register_handler("eMMC", "/dev/mmc2", emmc_bbu_flag);
>  
>  	val = readl(MX8MP_IOMUXC_GPR_BASE_ADDR + MX8MP_IOMUXC_GPR1);
> -- 
> 2.20.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-03-04 11:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04  6:32 [PATCH] ARM: i.MX8M: bbu: fix variable name to used semantic Alexander Kurz
2021-03-04 11:14 ` Sascha Hauer [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-02  7:34 Alexander Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210304111416.GC12944@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=akurz@blala.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.