From: Phil Sutter <phil@nwl.cc>
To: u-boot@lists.denx.de
Subject: [PATCH 5/5] ds414: Add sample u-boot update command
Date: Thu, 4 Mar 2021 14:56:12 +0100 [thread overview]
Message-ID: <20210304135612.GO22016@orbyte.nwl.cc> (raw)
In-Reply-To: <8c511c9c-e5ed-0ea9-87b2-a19346da5e16@denx.de>
On Thu, Mar 04, 2021 at 02:34:53PM +0100, Stefan Roese wrote:
> On 04.03.21 14:28, Phil Sutter wrote:
> > On Thu, Mar 04, 2021 at 02:09:34PM +0100, Stefan Roese wrote:
> >> On 03.03.21 01:55, Phil Sutter wrote:
> >>> Signed-off-by: Phil Sutter <phil@nwl.cc>
> >>
> >> It's common practice to add some minimal text in the commit text,
> >> even for simple patches.
> >
> > I should learn to put less meaningful subjects in those cases so I have
> > an easier time finding something to write about in the description.
>
> ;)
>
> > Then
> > again, your question indicates I just didn't think hard enough.
>
> I agree that this "rule" is sometimes hard to understand. I myself
> am sometimes finding it stupid to write the same sentence twice.
I've seen enough projects where one-liners are absolutely acceptable,
I'd rather write redundant texts than accepting that coding "style".
Nothing worse than confusing code garnished with no description at all.
:)
[...]
> > BTW: I spent a while trying to make the DTB-defined partitions available
> > in sf command, but eventually gave up. Seems I need to have this
> > SPI->MTD mapping and still define partitions in environment. Not worth
> > spending cycles on though, I was just curious because 'help sf' mentions
> > partitions as offset alternatives.
>
> Not looking to hard into your issue here, but did you take a look at
> the "mtd" command? It's newer than the other flash related commands
> and can manage all kind of flash types (SPI NOR, NAND etc) in one
> place. And also integrated better into the MTD partitions IIRC.
Hmm, for some reason I assumed 'sf' is the optimal tool for SPI flashes.
I'll give it a try, thanks for the hint!
Thanks, Phil
next prev parent reply other threads:[~2021-03-04 13:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 0:55 [PATCH 0/5] Synology DS414 integration mini-review Phil Sutter
2021-03-03 0:55 ` [PATCH 1/5] ds414: Add a Kconfig defining some strings Phil Sutter
2021-03-04 13:00 ` Stefan Roese
2021-03-03 0:55 ` [PATCH 2/5] configs: ds414: Enable XHCI_PCI by default Phil Sutter
2021-03-04 13:00 ` Stefan Roese
2021-03-04 13:11 ` Phil Sutter
2021-03-05 20:03 ` [PATCH v2 " Phil Sutter
2021-03-06 8:15 ` Stefan Roese
2021-03-07 20:58 ` Phil Sutter
2021-03-08 6:34 ` Stefan Roese
2021-03-07 21:21 ` [PATCH v3 " Phil Sutter
2021-03-08 6:34 ` Stefan Roese
2021-03-03 0:55 ` [PATCH 3/5] board/Synology: Unify legacy kernel support Phil Sutter
2021-03-04 13:03 ` Stefan Roese
2021-03-04 13:11 ` Phil Sutter
2021-03-05 20:04 ` [PATCH v2 " Phil Sutter
2021-03-07 21:22 ` [PATCH v3 " Phil Sutter
2021-03-08 6:36 ` Stefan Roese
2021-03-03 0:55 ` [PATCH 4/5] ds414: Auto-populate env if appropriate Phil Sutter
2021-03-04 13:06 ` Stefan Roese
2021-03-04 13:20 ` Phil Sutter
2021-03-04 13:22 ` Stefan Roese
2021-03-05 20:05 ` [PATCH v2 " Phil Sutter
2021-03-03 0:55 ` [PATCH 5/5] ds414: Add sample u-boot update command Phil Sutter
2021-03-04 13:09 ` Stefan Roese
2021-03-04 13:28 ` Phil Sutter
2021-03-04 13:34 ` Stefan Roese
2021-03-04 13:56 ` Phil Sutter [this message]
2021-03-05 20:05 ` [PATCH v2 " Phil Sutter
2021-04-08 8:52 ` [PATCH 0/5] Synology DS414 integration mini-review Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304135612.GO22016@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.