From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7789CC433E6 for ; Thu, 4 Mar 2021 23:20:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33FD364FE3 for ; Thu, 4 Mar 2021 23:20:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33FD364FE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E2FB6EA88; Thu, 4 Mar 2021 23:20:21 +0000 (UTC) Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0865B6EA88 for ; Thu, 4 Mar 2021 23:20:19 +0000 (UTC) Received: by mail-pl1-x632.google.com with SMTP id a24so216213plm.11 for ; Thu, 04 Mar 2021 15:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BDAhVL6wLP9xE6Ae/kz68nSPm1bB9OfmCVC762Iy0sQ=; b=VAF9dFmBRjgsUgge9Qfdi/fx4I196F2rtVlBxmfloWQcKsFx0Ohhh86UkuQPTl85Sr Ph2eCaVFDXlVw6hshYuyKZcvffBhmbMWP3pMQQljJ13ucG9jIjOHXvW0+a0lJJyc4DpD j3G6QQyfD7On1IB6317wC8D/7pzX4jHMhKWJk2BYZcNv25VoeXL6A7r3pRgYp3o43dof UCMCzyyX9N8Lns5Ycep2tXdqulzOVCHx2wOaunUDySxEVjYiwoefivMpPz4cEnvKqJtr tKPNqeIYQH/jFBtq4eHvxMGIcwvOKgR/aGZHUOSWc/Ptrf1v5csFxb6GIziC+Vp5d58T zkWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BDAhVL6wLP9xE6Ae/kz68nSPm1bB9OfmCVC762Iy0sQ=; b=F+9rTM9GCrV4bKrUbhKG+SoCaaL4+mI0S65VJQCF488eVN/t4k8Qtw5h6G2OxJSzCz 3OAq+v7AgDFNKAhzffow4d6kXZXBLhkPCjE9af5+B4oHbzkzfNmGVCSgn9OBWrfz36TC aJyM/O80VopDyLTSk2uCpMaC8taiZgclP+sj0XJik4FhH7zYlnnUaWD/8FPdvG23j2i9 weI0yojXpaUilSItkI8VR1H+EBYPjwUzrL95yLsnPP9+LWOIqncH20T7n5KYoVVCVqow /850TWSbk//Ptq/0FsdIGgJ46ZDPEyPusbfNp2qqB55FqWua/ZsbZZITPdjpEiBI13Qv bbWQ== X-Gm-Message-State: AOAM530m5PhdAe4wlZqOZnB/74Mrnu5Wy8JpJzl+7d5bBGc268y3P2T9 KCfH9K+cP/pICknpk7A3x3U6qQ== X-Google-Smtp-Source: ABdhPJwp99E/EUxAulMiCQS4Ao2Fiu1PPZ4ZTnj7wchTGh8r5Pg2AiqLSP40UXYFh40cR4tGdwEkRQ== X-Received: by 2002:a17:902:b48b:b029:e3:7808:aab4 with SMTP id y11-20020a170902b48bb02900e37808aab4mr5951588plr.54.1614900019600; Thu, 04 Mar 2021 15:20:19 -0800 (PST) Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id u66sm429290pfc.72.2021.03.04.15.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 15:20:18 -0800 (PST) From: John Stultz To: lkml Subject: [PATCH v8 3/5] dma-buf: heaps: Add deferred-free-helper library code Date: Thu, 4 Mar 2021 23:20:09 +0000 Message-Id: <20210304232011.1479036-4-john.stultz@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210304232011.1479036-1-john.stultz@linaro.org> References: <20210304232011.1479036-1-john.stultz@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Sandeep Patil , Ezequiel Garcia , Robin Murphy , James Jones , Liam Mark , Laura Abbott , Chris Goldsworthy , Hridya Valsaraju , =?UTF-8?q?=C3=98rjan=20Eide?= , linux-media@vger.kernel.org, Suren Baghdasaryan , Christian Koenig , Daniel Mentz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" VGhpcyBwYXRjaCBwcm92aWRlcyBpbmZyYXN0cnVjdHVyZSBmb3IgZGVmZXJyaW5nIGJ1ZmZlciBm cmVlcy4KClRoaXMgaXMgYSBmZWF0dXJlIElPTiBwcm92aWRlZCB3aGljaCB3aGVuIHVzZWQgd2l0 aCBzb21lIGZvcm0Kb2YgYSBwYWdlIHBvb2wsIHByb3ZpZGVzIGEgbmljZSBwZXJmb3JtYW5jZSBi b29zdCBpbiBhbgphbGxvY2F0aW9uIG1pY3JvYmVuY2htYXJrLiBUaGUgcmVhc29uIGl0IGhlbHBz IGlzIGl0IGFsbG93cyB0aGUKcGFnZS16ZXJvaW5nIHRvIGJlIGRvbmUgb3V0IG9mIHRoZSBub3Jt YWwgYWxsb2NhdGlvbi9mcmVlIHBhdGgsCmFuZCBwdXNoZWQgb2ZmIHRvIGEga3RocmVhZC4KCkFz IG5vdCBhbGwgaGVhcHMgd2lsbCBmaW5kIHRoaXMgdXNlZnVsLCBpdHMgaW1wbGVtZW50ZWQgYXMK YSBvcHRpb25hbCBoZWxwZXIgbGlicmFyeSB0aGF0IGhlYXBzIGNhbiB1dGlsaXplLgoKQ2M6IERh bmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KQ2M6IENocmlzdGlhbiBLb2VuaWcgPGNocmlz dGlhbi5rb2VuaWdAYW1kLmNvbT4KQ2M6IFN1bWl0IFNlbXdhbCA8c3VtaXQuc2Vtd2FsQGxpbmFy by5vcmc+CkNjOiBMaWFtIE1hcmsgPGxtYXJrQGNvZGVhdXJvcmEub3JnPgpDYzogQ2hyaXMgR29s ZHN3b3J0aHkgPGNnb2xkc3dvQGNvZGVhdXJvcmEub3JnPgpDYzogTGF1cmEgQWJib3R0IDxsYWJi b3R0QGtlcm5lbC5vcmc+CkNjOiBCcmlhbiBTdGFya2V5IDxCcmlhbi5TdGFya2V5QGFybS5jb20+ CkNjOiBIcmlkeWEgVmFsc2FyYWp1IDxocmlkeWFAZ29vZ2xlLmNvbT4KQ2M6IFN1cmVuIEJhZ2hk YXNhcnlhbiA8c3VyZW5iQGdvb2dsZS5jb20+CkNjOiBTYW5kZWVwIFBhdGlsIDxzc3BhdGlsQGdv b2dsZS5jb20+CkNjOiBEYW5pZWwgTWVudHogPGRhbmllbG1lbnR6QGdvb2dsZS5jb20+CkNjOiDD mHJqYW4gRWlkZSA8b3JqYW4uZWlkZUBhcm0uY29tPgpDYzogUm9iaW4gTXVycGh5IDxyb2Jpbi5t dXJwaHlAYXJtLmNvbT4KQ2M6IEV6ZXF1aWVsIEdhcmNpYSA8ZXplcXVpZWxAY29sbGFib3JhLmNv bT4KQ2M6IFNpbW9uIFNlciA8Y29udGFjdEBlbWVyc2lvbi5mcj4KQ2M6IEphbWVzIEpvbmVzIDxq YWpvbmVzQG52aWRpYS5jb20+CkNjOiBsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmcKQ2M6IGRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKU2lnbmVkLW9mZi1ieTogSm9obiBTdHVsdHog PGpvaG4uc3R1bHR6QGxpbmFyby5vcmc+Ci0tLQp2MjoKKiBGaXggc2xlZXAgaW4gYXRvbWljIGlz c3VlIGZyb20gdXNpbmcgYSBtdXRleCwgYnkgc3dpdGNoaW5nCiAgdG8gYSBzcGlubG9jayBhcyBS ZXBvcnRlZC1ieToga2VybmVsIHRlc3Qgcm9ib3QgPG9saXZlci5zYW5nQGludGVsLmNvbT4KKiBD bGVhbnVwIEFQSSB0byB1c2UgYSByZWFzb24gZW51bSBmb3IgY2xhcml0eSBhbmQgYWRkIHNvbWUg ZG9jdW1lbnRhdGlvbgogIGNvbW1lbnRzIGFzIHN1Z2dlc3RlZCBieSBTdXJlbiBCYWdoZGFzYXJ5 YW4uCnYzOgoqIE1pbm9yIHR3ZWFrcyBzbyBpdCBjYW4gYmUgYnVpbHQgYXMgYSBtb2R1bGUKKiBB IGZldyBzbWFsbCBmaXh1cHMgc3VnZ2VzdGVkIGJ5IERhbmllbCBNZW50egp2NDoKKiBUd2VhayBm cm9tIERhbmllbCBNZW50eiB0byBtYWtlIHN1cmUgdGhlIHNocmlua2VyCiAgY291bnQvZnJlZWQg dmFsdWVzIGFyZSB0cmFja2VkIGluIHBhZ2VzIG5vdCBieXRlcwp2NToKKiBGaXggdXAgcGFnZSBj b3VudCB0cmFja2luZyBhcyBzdWdnZXN0ZWQgYnkgU3VyZW4gQmFnaGRhc2FyeWFuCnY3OgoqIFJl d29yayBhY2NvdW50aW5nIHRvIHVzZSBucl9wYWdlcyByYXRoZXIgdGhlbiBzaXplLCBhcyBzdWdn ZXN0ZWQKICBieSBTdXJlbiBCYWdoZGFzYXJ5YW4KLS0tCiBkcml2ZXJzL2RtYS1idWYvaGVhcHMv S2NvbmZpZyAgICAgICAgICAgICAgICB8ICAgMyArCiBkcml2ZXJzL2RtYS1idWYvaGVhcHMvTWFr ZWZpbGUgICAgICAgICAgICAgICB8ICAgMSArCiBkcml2ZXJzL2RtYS1idWYvaGVhcHMvZGVmZXJy ZWQtZnJlZS1oZWxwZXIuYyB8IDEzOCArKysrKysrKysrKysrKysrKysrCiBkcml2ZXJzL2RtYS1i dWYvaGVhcHMvZGVmZXJyZWQtZnJlZS1oZWxwZXIuaCB8ICA1NSArKysrKysrKwogNCBmaWxlcyBj aGFuZ2VkLCAxOTcgaW5zZXJ0aW9ucygrKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZG1h LWJ1Zi9oZWFwcy9kZWZlcnJlZC1mcmVlLWhlbHBlci5jCiBjcmVhdGUgbW9kZSAxMDA2NDQgZHJp dmVycy9kbWEtYnVmL2hlYXBzL2RlZmVycmVkLWZyZWUtaGVscGVyLmgKCmRpZmYgLS1naXQgYS9k cml2ZXJzL2RtYS1idWYvaGVhcHMvS2NvbmZpZyBiL2RyaXZlcnMvZG1hLWJ1Zi9oZWFwcy9LY29u ZmlnCmluZGV4IGE1ZWVmMDZjNDIyNi4uZjdhZWY4YmM3MTE5IDEwMDY0NAotLS0gYS9kcml2ZXJz L2RtYS1idWYvaGVhcHMvS2NvbmZpZworKysgYi9kcml2ZXJzL2RtYS1idWYvaGVhcHMvS2NvbmZp ZwpAQCAtMSwzICsxLDYgQEAKK2NvbmZpZyBETUFCVUZfSEVBUFNfREVGRVJSRURfRlJFRQorCXRy aXN0YXRlCisKIGNvbmZpZyBETUFCVUZfSEVBUFNfU1lTVEVNCiAJYm9vbCAiRE1BLUJVRiBTeXN0 ZW0gSGVhcCIKIAlkZXBlbmRzIG9uIERNQUJVRl9IRUFQUwpkaWZmIC0tZ2l0IGEvZHJpdmVycy9k bWEtYnVmL2hlYXBzL01ha2VmaWxlIGIvZHJpdmVycy9kbWEtYnVmL2hlYXBzL01ha2VmaWxlCmlu ZGV4IDk3NDQ2Nzc5MTAzMi4uNGU3ODM5ODc1NjE1IDEwMDY0NAotLS0gYS9kcml2ZXJzL2RtYS1i dWYvaGVhcHMvTWFrZWZpbGUKKysrIGIvZHJpdmVycy9kbWEtYnVmL2hlYXBzL01ha2VmaWxlCkBA IC0xLDMgKzEsNCBAQAogIyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAorb2JqLSQo Q09ORklHX0RNQUJVRl9IRUFQU19ERUZFUlJFRF9GUkVFKSArPSBkZWZlcnJlZC1mcmVlLWhlbHBl ci5vCiBvYmotJChDT05GSUdfRE1BQlVGX0hFQVBTX1NZU1RFTSkJKz0gc3lzdGVtX2hlYXAubwog b2JqLSQoQ09ORklHX0RNQUJVRl9IRUFQU19DTUEpCQkrPSBjbWFfaGVhcC5vCmRpZmYgLS1naXQg YS9kcml2ZXJzL2RtYS1idWYvaGVhcHMvZGVmZXJyZWQtZnJlZS1oZWxwZXIuYyBiL2RyaXZlcnMv ZG1hLWJ1Zi9oZWFwcy9kZWZlcnJlZC1mcmVlLWhlbHBlci5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMC4uZTE5YzhiNjhkZmViCi0tLSAvZGV2L251bGwKKysrIGIvZHJp dmVycy9kbWEtYnVmL2hlYXBzL2RlZmVycmVkLWZyZWUtaGVscGVyLmMKQEAgLTAsMCArMSwxMzgg QEAKKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wCisvKgorICogRGVmZXJyZWQg ZG1hYnVmIGZyZWVpbmcgaGVscGVyCisgKgorICogQ29weXJpZ2h0IChDKSAyMDIwIExpbmFybywg THRkLgorICoKKyAqIEJhc2VkIG9uIHRoZSBJT04gcGFnZSBwb29sIGNvZGUKKyAqIENvcHlyaWdo dCAoQykgMjAxMSBHb29nbGUsIEluYy4KKyAqLworCisjaW5jbHVkZSA8bGludXgvZnJlZXplci5o PgorI2luY2x1ZGUgPGxpbnV4L2xpc3QuaD4KKyNpbmNsdWRlIDxsaW51eC9zbGFiLmg+CisjaW5j bHVkZSA8bGludXgvc3dhcC5oPgorI2luY2x1ZGUgPGxpbnV4L3NjaGVkL3NpZ25hbC5oPgorCisj aW5jbHVkZSAiZGVmZXJyZWQtZnJlZS1oZWxwZXIuaCIKKworc3RhdGljIExJU1RfSEVBRChmcmVl X2xpc3QpOworc3RhdGljIHNpemVfdCBsaXN0X25yX3BhZ2VzOword2FpdF9xdWV1ZV9oZWFkX3Qg ZnJlZWxpc3Rfd2FpdHF1ZXVlOworc3RydWN0IHRhc2tfc3RydWN0ICpmcmVlbGlzdF90YXNrOwor c3RhdGljIERFRklORV9TUElOTE9DSyhmcmVlX2xpc3RfbG9jayk7CisKK3ZvaWQgZGVmZXJyZWRf ZnJlZShzdHJ1Y3QgZGVmZXJyZWRfZnJlZWxpc3RfaXRlbSAqaXRlbSwKKwkJICAgdm9pZCAoKmZy ZWUpKHN0cnVjdCBkZWZlcnJlZF9mcmVlbGlzdF9pdGVtKiwKKwkJCQllbnVtIGRmX3JlYXNvbiks CisJCSAgIHNpemVfdCBucl9wYWdlcykKK3sKKwl1bnNpZ25lZCBsb25nIGZsYWdzOworCisJSU5J VF9MSVNUX0hFQUQoJml0ZW0tPmxpc3QpOworCWl0ZW0tPm5yX3BhZ2VzID0gbnJfcGFnZXM7CisJ aXRlbS0+ZnJlZSA9IGZyZWU7CisKKwlzcGluX2xvY2tfaXJxc2F2ZSgmZnJlZV9saXN0X2xvY2ss IGZsYWdzKTsKKwlsaXN0X2FkZCgmaXRlbS0+bGlzdCwgJmZyZWVfbGlzdCk7CisJbGlzdF9ucl9w YWdlcyArPSBucl9wYWdlczsKKwlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZmcmVlX2xpc3RfbG9j aywgZmxhZ3MpOworCXdha2VfdXAoJmZyZWVsaXN0X3dhaXRxdWV1ZSk7Cit9CitFWFBPUlRfU1lN Qk9MX0dQTChkZWZlcnJlZF9mcmVlKTsKKworc3RhdGljIHNpemVfdCBmcmVlX29uZV9pdGVtKGVu dW0gZGZfcmVhc29uIHJlYXNvbikKK3sKKwl1bnNpZ25lZCBsb25nIGZsYWdzOworCXNpemVfdCBu cl9wYWdlczsKKwlzdHJ1Y3QgZGVmZXJyZWRfZnJlZWxpc3RfaXRlbSAqaXRlbTsKKworCXNwaW5f bG9ja19pcnFzYXZlKCZmcmVlX2xpc3RfbG9jaywgZmxhZ3MpOworCWlmIChsaXN0X2VtcHR5KCZm cmVlX2xpc3QpKSB7CisJCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmZyZWVfbGlzdF9sb2NrLCBm bGFncyk7CisJCXJldHVybiAwOworCX0KKwlpdGVtID0gbGlzdF9maXJzdF9lbnRyeSgmZnJlZV9s aXN0LCBzdHJ1Y3QgZGVmZXJyZWRfZnJlZWxpc3RfaXRlbSwgbGlzdCk7CisJbGlzdF9kZWwoJml0 ZW0tPmxpc3QpOworCW5yX3BhZ2VzID0gaXRlbS0+bnJfcGFnZXM7CisJbGlzdF9ucl9wYWdlcyAt PSBucl9wYWdlczsKKwlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZmcmVlX2xpc3RfbG9jaywgZmxh Z3MpOworCisJaXRlbS0+ZnJlZShpdGVtLCByZWFzb24pOworCXJldHVybiBucl9wYWdlczsKK30K Kworc3RhdGljIHVuc2lnbmVkIGxvbmcgZ2V0X2ZyZWVsaXN0X25yX3BhZ2VzKHZvaWQpCit7CisJ dW5zaWduZWQgbG9uZyBucl9wYWdlczsKKwl1bnNpZ25lZCBsb25nIGZsYWdzOworCisJc3Bpbl9s b2NrX2lycXNhdmUoJmZyZWVfbGlzdF9sb2NrLCBmbGFncyk7CisJbnJfcGFnZXMgPSBsaXN0X25y X3BhZ2VzOworCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmZyZWVfbGlzdF9sb2NrLCBmbGFncyk7 CisJcmV0dXJuIG5yX3BhZ2VzOworfQorCitzdGF0aWMgdW5zaWduZWQgbG9uZyBmcmVlbGlzdF9z aHJpbmtfY291bnQoc3RydWN0IHNocmlua2VyICpzaHJpbmtlciwKKwkJCQkJICAgc3RydWN0IHNo cmlua19jb250cm9sICpzYykKK3sKKwlyZXR1cm4gZ2V0X2ZyZWVsaXN0X25yX3BhZ2VzKCk7Cit9 CisKK3N0YXRpYyB1bnNpZ25lZCBsb25nIGZyZWVsaXN0X3Nocmlua19zY2FuKHN0cnVjdCBzaHJp bmtlciAqc2hyaW5rZXIsCisJCQkJCSAgc3RydWN0IHNocmlua19jb250cm9sICpzYykKK3sKKwl1 bnNpZ25lZCBsb25nIHRvdGFsX2ZyZWVkID0gMDsKKworCWlmIChzYy0+bnJfdG9fc2NhbiA9PSAw KQorCQlyZXR1cm4gMDsKKworCXdoaWxlICh0b3RhbF9mcmVlZCA8IHNjLT5ucl90b19zY2FuKSB7 CisJCXNpemVfdCBwYWdlc19mcmVlZCA9IGZyZWVfb25lX2l0ZW0oREZfVU5ERVJfUFJFU1NVUkUp OworCisJCWlmICghcGFnZXNfZnJlZWQpCisJCQlicmVhazsKKworCQl0b3RhbF9mcmVlZCArPSBw YWdlc19mcmVlZDsKKwl9CisKKwlyZXR1cm4gdG90YWxfZnJlZWQ7Cit9CisKK3N0YXRpYyBzdHJ1 Y3Qgc2hyaW5rZXIgZnJlZWxpc3Rfc2hyaW5rZXIgPSB7CisJLmNvdW50X29iamVjdHMgPSBmcmVl bGlzdF9zaHJpbmtfY291bnQsCisJLnNjYW5fb2JqZWN0cyA9IGZyZWVsaXN0X3Nocmlua19zY2Fu LAorCS5zZWVrcyA9IERFRkFVTFRfU0VFS1MsCisJLmJhdGNoID0gMCwKK307CisKK3N0YXRpYyBp bnQgZGVmZXJyZWRfZnJlZV90aHJlYWQodm9pZCAqZGF0YSkKK3sKKwl3aGlsZSAodHJ1ZSkgewor CQl3YWl0X2V2ZW50X2ZyZWV6YWJsZShmcmVlbGlzdF93YWl0cXVldWUsCisJCQkJICAgICBnZXRf ZnJlZWxpc3RfbnJfcGFnZXMoKSA+IDApOworCisJCWZyZWVfb25lX2l0ZW0oREZfTk9STUFMKTsK Kwl9CisKKwlyZXR1cm4gMDsKK30KKworc3RhdGljIGludCBkZWZlcnJlZF9mcmVlbGlzdF9pbml0 KHZvaWQpCit7CisJbGlzdF9ucl9wYWdlcyA9IDA7CisKKwlpbml0X3dhaXRxdWV1ZV9oZWFkKCZm cmVlbGlzdF93YWl0cXVldWUpOworCWZyZWVsaXN0X3Rhc2sgPSBrdGhyZWFkX3J1bihkZWZlcnJl ZF9mcmVlX3RocmVhZCwgTlVMTCwKKwkJCQkgICAgIiVzIiwgImRtYWJ1Zi1kZWZlcnJlZC1mcmVl LXdvcmtlciIpOworCWlmIChJU19FUlIoZnJlZWxpc3RfdGFzaykpIHsKKwkJcHJfZXJyKCJDcmVh dGluZyB0aHJlYWQgZm9yIGRlZmVycmVkIGZyZWUgZmFpbGVkXG4iKTsKKwkJcmV0dXJuIC0xOwor CX0KKwlzY2hlZF9zZXRfbm9ybWFsKGZyZWVsaXN0X3Rhc2ssIDE5KTsKKworCXJldHVybiByZWdp c3Rlcl9zaHJpbmtlcigmZnJlZWxpc3Rfc2hyaW5rZXIpOworfQorbW9kdWxlX2luaXQoZGVmZXJy ZWRfZnJlZWxpc3RfaW5pdCk7CitNT0RVTEVfTElDRU5TRSgiR1BMIHYyIik7CisKZGlmZiAtLWdp dCBhL2RyaXZlcnMvZG1hLWJ1Zi9oZWFwcy9kZWZlcnJlZC1mcmVlLWhlbHBlci5oIGIvZHJpdmVy cy9kbWEtYnVmL2hlYXBzL2RlZmVycmVkLWZyZWUtaGVscGVyLmgKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwLi4xMTk0MDMyOGNlM2YKLS0tIC9kZXYvbnVsbAorKysgYi9k cml2ZXJzL2RtYS1idWYvaGVhcHMvZGVmZXJyZWQtZnJlZS1oZWxwZXIuaApAQCAtMCwwICsxLDU1 IEBACisvKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMCAqLworCisjaWZuZGVmIERF RkVSUkVEX0ZSRUVfSEVMUEVSX0gKKyNkZWZpbmUgREVGRVJSRURfRlJFRV9IRUxQRVJfSAorCisv KioKKyAqIGRmX3JlYXNvbiAtIGVudW0gZm9yIHJlYXNvbiB3aHkgaXRlbSB3YXMgZnJlZWQKKyAq CisgKiBUaGlzIHByb3ZpZGVzIGEgcmVhc29uIGZvciB3aHkgdGhlIGZyZWUgZnVuY3Rpb24gd2Fz IGNhbGxlZAorICogb24gdGhlIGl0ZW0uIFRoaXMgaXMgdXNlZnVsIHdoZW4gZGVmZXJyZWRfZnJl ZSBpcyB1c2VkIGluCisgKiBjb21iaW5hdGlvbiB3aXRoIGEgcGFnZXBvb2wsIHNvIHVuZGVyIHBy ZXNzdXJlIHRoZSBwYWdlIGNhbgorICogYmUgaW1tZWRpYXRlbHkgZnJlZWQuCisgKgorICogREZf Tk9STUFMOiAgICAgICAgIE5vcm1hbCBkZWZlcnJlZCBmcmVlCisgKgorICogREZfVU5ERVJfUFJF U1NVUkU6IEZyZWUgd2FzIGNhbGxlZCBiZWNhdXNlIHRoZSBzeXN0ZW0KKyAqICAgICAgICAgICAg ICAgICAgICBpcyB1bmRlciBtZW1vcnkgcHJlc3N1cmUuIFVzdWFsbHkKKyAqICAgICAgICAgICAg ICAgICAgICBmcm9tIGEgc2hyaW5rZXIuIEF2b2lkIGFsbG9jYXRpbmcKKyAqICAgICAgICAgICAg ICAgICAgICBtZW1vcnkgaW4gdGhlIGZyZWUgY2FsbCwgYXMgaXQgbWF5CisgKiAgICAgICAgICAg ICAgICAgICAgZmFpbC4KKyAqLworZW51bSBkZl9yZWFzb24geworCURGX05PUk1BTCwKKwlERl9V TkRFUl9QUkVTU1VSRSwKK307CisKKy8qKgorICogZGVmZXJyZWRfZnJlZWxpc3RfaXRlbSAtIGl0 ZW0gc3RydWN0dXJlIGZvciBkZWZlcnJlZCBmcmVlbGlzdAorICoKKyAqIFRoaXMgaXMgdG8gYmUg YWRkZWQgdG8gdGhlIHN0cnVjdHVyZSBmb3Igd2hhdGV2ZXIgeW91IHdhbnQgdG8KKyAqIGRlZmVy IGZyZWVpbmcgb24uCisgKgorICogQG5yX3BhZ2VzOiBudW1iZXIgb2YgcGFnZXMgdXNlZCBieSBp dGVtIHRvIGJlIGZyZWVkCisgKiBAZnJlZTogZnVuY3Rpb24gcG9pbnRlciB0byBiZSBjYWxsZWQg d2hlbiBmcmVlaW5nIHRoZSBpdGVtCisgKiBAbGlzdDogbGlzdCBlbnRyeSBmb3IgdGhlIGRlZmVy cmVkIGxpc3QKKyAqLworc3RydWN0IGRlZmVycmVkX2ZyZWVsaXN0X2l0ZW0geworCXNpemVfdCBu cl9wYWdlczsKKwl2b2lkICgqZnJlZSkoc3RydWN0IGRlZmVycmVkX2ZyZWVsaXN0X2l0ZW0gKmks CisJCSAgICAgZW51bSBkZl9yZWFzb24gcmVhc29uKTsKKwlzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7 Cit9OworCisvKioKKyAqIGRlZmVycmVkX2ZyZWUgLSBjYWxsIHRvIGFkZCBpdGVtIHRvIHRoZSBk ZWZlcnJlZCBmcmVlIGxpc3QKKyAqCisgKiBAaXRlbTogUG9pbnRlciB0byBkZWZlcnJlZF9mcmVl bGlzdF9pdGVtIGZpZWxkIG9mIGEgc3RydWN0dXJlCisgKiBAZnJlZTogRnVuY3Rpb24gcG9pbnRl ciB0byB0aGUgZnJlZSBjYWxsCisgKiBAbnJfcGFnZXM6IG51bWJlciBvZiBwYWdlcyB0byBiZSBm cmVlZAorICovCit2b2lkIGRlZmVycmVkX2ZyZWUoc3RydWN0IGRlZmVycmVkX2ZyZWVsaXN0X2l0 ZW0gKml0ZW0sCisJCSAgIHZvaWQgKCpmcmVlKShzdHJ1Y3QgZGVmZXJyZWRfZnJlZWxpc3RfaXRl bSAqaSwKKwkJCQllbnVtIGRmX3JlYXNvbiByZWFzb24pLAorCQkgICBzaXplX3QgbnJfcGFnZXMp OworI2VuZGlmCi0tIAoyLjI1LjEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93514C43381 for ; Thu, 4 Mar 2021 23:20:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EA0B64DFF for ; Thu, 4 Mar 2021 23:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233086AbhCDXUW (ORCPT ); Thu, 4 Mar 2021 18:20:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233075AbhCDXUV (ORCPT ); Thu, 4 Mar 2021 18:20:21 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09586C061574 for ; Thu, 4 Mar 2021 15:20:20 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id l18so420128pji.3 for ; Thu, 04 Mar 2021 15:20:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BDAhVL6wLP9xE6Ae/kz68nSPm1bB9OfmCVC762Iy0sQ=; b=VAF9dFmBRjgsUgge9Qfdi/fx4I196F2rtVlBxmfloWQcKsFx0Ohhh86UkuQPTl85Sr Ph2eCaVFDXlVw6hshYuyKZcvffBhmbMWP3pMQQljJ13ucG9jIjOHXvW0+a0lJJyc4DpD j3G6QQyfD7On1IB6317wC8D/7pzX4jHMhKWJk2BYZcNv25VoeXL6A7r3pRgYp3o43dof UCMCzyyX9N8Lns5Ycep2tXdqulzOVCHx2wOaunUDySxEVjYiwoefivMpPz4cEnvKqJtr tKPNqeIYQH/jFBtq4eHvxMGIcwvOKgR/aGZHUOSWc/Ptrf1v5csFxb6GIziC+Vp5d58T zkWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BDAhVL6wLP9xE6Ae/kz68nSPm1bB9OfmCVC762Iy0sQ=; b=dRWKSwUx4ZwmrdxUYfzsoLPdNDtXf4CX/Ic/LYW/rK5xM8oJPEr6x4AeciqDLEYLnw 1TgLRDXIYPAN7hEsW8OhgJ8R0cyWVk5dGiZ9kV2EqYV6lNbxBAQfDX2Mb+vkuAl4qGyO 5k1CBsvReRCJGkkzDHiZMOLGKorPBAcc3L2N9mWGHTTTDrcuqqWGzfr+EU96IcTYeZS7 TluSZSMeWRK6pT0/6XQoBBRVoa2PqpvTq1267xPOzoyFP0TeoKjVJh9IfEmiOMkso9qn KE2mEwUFwc9SG4NG7sQ6af52QztA7JZZTDGYVo1cTN92tM0HxvT1proi6m/2BUP8Xcsw knkg== X-Gm-Message-State: AOAM530Su2LvIB/t+yZlgrn1ko7rJFvngMaJsu5ErwgDmf+VNMlklgiy qfBHRjLGMdg9bN5uNmy19JKD0g== X-Google-Smtp-Source: ABdhPJwp99E/EUxAulMiCQS4Ao2Fiu1PPZ4ZTnj7wchTGh8r5Pg2AiqLSP40UXYFh40cR4tGdwEkRQ== X-Received: by 2002:a17:902:b48b:b029:e3:7808:aab4 with SMTP id y11-20020a170902b48bb02900e37808aab4mr5951588plr.54.1614900019600; Thu, 04 Mar 2021 15:20:19 -0800 (PST) Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id u66sm429290pfc.72.2021.03.04.15.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 15:20:18 -0800 (PST) From: John Stultz To: lkml Cc: John Stultz , Daniel Vetter , Christian Koenig , Sumit Semwal , Liam Mark , Chris Goldsworthy , Laura Abbott , Brian Starkey , Hridya Valsaraju , Suren Baghdasaryan , Sandeep Patil , Daniel Mentz , =?UTF-8?q?=C3=98rjan=20Eide?= , Robin Murphy , Ezequiel Garcia , Simon Ser , James Jones , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v8 3/5] dma-buf: heaps: Add deferred-free-helper library code Date: Thu, 4 Mar 2021 23:20:09 +0000 Message-Id: <20210304232011.1479036-4-john.stultz@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210304232011.1479036-1-john.stultz@linaro.org> References: <20210304232011.1479036-1-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This patch provides infrastructure for deferring buffer frees. This is a feature ION provided which when used with some form of a page pool, provides a nice performance boost in an allocation microbenchmark. The reason it helps is it allows the page-zeroing to be done out of the normal allocation/free path, and pushed off to a kthread. As not all heaps will find this useful, its implemented as a optional helper library that heaps can utilize. Cc: Daniel Vetter Cc: Christian Koenig Cc: Sumit Semwal Cc: Liam Mark Cc: Chris Goldsworthy Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Ørjan Eide Cc: Robin Murphy Cc: Ezequiel Garcia Cc: Simon Ser Cc: James Jones Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: John Stultz --- v2: * Fix sleep in atomic issue from using a mutex, by switching to a spinlock as Reported-by: kernel test robot * Cleanup API to use a reason enum for clarity and add some documentation comments as suggested by Suren Baghdasaryan. v3: * Minor tweaks so it can be built as a module * A few small fixups suggested by Daniel Mentz v4: * Tweak from Daniel Mentz to make sure the shrinker count/freed values are tracked in pages not bytes v5: * Fix up page count tracking as suggested by Suren Baghdasaryan v7: * Rework accounting to use nr_pages rather then size, as suggested by Suren Baghdasaryan --- drivers/dma-buf/heaps/Kconfig | 3 + drivers/dma-buf/heaps/Makefile | 1 + drivers/dma-buf/heaps/deferred-free-helper.c | 138 +++++++++++++++++++ drivers/dma-buf/heaps/deferred-free-helper.h | 55 ++++++++ 4 files changed, 197 insertions(+) create mode 100644 drivers/dma-buf/heaps/deferred-free-helper.c create mode 100644 drivers/dma-buf/heaps/deferred-free-helper.h diff --git a/drivers/dma-buf/heaps/Kconfig b/drivers/dma-buf/heaps/Kconfig index a5eef06c4226..f7aef8bc7119 100644 --- a/drivers/dma-buf/heaps/Kconfig +++ b/drivers/dma-buf/heaps/Kconfig @@ -1,3 +1,6 @@ +config DMABUF_HEAPS_DEFERRED_FREE + tristate + config DMABUF_HEAPS_SYSTEM bool "DMA-BUF System Heap" depends on DMABUF_HEAPS diff --git a/drivers/dma-buf/heaps/Makefile b/drivers/dma-buf/heaps/Makefile index 974467791032..4e7839875615 100644 --- a/drivers/dma-buf/heaps/Makefile +++ b/drivers/dma-buf/heaps/Makefile @@ -1,3 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 +obj-$(CONFIG_DMABUF_HEAPS_DEFERRED_FREE) += deferred-free-helper.o obj-$(CONFIG_DMABUF_HEAPS_SYSTEM) += system_heap.o obj-$(CONFIG_DMABUF_HEAPS_CMA) += cma_heap.o diff --git a/drivers/dma-buf/heaps/deferred-free-helper.c b/drivers/dma-buf/heaps/deferred-free-helper.c new file mode 100644 index 000000000000..e19c8b68dfeb --- /dev/null +++ b/drivers/dma-buf/heaps/deferred-free-helper.c @@ -0,0 +1,138 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Deferred dmabuf freeing helper + * + * Copyright (C) 2020 Linaro, Ltd. + * + * Based on the ION page pool code + * Copyright (C) 2011 Google, Inc. + */ + +#include +#include +#include +#include +#include + +#include "deferred-free-helper.h" + +static LIST_HEAD(free_list); +static size_t list_nr_pages; +wait_queue_head_t freelist_waitqueue; +struct task_struct *freelist_task; +static DEFINE_SPINLOCK(free_list_lock); + +void deferred_free(struct deferred_freelist_item *item, + void (*free)(struct deferred_freelist_item*, + enum df_reason), + size_t nr_pages) +{ + unsigned long flags; + + INIT_LIST_HEAD(&item->list); + item->nr_pages = nr_pages; + item->free = free; + + spin_lock_irqsave(&free_list_lock, flags); + list_add(&item->list, &free_list); + list_nr_pages += nr_pages; + spin_unlock_irqrestore(&free_list_lock, flags); + wake_up(&freelist_waitqueue); +} +EXPORT_SYMBOL_GPL(deferred_free); + +static size_t free_one_item(enum df_reason reason) +{ + unsigned long flags; + size_t nr_pages; + struct deferred_freelist_item *item; + + spin_lock_irqsave(&free_list_lock, flags); + if (list_empty(&free_list)) { + spin_unlock_irqrestore(&free_list_lock, flags); + return 0; + } + item = list_first_entry(&free_list, struct deferred_freelist_item, list); + list_del(&item->list); + nr_pages = item->nr_pages; + list_nr_pages -= nr_pages; + spin_unlock_irqrestore(&free_list_lock, flags); + + item->free(item, reason); + return nr_pages; +} + +static unsigned long get_freelist_nr_pages(void) +{ + unsigned long nr_pages; + unsigned long flags; + + spin_lock_irqsave(&free_list_lock, flags); + nr_pages = list_nr_pages; + spin_unlock_irqrestore(&free_list_lock, flags); + return nr_pages; +} + +static unsigned long freelist_shrink_count(struct shrinker *shrinker, + struct shrink_control *sc) +{ + return get_freelist_nr_pages(); +} + +static unsigned long freelist_shrink_scan(struct shrinker *shrinker, + struct shrink_control *sc) +{ + unsigned long total_freed = 0; + + if (sc->nr_to_scan == 0) + return 0; + + while (total_freed < sc->nr_to_scan) { + size_t pages_freed = free_one_item(DF_UNDER_PRESSURE); + + if (!pages_freed) + break; + + total_freed += pages_freed; + } + + return total_freed; +} + +static struct shrinker freelist_shrinker = { + .count_objects = freelist_shrink_count, + .scan_objects = freelist_shrink_scan, + .seeks = DEFAULT_SEEKS, + .batch = 0, +}; + +static int deferred_free_thread(void *data) +{ + while (true) { + wait_event_freezable(freelist_waitqueue, + get_freelist_nr_pages() > 0); + + free_one_item(DF_NORMAL); + } + + return 0; +} + +static int deferred_freelist_init(void) +{ + list_nr_pages = 0; + + init_waitqueue_head(&freelist_waitqueue); + freelist_task = kthread_run(deferred_free_thread, NULL, + "%s", "dmabuf-deferred-free-worker"); + if (IS_ERR(freelist_task)) { + pr_err("Creating thread for deferred free failed\n"); + return -1; + } + sched_set_normal(freelist_task, 19); + + return register_shrinker(&freelist_shrinker); +} +module_init(deferred_freelist_init); +MODULE_LICENSE("GPL v2"); + diff --git a/drivers/dma-buf/heaps/deferred-free-helper.h b/drivers/dma-buf/heaps/deferred-free-helper.h new file mode 100644 index 000000000000..11940328ce3f --- /dev/null +++ b/drivers/dma-buf/heaps/deferred-free-helper.h @@ -0,0 +1,55 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef DEFERRED_FREE_HELPER_H +#define DEFERRED_FREE_HELPER_H + +/** + * df_reason - enum for reason why item was freed + * + * This provides a reason for why the free function was called + * on the item. This is useful when deferred_free is used in + * combination with a pagepool, so under pressure the page can + * be immediately freed. + * + * DF_NORMAL: Normal deferred free + * + * DF_UNDER_PRESSURE: Free was called because the system + * is under memory pressure. Usually + * from a shrinker. Avoid allocating + * memory in the free call, as it may + * fail. + */ +enum df_reason { + DF_NORMAL, + DF_UNDER_PRESSURE, +}; + +/** + * deferred_freelist_item - item structure for deferred freelist + * + * This is to be added to the structure for whatever you want to + * defer freeing on. + * + * @nr_pages: number of pages used by item to be freed + * @free: function pointer to be called when freeing the item + * @list: list entry for the deferred list + */ +struct deferred_freelist_item { + size_t nr_pages; + void (*free)(struct deferred_freelist_item *i, + enum df_reason reason); + struct list_head list; +}; + +/** + * deferred_free - call to add item to the deferred free list + * + * @item: Pointer to deferred_freelist_item field of a structure + * @free: Function pointer to the free call + * @nr_pages: number of pages to be freed + */ +void deferred_free(struct deferred_freelist_item *item, + void (*free)(struct deferred_freelist_item *i, + enum df_reason reason), + size_t nr_pages); +#endif -- 2.25.1