From: "Denys Dmytriyenko" <denis@denix.org>
To: Nishanth Menon <nm@ti.com>
Cc: meta-ti <meta-ti@yoctoproject.org>,
"Bajjuri, Praneeth" <praneeth@ti.com>
Subject: Re: [meta-ti] [PATCH dunfell] ti-rtos: Fix J7200 builds by dropping evm
Date: Fri, 5 Mar 2021 03:13:16 -0500 [thread overview]
Message-ID: <20210305081316.GS4892@denix.org> (raw)
In-Reply-To: <166963B5CCB828E3.16425@lists.yoctoproject.org>
On Fri, Mar 05, 2021 at 03:06:08AM -0500, Denys Dmytriyenko wrote:
> On Fri, Mar 05, 2021 at 12:45:53AM -0600, Nishanth Menon wrote:
> > On 00:41-20210305, Nishanth Menon wrote:
> > > "evm" prefix messes up the pattern matchup for J7200 and falls back into
> > > default, as a result, we attempt to pull [1] instead of [2].
> > >
> > > [1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_12/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> > > [2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> >
> > ^^ above link should have been:
> > https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_10_firmware.tar.xz
> >
> > if you need me to send a v2 with fixups, i can.. or if that is the only
> > comment, then might be helpful to get a fixup while applying..
>
> I'm failing to see the issue here...
>
> Of course, using "_j7200" instead of "_j7200-evm" is more preferred to cover
Actually, that is wishful thinking - there's NO "j7200" SOC_FAMILY set up at
all! So this patch is completely incorrect, as there's no such override as
_j7200, only _j7200-evm. Something else is going on...
> other variants, like potential "j7200-hs-evm", but when building for j7200-evm
> should result in the same output. I would need to reproduce it - any another
> pointers?
>
>
> > > Fixes: 77cdfa9f6560 ("ti-rtos: Update metadata and versions for RTOS firmware")
> > > Signed-off-by: Nishanth Menon <nm@ti.com>
> > > ---
> > > recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > > index ed62b876e4db..dffd51abda66 100644
> > > --- a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > > +++ b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > > @@ -31,7 +31,7 @@ DEFAULT_RTOS_VERSION_DOT_am65xx = "07.03.00.10"
> > >
> > > DEFAULT_RTOS_SOC = "undefined"
> > > DEFAULT_RTOS_SOC_j7 = "j721e"
> > > -DEFAULT_RTOS_SOC_j7200-evm = "j7200"
> > > +DEFAULT_RTOS_SOC_j7200 = "j7200"
> > > DEFAULT_RTOS_SOC_am65xx = "am65xx"
> > > DEFAULT_RTOS_SOC_am64xx = "am64x"
> > >
> > > @@ -47,7 +47,7 @@ DEFAULT_FIRMWARE_URL_k3 = "${CORESDK_RTOS_WEBLINK}/${DEFAULT_FIRMWARE_FILE}"
> > >
> > > DEFAULT_FIRMWARE_SHA256SUM = "unknown"
> > > DEFAULT_FIRMWARE_SHA256SUM_j7 = "69cc16c30c895fe813002bd7bdb3d30e6ca622d86b008a6bf6e2a24b86550969"
> > > -DEFAULT_FIRMWARE_SHA256SUM_j7200-evm = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
> > > +DEFAULT_FIRMWARE_SHA256SUM_j7200 = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
> > > DEFAULT_FIRMWARE_SHA256SUM_am65xx = "aa121c10d3099dd61ef898717245ecee25b501170607c9a95afd741e05783a5d"
> > > DEFAULT_FIRMWARE_SHA256SUM_am64xx = "9e9efeef0b1dbb101de97e58cfda8bf052a697f2ea635fdf6ca5158fffdc212b"
> > >
> > > --
> > > 2.25.1.377.g2d2118b814c1
> > >
> >
> > --
> > Regards,
> > Nishanth Menon
> > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
> >
next prev parent reply other threads:[~2021-03-05 8:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 6:41 [PATCH dunfell] ti-rtos: Fix J7200 builds by dropping evm Nishanth Menon
2021-03-05 6:45 ` Nishanth Menon
2021-03-05 8:06 ` Denys Dmytriyenko
[not found] ` <166963B5CCB828E3.16425@lists.yoctoproject.org>
2021-03-05 8:13 ` Denys Dmytriyenko [this message]
2021-03-05 7:04 ` [EXTERNAL,dunfell] " Lokesh Vutla
2021-03-05 7:11 ` Nishanth Menon
2021-03-05 7:44 ` Lokesh Vutla
2021-03-05 8:23 ` Denys Dmytriyenko
2021-03-05 9:08 ` Lokesh Vutla
2021-03-05 17:14 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305081316.GS4892@denix.org \
--to=denis@denix.org \
--cc=meta-ti@yoctoproject.org \
--cc=nm@ti.com \
--cc=praneeth@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.