From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lI9JG-0005X2-9d for mharc-grub-devel@gnu.org; Fri, 05 Mar 2021 07:11:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lI9JE-0005Wu-4M for grub-devel@gnu.org; Fri, 05 Mar 2021 07:11:56 -0500 Received: from de-smtp-delivery-102.mimecast.com ([194.104.109.102]:23536) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lI9J8-0001dR-8U for grub-devel@gnu.org; Fri, 05 Mar 2021 07:11:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1614946307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+shJYWSXBd3PZ25snmLwcu+obwaYiBym7jZYBcKIGXM=; b=NyAdnJsrrQ0BSPYUE66OqVsOlgiVwpQXzFhy7DQKDPITpHfaT9BMvQfk5tPKpU6KaWV2JC UZ7N1CWZWE/UxHby5oWeV7Y99BQv1MEIfdbEewHmi9d46JCUJV1SANvoICtL9Lca65qmJq eNB4ZDoBflxz3i+HVYhZGqUzH5jI0JE= Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-5-EehL00aXMM-fFdadzg75Eg-1; Fri, 05 Mar 2021 13:11:45 +0100 X-MC-Unique: EehL00aXMM-fFdadzg75Eg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PO+0yXzYvZQb1kP63AxlIOy1TFgYIrU9FrDSL+n51IqWihcQ5mJurE0A1br6Oj42bVda74kSu+WcGbf6Pm+wJ46LDpwvwKYvrrFG8eqk3Huj7a41cpMA9grPt0/5SH2pWGONyudfmEphLVIcxarSucxDqGShV9NEavK1HFuGI4cUAH8MpNNt75VKFiCjlvvHIJ1Pbj9RQCZAdr+TSilDqdyU6MC+7ZrRPa2ZXPIv4advsLleEYKY2tGKY5NPvdtkzAlJD0yUWuFEtWEKlAOH2FKD+hTry8phldJR68c0Q30IYCDBbwv1JTumYdyBe2noZ/1eMcA9hkf4vdaneZvT6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fFoGPAlC97T7NOo9Kc2gROTykCXUhjQjgcokJ+RY77s=; b=Et5b8IOf1YT36AXo5o7mAMci3KMsfVcirfqHQUGSMhYjpwO21MvDxOoH+qlu/rCJZkWnd+lHMsQ9PicVJUAPn0cx4lAQZmfHyhTZQhL+sMStS6I0OHY+VFKLGNocvNrZZkv6Fgq/ZgAZc8iZZh27MYbeEP0v0RbNBRmuvLw0pBOjgoXjYv4BCY02NXZGSsaRG7dFMNSiVneQrGEZmIh/Nqr53DayVPNuuZOae4Yzr/MC/8ls37jNDacBYTZFtp5RAvbhXN/bsGaK8kdektUhtysvdwQYWMMvGpIdpmoigPfj5mqHm5mayPuBQ5jiDWVvMxWPr60DjlbHwXy27M++Vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=suse.com; Received: from VI1PR04MB4991.eurprd04.prod.outlook.com (2603:10a6:803:57::28) by VI1PR0402MB3614.eurprd04.prod.outlook.com (2603:10a6:803:b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.28; Fri, 5 Mar 2021 12:11:43 +0000 Received: from VI1PR04MB4991.eurprd04.prod.outlook.com ([fe80::28b7:e423:c3d7:7ccf]) by VI1PR04MB4991.eurprd04.prod.outlook.com ([fe80::28b7:e423:c3d7:7ccf%6]) with mapi id 15.20.3890.032; Fri, 5 Mar 2021 12:11:43 +0000 From: Michael Chang To: The development of GNU GRUB Subject: [PATCH] Add chainloaded image as shim's verifiable object Date: Fri, 5 Mar 2021 20:11:26 +0800 Message-ID: <20210305121126.23928-1-mchang@suse.com> X-Mailer: git-send-email 2.26.2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-Originating-IP: [2001:b011:30d0:3140:37e2:a559:41a5:49df] X-ClientProxiedBy: HK2PR06CA0007.apcprd06.prod.outlook.com (2603:1096:202:2e::19) To VI1PR04MB4991.eurprd04.prod.outlook.com (2603:10a6:803:57::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mercury.nue.suse.com (2001:b011:30d0:3140:37e2:a559:41a5:49df) by HK2PR06CA0007.apcprd06.prod.outlook.com (2603:1096:202:2e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Fri, 5 Mar 2021 12:11:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 156cb692-2b87-4120-67aa-08d8dfcfd71d X-MS-TrafficTypeDiagnostic: VI1PR0402MB3614: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j3DETu3a5oiEYV482dbzOGf2ndd1zx+bsSniSn5uOzSxAa1OXPzCCfNaNDc1F+90+UKeELXq8SgBiCxZHyGAbODUBNyBvSUi2yO9OTMSn/8Ki8omlI1vOneiPWK1L5Vv+vc1IPSQlsGloVs8DFe+uoAO2004YoMm39dJRNFLQ6crKaU2Bqy+FvmXi7yHNfY+Rsn9fJeSjgyw7IYDrKRPmcopqQGOxgTThz/y9R9dOc+33v3oSD2ArNfGJ77KochQdrO00D7Qey6s6a2uj/SHGlUr8Wk2T0M2FKq9DVfDXfyn4IZERCN99FOvxpUO4ldyY4mFiPgOEq8ViOAQrNVhG7k4ojteWZXG9jR8nQ8gzcrum4yM1aEizk0TUROjbVCTna1e58l5sFhsdQME6KKJmdp4YNMfmg0tOBNkL2rPGL2ZEZuIm3CmnAK2Su8bj/qGeu/jPcSZtkSo2rYuCzH29OpHYXosUFsE05SNb/9CXUl3fanIWDqBLkmCEGEq+xuU3yGLWtvNoT1hL9ADg0IHcQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB4991.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(366004)(396003)(39860400002)(136003)(45080400002)(8676002)(83380400001)(6916009)(8936002)(66556008)(36756003)(86362001)(2906002)(478600001)(186003)(2616005)(6666004)(5660300002)(316002)(1076003)(6486002)(66946007)(52116002)(16526019)(7696005)(66476007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?H3Tt6m+X4fClof1jWyu/zJw5L8dPWnDaoDfov17Fg3oELMHDjzHgIQSrZpxt?= =?us-ascii?Q?sccyrxtoofJAmpML/eNpAtEL48oa6GxVs4yIH/5K5ewsE10MOml1r5JBPspr?= =?us-ascii?Q?u0XvUq/ehzglTh/KLIQZFjBiUHTVst6hMxgm6jk9JVJAOLnWg53mgw7otfc4?= =?us-ascii?Q?Yi+VOptjrY88m0rXTobWTs+tRvcENTvNcFqIqlOp6bBpru0coGhar5thJZZ5?= =?us-ascii?Q?FwkGEfDqNR4qyxHAJwhWVFgGg2kxNwB3PtzPdo0Jjlphp9dS5FhcX1UiNQi7?= =?us-ascii?Q?9vBs3n+oowW1cWej6s7zRxval0jxrLSC2J7BXgeMb79POeajpevRccQHDNni?= =?us-ascii?Q?r2DvLlWFHTqRdcsSE2HVwxvGFR97FyauQkUXHLaEDPubSR3QIkZwCioF+KEt?= =?us-ascii?Q?yOYCmk9dF5rs9Ecrp0+r831VKn3P5atcPEp0XrN3xpF1x/RT/DE6f5EURda1?= =?us-ascii?Q?JEmY4bt0ffc78mPtX7LnS7zHFBqMBpy8c7P7IdPeNfmtPHkxQXk7PZvjm7Ho?= =?us-ascii?Q?eFODIAsfnC0ytePc32sHKFe9ep3yrcj9EIgXSGMBPnzzekb9IgEjoy+i2cqV?= =?us-ascii?Q?UlU35OEW18I22ctkcSqUKedbtQ1X9ruaSNmb/Mp4u3LcYNGVvSjitUbZEiS3?= =?us-ascii?Q?SkhtYkanTfhNOhX7wtRE/6G+ZZw2R/EDEZejYb07abkBdVMBTnyi1AoNc7G9?= =?us-ascii?Q?94M8fB0WNLJmyIURw6JVvJNR7EgyzBfdXZB/vFKIp4Psi+Gchl9O9b9FJhie?= =?us-ascii?Q?bFWf2hy+KsVs4eGOWfYHwKKvrKuNuwvqRbjezT5l4Kb52R9vUFy5Xv+Ftzxd?= =?us-ascii?Q?2tL+f61jAlAQwmyApX0BtggEavlo3SMiLNr6oIVZieImYGvFt0SW1Qf9IK/y?= =?us-ascii?Q?C9O2SdjgXfki61+J6YQMRtMZFbuPiNNi2GX5nL9chb4nyd71zP/ktuxXpgik?= =?us-ascii?Q?waz3l4YpejeQozR9hnaN6M2Z7ygR6uksqlrz4ISPutptl7HsfsPzN2ZRy2mF?= =?us-ascii?Q?cUacu+fjF/5UYY3agTsCiS1/WMK19292JBw/aHJN3WET6ONuQ09AQjYsScf3?= =?us-ascii?Q?gQKSzDosDZLWPUfmL9xUKiIvN7vzvK7x30gxdZXLBMw0mCR1XeKQW+LEq2zZ?= =?us-ascii?Q?3SJmmR9tdbF7+h904KIy7LbVXoZkMCynSEHy6xY6+6FiRx4mxYK1OvxwPmIE?= =?us-ascii?Q?CQ66yKfUw1gzoUvAfAXYc/Tz6CJakbvzEP7g1TkNnSf8VWL0baZo7ey6baor?= =?us-ascii?Q?CAZ0OsawF72yKzxZXenYV+n8Z0eIISmsUGiHTI+gOHF7Ebh8zar3JsBrWK6e?= =?us-ascii?Q?DJmqIbHTN/tYgL1wQ2mL9l8BQWsKgQgUNTMZImnDGd1lGT4omxGA7XNXUBtl?= =?us-ascii?Q?eUanEZEPaJbnJIQ8sVUQJYjTyg9a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 156cb692-2b87-4120-67aa-08d8dfcfd71d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4991.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 12:11:43.4857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kyzrg9NjUQ3SfuoCh8g9xylYDdrKxS8O3h+/1dJL+gnMoG/1HkWUaPd7cFQE2WJz X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3614 Received-SPF: pass client-ip=194.104.109.102; envelope-from=mchang@suse.com; helo=de-smtp-delivery-102.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 12:11:56 -0000 While attempting to dual boot Microsoft Windows with efi chainloader, it failed with below error when secure boot was enabled. error ../../grub-core/kern/verifiers.c:119:verification requested but nobody cares: /EFI/Microsoft/Boot/bootmgfw.efi. It is a regression, as previously it worked without problem. It turns out chainloading image has been locked down introduced by 578c95298 kern: Add lockdown support However we should consider it as verifiable object to shim to allow booting in secure boot enabled mode. The chainloaded image could also have trusted signature signed by vendor with their pubkey cert in db. For that matters it's usage should not be locked down in secure boot, and instead use shim to validate it's signature before running it. Signed-off-by: Michael Chang --- grub-core/kern/efi/sb.c | 1 + grub-core/kern/lockdown.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/kern/efi/sb.c b/grub-core/kern/efi/sb.c index 41dadcd14..96d237722 100644 --- a/grub-core/kern/efi/sb.c +++ b/grub-core/kern/efi/sb.c @@ -129,6 +129,7 @@ shim_lock_verifier_init (grub_file_t io __attribute__ (= (unused)), case GRUB_FILE_TYPE_BSD_KERNEL: case GRUB_FILE_TYPE_XNU_KERNEL: case GRUB_FILE_TYPE_PLAN9_KERNEL: + case GRUB_FILE_TYPE_EFI_CHAINLOADED_IMAGE: *flags =3D GRUB_VERIFY_FLAGS_SINGLE_CHUNK; =20 /* Fall through. */ diff --git a/grub-core/kern/lockdown.c b/grub-core/kern/lockdown.c index 0bc70fd42..e1fd1c1e2 100644 --- a/grub-core/kern/lockdown.c +++ b/grub-core/kern/lockdown.c @@ -48,7 +48,6 @@ lockdown_verifier_init (grub_file_t io __attribute__ ((un= used)), case GRUB_FILE_TYPE_PXECHAINLOADER: case GRUB_FILE_TYPE_PCCHAINLOADER: case GRUB_FILE_TYPE_COREBOOT_CHAINLOADER: - case GRUB_FILE_TYPE_EFI_CHAINLOADED_IMAGE: case GRUB_FILE_TYPE_ACPI_TABLE: case GRUB_FILE_TYPE_DEVICE_TREE_IMAGE: *flags =3D GRUB_VERIFY_FLAGS_DEFER_AUTH; --=20 2.26.2