From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lIApO-0005xj-0G for mharc-grub-devel@gnu.org; Fri, 05 Mar 2021 08:49:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIApM-0005xb-2g for grub-devel@gnu.org; Fri, 05 Mar 2021 08:49:12 -0500 Received: from de-smtp-delivery-102.mimecast.com ([194.104.109.102]:21153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lIApI-00049N-Sb for grub-devel@gnu.org; Fri, 05 Mar 2021 08:49:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1614952147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MMFpSEgqKg9WoD/BoDJBw5f3ojPPR9WyjRGu2Y4EOI8=; b=Zk0HZOcvdH7tCfbwzGvXUa6zEV3ph+sMAfSN+7rdbYCYO9Upx4J2DxWccYgO+sqpLya6of mqA4YTfe9FUEjoYd/3E2MMYMgQrjD53a3YnSjhFvj5xLjtqFBLAoRB+X9VnCY6shIfgWhx RLrPKgM15WgG5rrnV0lqV81R0W1Y6YQ= Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2057.outbound.protection.outlook.com [104.47.8.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-25-XH4CQJNUN6S_ZD38ZmCZ5g-1; Fri, 05 Mar 2021 14:49:05 +0100 X-MC-Unique: XH4CQJNUN6S_ZD38ZmCZ5g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Znd85LZLkTENPfH/Nixmv3mfdu5qo4yigjazMVVkuH3A0VkKl/A4bRaV2TUm9ZbKiXn2lnm4Eu2qZngbGHhuyID3BxgTvytLmJs2LHhXdKyvqfPgnatHX3/wFOb8ZGvgOirygxWqwD37ftWskcrOPVl7bgUtuddio9jAxdRRJ6jFWKFk+Sajp9SwwEvreWsbGqqtIUQ78UT6RE8uX2nPQunBv8Q9Qk3cgZO0HYd7Vh1FQcNj+6SzISrE1FoKxyDHh+Kpdz9fnuw3r0ClQoVBUql0MAPJdOtj1pMrwXqcgpZJB3+B8TT1N5yRPYL5gI37aKq5CRjBWtekBmSHBbdd1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K7ww8WWonYrqwdOKFMf7OUWo5U5CIZSoWhYSqU/9M+Y=; b=dp4Bj508vhguoJnftYJq87z0HG6Z6Gux0ukSPPyszHJnJYcu76lRKLxP2aJJ93OZZZRqvp9zF1V6makHVE+AdwQa0SUjHmMG6bP8YpdQJw92DCRiVvhVfrTQ6S/iVN1caM34kmphqWR2QrK9O0KFwIzf5rqBEpgTyiI0cYuxdM8W/qRV5nJ3hdkWCsi2Z9zU779oIlg3ihBDefm/mgHravza+TtAUzCthm5u1hi4gMhNNMqdUMYw/UPt0Fef6glPw5gxTMVlAUWOTPv33b67cphtzkGO7GapX57RqWrOVVHgqw4yIymcPAj604Tcpuq68popUjR+EQCP65kiugryOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=suse.com; Received: from VI1PR04MB4991.eurprd04.prod.outlook.com (2603:10a6:803:57::28) by VI1PR04MB4781.eurprd04.prod.outlook.com (2603:10a6:803:51::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.28; Fri, 5 Mar 2021 13:49:04 +0000 Received: from VI1PR04MB4991.eurprd04.prod.outlook.com ([fe80::28b7:e423:c3d7:7ccf]) by VI1PR04MB4991.eurprd04.prod.outlook.com ([fe80::28b7:e423:c3d7:7ccf%6]) with mapi id 15.20.3890.032; Fri, 5 Mar 2021 13:49:04 +0000 From: Michael Chang To: The development of GNU GRUB Subject: [PATCH v2] Add chainloaded image as shim's verifiable object Date: Fri, 5 Mar 2021 21:48:53 +0800 Message-ID: <20210305134853.32586-1-mchang@suse.com> X-Mailer: git-send-email 2.26.2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-Originating-IP: [2001:b011:30d0:3140:37e2:a559:41a5:49df] X-ClientProxiedBy: HK2PR0401CA0008.apcprd04.prod.outlook.com (2603:1096:202:2::18) To VI1PR04MB4991.eurprd04.prod.outlook.com (2603:10a6:803:57::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mercury.nue.suse.com (2001:b011:30d0:3140:37e2:a559:41a5:49df) by HK2PR0401CA0008.apcprd04.prod.outlook.com (2603:1096:202:2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Fri, 5 Mar 2021 13:49:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14f562f6-c254-4bc0-d489-08d8dfdd70ba X-MS-TrafficTypeDiagnostic: VI1PR04MB4781: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mzkumMjz6TiDYTSP6ZvnMRzHXSXaXet1SajPDBQVj/b+TjWKwmIeoFbfRb3zDlCIQTWG6r+RJ8SDMfhCSDplHiPavabha7MLO7/EwKVhZbohOCtOXQmplnEz9J8xDr6XAMZHqEmBJ+LFdD/F9jiR4q9Sc2I+7AYJua/vmfX7QL2ar4RGrtKWV2xtl5RYhnixWKRvWcI6ZnDz+foQcK0leBothlMxNdDKIuosGlk/Dj0NqbQHkQHws4mnuYMhS/Bgmj7t7EOrCJCBfLMUz/WtWQPcbpmp1kcKjxmxIZnNg2Vq5WXAXvZ1Mava/BgC6Qu63nPFUPhJHe6fvA1scDc4hjgaiTLMZMNk356J83dFTT5TH/Zoyns3kSAtxzcSPiyjiWosdqgjCloDi3N4ULvxdIXR6P9WKWx4OIz2ZIysbSxql6ylT72X5Fnkv6hgOexnwz7UQ0B9/7X8CPjtkO41SlbuNLgl1o/L+bIO6F7YIL6WygfmwYnFZTIiDAT2q0TbEpTgzkHRxptiVn5QtEv2LQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB4991.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(346002)(396003)(376002)(39860400002)(136003)(45080400002)(5660300002)(16526019)(7696005)(83380400001)(36756003)(6666004)(52116002)(2616005)(478600001)(2906002)(1076003)(66556008)(316002)(86362001)(8676002)(66476007)(66946007)(6486002)(6916009)(186003)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?VgVx/nyjVbD+EktFWuy7foXHMHKv/3kGPqh+lZkV1vM2U7A5amP/6Dtr1OJI?= =?us-ascii?Q?miQ1f5BWNi86AdNNhmnvk6+vinDGJXVU6Y/33vNFgdTEbT6NSoLmjvGYNDYU?= =?us-ascii?Q?aPsbv6BEMG/XXBhEpjc6FKEnik9uubvVKQY6DcGD2/nNED/yiX8Wd0S5qrF4?= =?us-ascii?Q?nzQ3ytRCutyCya+76cRXqooM9+KjZ2xYvIB+kgwq+R2Wq1K+ySu629qMmtAX?= =?us-ascii?Q?JW68SQe5PpgIqdxyesCpMBd9MX6IaEa4FNzfmwtBjJNFFtH7nx04NFH1mBBl?= =?us-ascii?Q?/P6L9J8Npr11tYs4kk/L6bwoPEjT+Co8W4RuVOfUjZr1hUr9PxQpJ/SeeYiY?= =?us-ascii?Q?VqhGsA3AEE1af58yXJaXuTDZg8VQU+d9ycHGdlOSK6SlK90X6j+cDBJn+Bbw?= =?us-ascii?Q?SXDEE6sm3e+Y/1uxn75yTTDKyLocFsiu1IryPvaoqdMYGNJ6va2fhnqwQKr8?= =?us-ascii?Q?PeuTMSUsBt072f+/3L3vcbIXe3gh0qrItFV7ZLfTXrgfyx/ksR2H2CGeH8Sw?= =?us-ascii?Q?lJ2eGXhUZg5sz57Y03bdWdQN1zCfQMoUohIegq1/AbR7l4zyZwrbI0lkK4Y+?= =?us-ascii?Q?P1k953gjyRWcXBz5KG6qKrdfmRLLT+7BM6o9EkhSHT9dsiCQmg2YrgMID6G7?= =?us-ascii?Q?UE9nPMUgfKDpswVhdYKMNXkbf0khKGWmovMaTPa8lOT251kQaGp59IExrIp5?= =?us-ascii?Q?MVzrm6xLox2izBp3PSmsZprZvgNaMTAGRXHY7CBisnVxm0LIUCghpsUUVGb1?= =?us-ascii?Q?aJjoU07r5FzeIwJfUCPOPxBEM+x+jbmaDlHN9FAQk8lumaDe/0/UKz39puRi?= =?us-ascii?Q?dCwdLMSXCm4tp6yx3Mc1IiF5pzrwcD4KC+cssV7VofuIiM5TANDgRza0Gf5P?= =?us-ascii?Q?hH1d9UONX7uYgBpeIi9Mo3TiTx+xGGPaLEATnAc8+bQ7oT3rE6lzDJG16799?= =?us-ascii?Q?ELhhOR981K3maOKmJMSsKRkRNHrSIxGJa/lLq4PzGy1HRrIFLdr3VZkrjzaY?= =?us-ascii?Q?fMlLs+kOtnH4nGjxWbnqqmqwnuSCH0OxefeNBOH0x4f4hJ5lnLiDciZR9zGI?= =?us-ascii?Q?z866/FEC+NVNbbsVSZmyHrYzYxYwFsfhy6OdA+ap56RhNgpYJE1fO1gEmyh9?= =?us-ascii?Q?SOO+BLlReHzmUbxRR2dHwrB8LcKdatWtED2GkqugdbCqGc6yxbaKaEDVhZ2z?= =?us-ascii?Q?54JuMe/lKISxC3xQxb8Me8eAJ87JdV/9RDoaY9aZRk9C1LTA/QFFCnp/xPp+?= =?us-ascii?Q?N5azBLnH85fIIFhHXDo+n/GQ+6B5S7w24T5wXOnxqST61iDQq3pb2L9RjtFV?= =?us-ascii?Q?qZzOEu/FGTgz86fMxmF51+ik2HPZZztlC74EVDmAU+VEek4dtfTIhUAslVHP?= =?us-ascii?Q?fhEoxiN7gKBYKD6InG5dVvzeP2mc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14f562f6-c254-4bc0-d489-08d8dfdd70ba X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4991.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 13:49:04.6433 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +CCYNnWLY9LsKfeNXkSYqWGhckxUZR4KI+BcdTtOyXv/TeGqIbcJlego0caZrFQb X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4781 Received-SPF: pass client-ip=194.104.109.102; envelope-from=mchang@suse.com; helo=de-smtp-delivery-102.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 13:49:12 -0000 While attempting to dual boot Microsoft Windows with efi chainloader, it failed with below error when secure boot was enabled. error ../../grub-core/kern/verifiers.c:119:verification requested but nobody cares: /EFI/Microsoft/Boot/bootmgfw.efi. It is a regression, as previously it worked without problem. It turns out chainloading image has been locked down introduced by 578c95298 kern: Add lockdown support However we should consider it as verifiable object to shim to allow booting in secure boot enabled mode. The chainloaded image could also have trusted signature signed by vendor with their pubkey cert in db. For that matters it's usage should not be locked down in secure boot, and instead use shim to validate it's signature before running it. V2: Keep GRUB_FILE_TYPE_EFI_CHAINLOADED_IMAGE in the lockdown list as it ensures at least one verifer has validated the image. Signed-off-by: Michael Chang --- grub-core/kern/efi/sb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/grub-core/kern/efi/sb.c b/grub-core/kern/efi/sb.c index 41dadcd14..96d237722 100644 --- a/grub-core/kern/efi/sb.c +++ b/grub-core/kern/efi/sb.c @@ -129,6 +129,7 @@ shim_lock_verifier_init (grub_file_t io __attribute__ (= (unused)), case GRUB_FILE_TYPE_BSD_KERNEL: case GRUB_FILE_TYPE_XNU_KERNEL: case GRUB_FILE_TYPE_PLAN9_KERNEL: + case GRUB_FILE_TYPE_EFI_CHAINLOADED_IMAGE: *flags =3D GRUB_VERIFY_FLAGS_SINGLE_CHUNK; =20 /* Fall through. */ --=20 2.26.2