From: Corey Minyard <minyard@acm.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: Handle device properties with software node API
Date: Fri, 5 Mar 2021 10:28:08 -0600 [thread overview]
Message-ID: <20210305162808.GW507977@minyard.net> (raw)
In-Reply-To: <20210304090312.26827-1-heikki.krogerus@linux.intel.com>
On Thu, Mar 04, 2021 at 12:03:12PM +0300, Heikki Krogerus wrote:
> The old device property API is going to be removed.
> Replacing the device_add_properties() call with the software
> node API equivalent, device_create_managed_software_node().
Ok, this has been queued for next release.
Thanks,
-corey
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/char/ipmi/ipmi_plat_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_plat_data.c b/drivers/char/ipmi/ipmi_plat_data.c
> index 28471ff2a3a3e..747b51ae01a80 100644
> --- a/drivers/char/ipmi/ipmi_plat_data.c
> +++ b/drivers/char/ipmi/ipmi_plat_data.c
> @@ -102,7 +102,7 @@ struct platform_device *ipmi_platform_add(const char *name, unsigned int inst,
> goto err;
> }
> add_properties:
> - rv = platform_device_add_properties(pdev, pr);
> + rv = device_create_managed_software_node(&pdev->dev, pr, NULL);
> if (rv) {
> dev_err(&pdev->dev,
> "Unable to add hard-code properties: %d\n", rv);
> --
> 2.30.1
>
prev parent reply other threads:[~2021-03-05 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 9:03 [PATCH] ipmi: Handle device properties with software node API Heikki Krogerus
2021-03-05 16:28 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305162808.GW507977@minyard.net \
--to=minyard@acm.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.