From: Shawn Guo <shawnguo@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-arm-kernel@lists.infradead.org,
Christoph Niedermaier <cniedermaier@dh-electronics.com>,
Fabio Estevam <festevam@gmail.com>,
Ludwig Zenz <lzenz@dh-electronics.com>,
NXP Linux Team <linux-imx@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] ARM: dts: imx6q-dhcom: Add PU,VDD1P1,VDD2P5 regulators
Date: Sat, 6 Mar 2021 19:07:19 +0800 [thread overview]
Message-ID: <20210306110718.GX15865@dragon> (raw)
In-Reply-To: <678b6564-14c2-7085-8750-06bbc235ae8d@denx.de>
On Fri, Mar 05, 2021 at 12:19:25PM +0100, Marek Vasut wrote:
> On 3/5/21 9:39 AM, Shawn Guo wrote:
> > On Thu, Mar 04, 2021 at 01:07:32PM +0100, Marek Vasut wrote:
> > > On 3/4/21 8:56 AM, Shawn Guo wrote:
> > > > On Wed, Mar 03, 2021 at 03:04:07PM +0100, Marek Vasut wrote:
> > > > > On 3/3/21 1:56 PM, Shawn Guo wrote:
> > > > > > On Thu, Feb 04, 2021 at 12:54:03AM +0100, Marek Vasut wrote:
> > > > > > > Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1
> > > > > > > via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied
> > > > > > > from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs.
> > > > > > >
> > > > > > > Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2")
> > > > > >
> > > > > > It's more like an improvement or additions rather than fixes. I dropped
> > > > > > the tag and applied for -next.
> > > > >
> > > > > I would argue that describing SoC regulators correctly is a bugfix, since it
> > > > > can lead to stability issues of the SoC.
> > > >
> > > > Then resend the patch with details of the issue that it fixes.
> > >
> > > Can you please tell me what is missing in the original patch description
> > > that justifies dropping the Fixes: tag ? I would argue that fully describing
> > > CPU regulators in DT is a fix which should go through the stable tree and
> > > the original patch description is accurate.
> >
> > You claim that the patch fixes a stability issue, but commit log
> > mentions nothing about it.
>
> Correction, I claim it can lead to stability issues, so far none were
> observed to my knowledge. But I would argue a correct regulator setup in DT
> for a specific device is a bugfix and should go through stable tree. Please
> correct me if I'm wrong.
All I'm asking is that you resend the patch with commit log stating why
this is a bugfix and should go through stable tree, because it's not
obvious at least to me.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-06 11:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 23:54 [PATCH] ARM: dts: imx6q-dhcom: Add PU,VDD1P1,VDD2P5 regulators Marek Vasut
2021-03-03 12:56 ` Shawn Guo
2021-03-03 14:04 ` Marek Vasut
2021-03-04 7:56 ` Shawn Guo
2021-03-04 12:07 ` Marek Vasut
2021-03-05 8:39 ` Shawn Guo
2021-03-05 11:19 ` Marek Vasut
2021-03-06 11:07 ` Shawn Guo [this message]
2021-03-06 11:21 ` Shawn Guo
2021-03-06 16:17 ` Marek Vasut
2021-03-07 1:40 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210306110718.GX15865@dragon \
--to=shawnguo@kernel.org \
--cc=arnd@arndb.de \
--cc=cniedermaier@dh-electronics.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=lzenz@dh-electronics.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.