From: Vladimir Oltean <olteanv@gmail.com>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: dsa: Always react to global bridge attribute changes
Date: Sat, 6 Mar 2021 16:04:40 +0200 [thread overview]
Message-ID: <20210306140440.3uwmyji4smxdpgpm@skbuf> (raw)
In-Reply-To: <20210306140033.axpbtqamaruzzzew@skbuf>
On Sat, Mar 06, 2021 at 04:00:33PM +0200, Vladimir Oltean wrote:
> Hi Tobias,
>
> On Sat, Mar 06, 2021 at 01:24:55AM +0100, Tobias Waldekranz wrote:
> > This is the second attempt to provide a fix for the issue described in
> > 99b8202b179f, which was reverted in the previous commit.
> >
> > When a change is made to some global bridge attribute, such as VLAN
> > filtering, accept events where orig_dev is the bridge master netdev.
> >
> > Separate the validation of orig_dev based on whether the attribute in
> > question is global or per-port.
> >
> > Fixes: 5696c8aedfcc ("net: dsa: Don't offload port attributes on standalone ports")
> > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> > ---
>
> What do you think about this alternative?
Ah, wait, this won't work when offloading objects/attributes on a LAG.
Let me actually test your patch.
next prev parent reply other threads:[~2021-03-06 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 0:24 [PATCH net 0/2] net: dsa: Avoid VLAN config corruption Tobias Waldekranz
2021-03-06 0:24 ` [PATCH net 1/2] Revert "net: dsa: fix SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING getting ignored" Tobias Waldekranz
2021-03-06 0:24 ` [PATCH net 2/2] net: dsa: Always react to global bridge attribute changes Tobias Waldekranz
2021-03-06 14:00 ` Vladimir Oltean
2021-03-06 14:04 ` Vladimir Oltean [this message]
2021-03-06 18:17 ` Tobias Waldekranz
2021-03-07 0:58 ` Vladimir Oltean
2021-03-07 9:51 ` Tobias Waldekranz
2021-03-07 10:07 ` Vladimir Oltean
2021-03-06 0:41 ` [PATCH net 0/2] net: dsa: Avoid VLAN config corruption Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210306140440.3uwmyji4smxdpgpm@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.