From: Rob Herring <robh@kernel.org>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: jonas.gorski@gmail.com,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Maxime Ripard <maxime@cerno.tech>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Stefan Wahren <stefan.wahren@i2se.com>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mips: bmips: add BCM63268 timer reset definitions
Date: Sat, 6 Mar 2021 14:17:31 -0700 [thread overview]
Message-ID: <20210306211731.GA1217377@robh.at.kernel.org> (raw)
In-Reply-To: <20210225194201.17001-3-noltari@gmail.com>
On Thu, Feb 25, 2021 at 08:41:59PM +0100, Álvaro Fernández Rojas wrote:
> Add missing timer reset definitions for BCM63268.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> include/dt-bindings/reset/bcm63268-reset.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h
> index 6a6403a4c2d5..d87a7882782a 100644
> --- a/include/dt-bindings/reset/bcm63268-reset.h
> +++ b/include/dt-bindings/reset/bcm63268-reset.h
> @@ -23,4 +23,8 @@
> #define BCM63268_RST_PCIE_HARD 17
> #define BCM63268_RST_GPHY 18
>
> +#define BCM63268_TRST_SW 29
> +#define BCM63268_TRST_HW 30
> +#define BCM63268_TRST_POR 31
Numbering should be local to the provider, so shouldn't this be 0-2?
Unless these numbers correspond to something in the h/w (bit positions
for example).
> +
> #endif /* __DT_BINDINGS_RESET_BCM63268_H */
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-03-06 21:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 19:41 [PATCH 0/4] clk: add BCM63268 timer clock and reset Álvaro Fernández Rojas
2021-02-25 19:41 ` [PATCH 1/4] mips: bmips: add BCM63268 timer clock definitions Álvaro Fernández Rojas
2021-03-06 21:09 ` Rob Herring
2021-03-13 22:55 ` Stephen Boyd
2021-02-25 19:41 ` [PATCH 2/4] mips: bmips: add BCM63268 timer reset definitions Álvaro Fernández Rojas
2021-03-06 21:17 ` Rob Herring [this message]
2021-03-07 10:08 ` Álvaro Fernández Rojas
2021-03-09 19:21 ` Rob Herring
2021-02-25 19:42 ` [PATCH 3/4] dt-bindings: clock: Add BCM63268 timer binding Álvaro Fernández Rojas
2021-03-06 21:18 ` Rob Herring
2021-02-25 19:42 ` [PATCH 4/4] clk: bcm: Add BCM63268 timer clock and reset driver Álvaro Fernández Rojas
2021-03-04 6:22 ` kernel test robot
2021-03-13 22:48 ` Stephen Boyd
2021-03-14 1:43 ` Florian Fainelli
2021-03-13 22:54 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210306211731.GA1217377@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
--cc=noltari@gmail.com \
--cc=nsaenzjulienne@suse.de \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.