From: Shawn Guo <shawnguo@kernel.org>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Fabio Estevam <festevam@gmail.com>,
robh+dt@kernel.org, bruno.thomsen@gmail.com,
jan.tuerk@emtrion.com, linux-arm-kernel@lists.infradead.org,
Markus Niebel <Markus.Niebel@ew.tq-group.com>
Subject: Re: [PATCH 1/2] ARM: dts: imx7d-mba7: Remove unsupported property
Date: Mon, 8 Mar 2021 09:11:13 +0800 [thread overview]
Message-ID: <20210308011113.GR543@dragon> (raw)
In-Reply-To: <5da0bf4fb2d83fbf1a1cb400a51292aea89c980c.camel@ew.tq-group.com>
On Wed, Mar 03, 2021 at 10:38:08AM +0100, Matthias Schiffer wrote:
> On Tue, 2021-03-02 at 11:53 -0300, Fabio Estevam wrote:
> > 'disable-gpio' is not a valid property according to
> > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt.
> >
> > Remove the unsupported property.
> >
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Reviewed-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
>
>
> This is a remnant of linux-imx, which supports the property. On the
> MBa7x (and likely other boards in linux-imx that use this), the GPIO is
> connected to mPCIe pin 20 (wireless_disable#). Is there an intended way
> to control this pin, or should it just be left unconfigured or hogged?
>
> power-on-gpio seems to be obsolete too, I can't even find it in current
> linux-imx, except for one other i.MX7D-based DTS. I can send a patch to
> remove that as well, but it might take a while until I get to it.
Fabio,
While we are at it, could you resend to include 'power-on-gpio' cleanup
as well?
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-03-08 1:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 14:53 [PATCH 1/2] ARM: dts: imx7d-mba7: Remove unsupported property Fabio Estevam
2021-03-02 14:53 ` [PATCH 2/2] ARM: dts: imx6qdl-emcon: " Fabio Estevam
2021-03-02 19:55 ` [PATCH 1/2] ARM: dts: imx7d-mba7: " Bruno Thomsen
2021-03-03 9:38 ` Matthias Schiffer
2021-03-08 1:11 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308011113.GR543@dragon \
--to=shawnguo@kernel.org \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=bruno.thomsen@gmail.com \
--cc=festevam@gmail.com \
--cc=jan.tuerk@emtrion.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.