From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Qing Zhang <zhangqing@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h
Date: Mon, 8 Mar 2021 10:49:47 +0100 [thread overview]
Message-ID: <20210308094947.GA4924@alpha.franken.de> (raw)
In-Reply-To: <3a5481f9-d1d5-4439-9679-ad7615ba8009@www.fastmail.com>
On Sat, Mar 06, 2021 at 06:55:41PM +0800, Jiaxun Yang wrote:
>
>
> On Sat, Mar 6, 2021, at 5:53 PM, Thomas Bogendoerfer wrote:
> [...]
> > Just to understand you, you want
> >
> > arch/mips/include/asm/loongson/2ef
> > arch/mips/include/asm/loongson/32
> > arch/mips/include/asm/loongson/64
>
> Yeah it looks reasonable but from my point of view doing these movement
> brings no actual benefit :-(
oh it does for sure. There will no more build errors for non loogson
configs for things like
#include <loongson_regs.h>
because it will not work for loongson either. And it will be clear,
which of the 3 loongson.h is used. Which then gives chances for even
more cleanups.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-03-08 9:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 11:00 [PATCH 0/2] some cleanup code Qing Zhang
2021-03-04 11:00 ` [PATCH 1/2] MIPS: Loongson64: Remove unused sysconf members Qing Zhang
2021-03-05 2:32 ` Jiaxun Yang
2021-03-06 3:18 ` zhangqing
2021-03-12 10:28 ` Thomas Bogendoerfer
2021-03-04 11:00 ` [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h Qing Zhang
2021-03-05 2:32 ` Jiaxun Yang
2021-03-05 10:01 ` Philippe Mathieu-Daudé
2021-03-06 3:12 ` zhangqing
2021-03-06 8:03 ` Thomas Bogendoerfer
2021-03-06 8:57 ` zhangqing
2021-03-09 10:42 ` Thomas Bogendoerfer
2021-03-06 9:00 ` Jiaxun Yang
2021-03-06 9:53 ` Thomas Bogendoerfer
2021-03-06 10:55 ` Jiaxun Yang
2021-03-08 9:49 ` Thomas Bogendoerfer [this message]
2021-03-09 14:48 ` Jiaxun Yang
2021-03-12 10:28 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308094947.GA4924@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.