From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: linux-mips@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH] MIPS: vmlinux.lds.S: align raw appended dtb to 8 bytes
Date: Mon, 8 Mar 2021 11:55:50 +0100 [thread overview]
Message-ID: <20210308105550.GC6622@alpha.franken.de> (raw)
In-Reply-To: <20210307182301.20710-1-bjorn@mork.no>
On Sun, Mar 07, 2021 at 07:23:01PM +0100, Bjørn Mork wrote:
> The devicetree specification requires 8-byte alignment in
> memory. This is now enforced by libfdt since commit 79edff12060f
> ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9")
> which included the upstream commit 5e735860c478 ("libfdt: Check for
> 8-byte address alignment in fdt_ro_probe_()").
>
> This broke the MIPS raw appended DTBs which would be appended to
> the image immediately following the initramfs section. This ends
> with a 32bit size, resulting in a 4-byte alignment of the DTB.
>
> Fix by padding with zeroes to 8-bytes when MIPS_RAW_APPENDED_DTB
> is defined.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
> ---
> arch/mips/kernel/vmlinux.lds.S | 5 +++++
> 1 file changed, 5 insertions(+)
thank you for your patch, but there already was a fix for the problem
pending from Paul, which I've applied to mips-fixes a few minutes ago.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-03-08 10:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 18:23 [PATCH] MIPS: vmlinux.lds.S: align raw appended dtb to 8 bytes Bjørn Mork
2021-03-08 10:55 ` Thomas Bogendoerfer [this message]
2021-03-08 11:10 ` Bjørn Mork
2021-03-08 12:53 ` Thomas Bogendoerfer
2021-03-08 13:45 ` Bjørn Mork
2021-03-08 17:47 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308105550.GC6622@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=bjorn@mork.no \
--cc=frowand.list@gmail.com \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.