From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,FORGED_MUA_MOZILLA, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8197C433E0 for ; Tue, 9 Mar 2021 10:06:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6339165257 for ; Tue, 9 Mar 2021 10:06:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbhCIKGN (ORCPT ); Tue, 9 Mar 2021 05:06:13 -0500 Received: from correo.us.es ([193.147.175.20]:45242 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230159AbhCIKFv (ORCPT ); Tue, 9 Mar 2021 05:05:51 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 64FC75E4771 for ; Tue, 9 Mar 2021 11:05:46 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 51F7DDA78E for ; Tue, 9 Mar 2021 11:05:46 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 46BD8DA78D; Tue, 9 Mar 2021 11:05:46 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C6E2EDA704; Tue, 9 Mar 2021 11:05:43 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 09 Mar 2021 11:05:43 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id A8BF942DC6E3; Tue, 9 Mar 2021 11:05:43 +0100 (CET) Date: Tue, 9 Mar 2021 11:05:43 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arturo Borrero Gonzalez Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH conntrack-tools] conntrackd: set default hashtable buckets and max entries if not specified Message-ID: <20210309100543.GA30640@salvia> References: <20210308153254.15678-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mozilla/5.0 X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Mar 09, 2021 at 10:51:20AM +0100, Arturo Borrero Gonzalez wrote: > On 3/8/21 4:32 PM, Pablo Neira Ayuso wrote: > > Fall back to 65536 buckets and 262144 entries. > > > > It would be probably good to add code to autoadjust by reading > > /proc/sys/net/netfilter/nf_conntrack_buckets and > > /proc/sys/net/nf_conntrack_max. > > > > Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1491 > > Signed-off-by: Pablo Neira Ayuso > > --- > > src/read_config_yy.y | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > Thanks for the patch! > > Would it make sense to have all this logic in evaluate() in src/run.c? I think so. A patch to move it there would be fine. I suspect there might more missing sanity checks in the configuration file parser (options that are not set to default value, like hashsize and hashlimit).