From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C455C433DB for ; Tue, 9 Mar 2021 11:34:53 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D07E865208 for ; Tue, 9 Mar 2021 11:34:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D07E865208 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cUim32HwE9cU78dUVcFUr0aEg2sP4eowwrTbDPJiA/Y=; b=hGACf2P/G3kGpGPH+NEB/48I7 zTe1gE/sDpC70lm0QIaQ8Y/PNjnL4MnHu2ZCnNWoB/Lav0CLr40LkPbjs4/lH0XGrkdoSy6+Zl3/3 A7OTA/hVp6y6bVMYVnZhcCfFKpF9hMR4kjuUZNP2+03D6vHd408nx85+BAArKPj/f0EdjCuD+H+hf E5GxEQM1Xw2pAwMj/qk5sbphURXxJsRh6cNJs+ssO+CQvuX9+mA+Gk5ihHKyCWyaPLsPakseGjMMx PNl+L1fGLIZ783O/4IlUx7NRI66l2Mvuj8dluRAVkwAG9Cmy8KUK/QIFnGxppIHdAFSYEfUJe4D9J 9HgX4oc4w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJadS-004Ktv-4m; Tue, 09 Mar 2021 11:34:46 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJadJ-004Ksj-3U for linux-nvme@lists.infradead.org; Tue, 09 Mar 2021 11:34:44 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id EE3E568B05; Tue, 9 Mar 2021 12:34:34 +0100 (CET) Date: Tue, 9 Mar 2021 12:34:34 +0100 From: Christoph Hellwig To: Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, damien.lemoal@wdc.com Subject: Re: [PATCH V10 1/8] nvmet: trim args for nvmet_copy_ns_identifier() Message-ID: <20210309113434.GA9520@lst.de> References: <20210309045823.18545-1-chaitanya.kulkarni@wdc.com> <20210309045823.18545-2-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210309045823.18545-2-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_113440_124655_703DA689 X-CRM114-Status: UNSURE ( 8.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org This looks really strange to me. The copy function should just do the grunt work, while the policy should stay in the callers. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme