From: Jason Gunthorpe <jgg@nvidia.com>
To: "Zengtao (B)" <prime.zeng@hisilicon.com>
Cc: Peter Xu <peterx@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Kevin Tian <kevin.tian@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Michel Lespinasse <walken@google.com>,
Jann Horn <jannh@google.com>, Max Gurtovoy <mgurtovoy@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: 答复: [PATCH] vfio/pci: make the vfio_pci_mmap_fault reentrant
Date: Tue, 9 Mar 2021 08:46:09 -0400 [thread overview]
Message-ID: <20210309124609.GG2356281@nvidia.com> (raw)
In-Reply-To: <6b98461600f74f2385b9096203fa3611@hisilicon.com>
On Tue, Mar 09, 2021 at 03:49:09AM +0000, Zengtao (B) wrote:
> Hi guys:
>
> Thanks for the helpful comments, after rethinking the issue, I have proposed
> the following change:
> 1. follow_pte instead of follow_pfn.
Still no on follow_pfn, you don't need it once you use vmf_insert_pfn
> 2. vmf_insert_pfn loops instead of io_remap_pfn_range
> 3. proper undos when some call fails.
> 4. keep the bigger lock range to avoid unessary pte install.
Why do we need locks at all here?
Jason
next prev parent reply other threads:[~2021-03-09 12:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 11:11 [PATCH] vfio/pci: make the vfio_pci_mmap_fault reentrant Zeng Tao
2021-03-08 20:21 ` Alex Williamson
2021-03-08 22:56 ` Peter Xu
2021-03-09 3:49 ` 答复: " Zengtao (B)
2021-03-09 12:46 ` Jason Gunthorpe [this message]
2021-03-09 15:29 ` Alex Williamson
2021-03-09 16:40 ` Jason Gunthorpe
2021-03-09 18:47 ` Peter Xu
2021-03-09 19:26 ` Alex Williamson
2021-03-09 19:48 ` Peter Xu
2021-03-09 20:11 ` Alex Williamson
2021-03-09 21:00 ` Peter Xu
2021-03-09 21:43 ` Alex Williamson
2021-03-09 19:56 ` Alex Williamson
2021-03-09 23:45 ` Jason Gunthorpe
2021-03-10 6:23 ` Alex Williamson
2021-03-09 23:41 ` Jason Gunthorpe
2021-03-10 6:08 ` Alex Williamson
2021-03-11 3:32 ` 答复: " Zengtao (B)
2021-03-08 23:43 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309124609.GG2356281@nvidia.com \
--to=jgg@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=giovanni.cabiddu@intel.com \
--cc=jannh@google.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mgurtovoy@nvidia.com \
--cc=peterx@redhat.com \
--cc=prime.zeng@hisilicon.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.