From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA99FC433DB for ; Tue, 9 Mar 2021 15:03:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46D6C65243 for ; Tue, 9 Mar 2021 15:03:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46D6C65243 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M95PdkIhCCDT8pFQFY1/13F6IcPiro/b5pnqvnqrOqA=; b=dwn6SRinz77FslC2uQgqT/wol TrSnlmnB5uh5Hl4dfj5gq9srJah4ULQtJvnkhibyDlYvDkbW2AJXVj3SPHfFnepYGfyV1kqJBpGoV iUyLTxhc5w0qXK3pXMBMC8NHG+E84nPrIESWTnLeVI1DQCgDTvhlzIhwFi/Of6GN6ReSn0qpTjs+V 6fpILVa9ZR3UIHPO7t5Qc0TJEngnepgalMvsKU3j03/SSUDxSLgoTpF3TGSU+hes93ZpzShxN267Q 37YbB732ma4uEa0NKinsQWtT18G3nwEWHvXb/xZJzpZdyZAD/48NTNU1/HotQn67QqmyznYFPTOun YsvYOwYcA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJdtU-004uKc-Sa; Tue, 09 Mar 2021 15:03:32 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJdtO-004uJZ-Q7 for linux-nvme@lists.infradead.org; Tue, 09 Mar 2021 15:03:30 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 0444868B05; Tue, 9 Mar 2021 16:03:25 +0100 (CET) Date: Tue, 9 Mar 2021 16:03:24 +0100 From: Christoph Hellwig To: Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, damien.lemoal@wdc.com Subject: Re: [PATCH V10 6/8] nvme-core: check ctrl css before setting up zns Message-ID: <20210309150324.GA14966@lst.de> References: <20210309045823.18545-1-chaitanya.kulkarni@wdc.com> <20210309045823.18545-7-chaitanya.kulkarni@wdc.com> <20210309114204.GE9520@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210309114204.GE9520@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_150327_030482_0FC836A0 X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Mar 09, 2021 at 12:42:04PM +0100, Christoph Hellwig wrote: > I'll pick this up for nvme-5.12 as it is an important bug fix that > might allow not spec conformant devices to slip through. So while looking into applying this I think we should move the check earlier. What do you think of this version? --- >From 43b82e21c6ae2f7d2d99550cb348fbd08610fa06 Mon Sep 17 00:00:00 2001 From: Chaitanya Kulkarni Date: Mon, 8 Mar 2021 20:58:21 -0800 Subject: nvme-core: check ctrl css before setting up zns Ensure multiple Command Sets are supported before starting to setup a ZNS namespace. Signed-off-by: Chaitanya Kulkarni [hch: move the check around a bit] Signed-off-by: Christoph Hellwig --- drivers/nvme/host/core.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 63bb1da0861e9d..82ad5eef9d0c30 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -4096,6 +4096,12 @@ static void nvme_validate_or_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid) nsid); break; } + if (!nvme_multi_css(ctrl)) { + dev_warn(ctrl->device, + "command set not reported for nsid: %d\n", + ns->head->ns_id); + break; + } nvme_alloc_ns(ctrl, nsid, &ids); break; default: -- 2.30.1 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme